All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE
Date: Tue, 12 Jan 2016 15:27:41 +0100	[thread overview]
Message-ID: <1452608861.29014.28.camel@redhat.com> (raw)
In-Reply-To: <1452607738-1521-1-git-send-email-cfergeau@redhat.com>

On Di, 2016-01-12 at 15:08 +0100, Christophe Fergeau wrote:
> Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting
> QEMU with SPICE but no SASL, and at the same time VNC with SASL, then
> spice_server_init() will get called without a previous call to
> spice_server_set_sasl_appname(), which will cause cyrus-sasl to
> try to use /etc/sasl2/spice.conf (spice-server uses "spice" as its
> default appname) rather than the expected /etc/sasl2/qemu.conf.
> 
> This commit unconditionnally calls spice_server_set_sasl_appname()
> before calling spice_server_init() in order to use the correct appname
> even if SPICE without SASL was requested on qemu command line.

Added to patch queue.

thanks,
  Gerd

  reply	other threads:[~2016-01-12 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 14:08 [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE Christophe Fergeau
2016-01-12 14:27 ` Gerd Hoffmann [this message]
2016-01-15 23:33 ` Eric Blake
2016-01-18 10:11   ` Gerd Hoffmann
2016-01-18 10:41     ` Christophe Fergeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452608861.29014.28.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=cfergeau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.