From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Date: Tue, 12 Jan 2016 19:45:30 +0100 Message-ID: <1452624330.2628.3.camel@lynxeye.de> References: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lynxeye.de (ns.lynxeye.de [87.118.118.114]) by gabe.freedesktop.org (Postfix) with ESMTP id 627906E8BB for ; Tue, 12 Jan 2016 10:45:33 -0800 (PST) In-Reply-To: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joshua Clayton , Thierry Reding , David Airlie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgSm9zaHVhLAoKQW0gRGllbnN0YWcsIGRlbiAxMi4wMS4yMDE2LCAwODowNSAtMDgwMCBzY2hy aWViIEpvc2h1YSBDbGF5dG9uOgo+IFNoYXJwIExRMTAxSzFMWTA0IGlzIGEgMTAgaW5jaCBXWEdB ICgxMjgweDgwMCkgbHZkcyBwYW5lbAo+IAoKPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9wYW5l bC9wYW5lbC1zaW1wbGUuYyB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrKysrCgpNaXNzaW5n IGRvY3VtZW50YXRpb24gZm9yIHRoZSBEVCBiaW5kaW5nLgoKPiDCoDEgZmlsZSBjaGFuZ2VkLCAy NiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9w YW5lbC1zaW1wbGUuYwo+IGIvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jCj4g aW5kZXggZjk3YjczZS4uOTIwN2I1ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFu ZWwvcGFuZWwtc2ltcGxlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2lt cGxlLmMKPiBAQCAtNzA4LDYgKzcwOCwyOSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHBhbmVsX2Rl c2MKPiBnaWFudHBsdXNfZ3BnNDgyNzM5cXM1ID0gewo+IMKgCS5idXNfZm9ybWF0ID0gTUVESUFf QlVTX0ZNVF9SR0I4ODhfMVgyNCwKPiDCoH07Cj4gwqAKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBk aXNwbGF5X3RpbWluZyBzaGFycF9scTEwMWsxbHkwNF90aW1pbmcgPSB7Cj4gKwkucGl4ZWxjbG9j ayA9IHsgNjAwMDAwMDAsIDY1MDAwMDAwLCA4MDAwMDAwMCB9LAo+ICsJLmhhY3RpdmUgPSB7IDEy ODAsIDEyODAsIDEyODAgfSwKPiArCS5oZnJvbnRfcG9yY2ggPSB7IDIwLCAyMCwgMjAgfSwKPiAr CS5oYmFja19wb3JjaCA9IHsgMjAsIDIwLCAyMCB9LAo+ICsJLmhzeW5jX2xlbiA9IHsgMTAsIDEw LCAxMCB9LAo+ICsJLnZhY3RpdmUgPSB7IDgwMCwgODAwLCA4MDAgfSwKPiArCS52ZnJvbnRfcG9y Y2ggPSB7IDQsIDQsIDQgfSwKPiArCS52YmFja19wb3JjaCA9IHsgNCwgNCwgNCB9LAo+ICsJLnZz eW5jX2xlbiA9IHsgNCwgNCwgNCB9LAo+ICsJLmZsYWdzID0gRElTUExBWV9GTEFHU19QSVhEQVRB X1BPU0VER0UsCj4gK307Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcGFuZWxfZGVzYyBzaGFycF9s cTEwMWsxbHkwNCA9IHsKPiArCS50aW1pbmdzID0gJnNoYXJwX2xxMTAxazFseTA0X3RpbWluZywK PiArCS5udW1fdGltaW5ncyA9IDEsCj4gKwkuYnBjID0gOCwKPiArCS5zaXplID0gewo+ICsJCS53 aWR0aCA9IDIxNywKPiArCQkuaGVpZ2h0ID0gMTM2LAo+ICsJfSwKPiArCS5idXNfZm9ybWF0ID0g TUVESUFfQlVTX0ZNVF9SR0I4ODhfMVg3WDRfSkVJREEsCj4gK307Cj4gKwpUaGlzIGh1bmsgaXNu J3QgYWRkZWQgYXQgdGhlIGNvcnJlY3QgcGxhY2UuIFBsZWFzZSBrZWVwIHRoZQphbHBoYWJldGlj YWwgc29ydGluZy4KCj4gwqBzdGF0aWMgY29uc3Qgc3RydWN0IGRpc3BsYXlfdGltaW5nIGhhbm5z dGFyX2hzZDA3MHB3dzFfdGltaW5nID0gewo+IMKgCS5waXhlbGNsb2NrID0geyA2NDMwMDAwMCwg NzExMDAwMDAsIDgyMDAwMDAwIH0sCj4gwqAJLmhhY3RpdmUgPSB7IDEyODAsIDEyODAsIDEyODAg fSwKPiBAQCAtMTE0Niw2ICsxMTY5LDkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2Vf aWQKPiBwbGF0Zm9ybV9vZl9tYXRjaFtdID0gewo+IMKgCQkuY29tcGF0aWJsZSA9ICJoYW5uc3Rh cixoc2QwNzBwd3cxIiwKPiDCoAkJLmRhdGEgPSAmaGFubnN0YXJfaHNkMDcwcHd3MSwKPiDCoAl9 LCB7Cj4gKwkJLmNvbXBhdGlibGUgPSAic2hhcnAsbHExMDFrMWx5MDQiLAo+ICsJCS5kYXRhID0g JnNoYXJwX2xxMTAxazFseTA0LAo+ICsJfSwgewoKV3JvbmcgaW5zZXJ0aW9uIHBsYWNlIGFnYWlu LgoKPiDCoAkJLmNvbXBhdGlibGUgPSAiaGFubnN0YXIsaHNkMTAwcHhuMSIsCj4gwqAJCS5kYXRh ID0gJmhhbm5zdGFyX2hzZDEwMHB4bjEsCj4gwqAJfSwgewpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763245AbcALSzy (ORCPT ); Tue, 12 Jan 2016 13:55:54 -0500 Received: from ns.lynxeye.de ([87.118.118.114]:42173 "EHLO lynxeye.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1762816AbcALSzx (ORCPT ); Tue, 12 Jan 2016 13:55:53 -0500 X-Greylist: delayed 619 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 Jan 2016 13:55:52 EST Message-ID: <1452624330.2628.3.camel@lynxeye.de> Subject: Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 From: Lucas Stach To: Joshua Clayton , Thierry Reding , David Airlie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Date: Tue, 12 Jan 2016 19:45:30 +0100 In-Reply-To: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com> References: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joshua, Am Dienstag, den 12.01.2016, 08:05 -0800 schrieb Joshua Clayton: > Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel > > --- >  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ Missing documentation for the DT binding. >  1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c > index f97b73e..9207b5d 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -708,6 +708,29 @@ static const struct panel_desc > giantplus_gpg482739qs5 = { >   .bus_format = MEDIA_BUS_FMT_RGB888_1X24, >  }; >   > +static const struct display_timing sharp_lq101k1ly04_timing = { > + .pixelclock = { 60000000, 65000000, 80000000 }, > + .hactive = { 1280, 1280, 1280 }, > + .hfront_porch = { 20, 20, 20 }, > + .hback_porch = { 20, 20, 20 }, > + .hsync_len = { 10, 10, 10 }, > + .vactive = { 800, 800, 800 }, > + .vfront_porch = { 4, 4, 4 }, > + .vback_porch = { 4, 4, 4 }, > + .vsync_len = { 4, 4, 4 }, > + .flags = DISPLAY_FLAGS_PIXDATA_POSEDGE, > +}; > +static const struct panel_desc sharp_lq101k1ly04 = { > + .timings = &sharp_lq101k1ly04_timing, > + .num_timings = 1, > + .bpc = 8, > + .size = { > + .width = 217, > + .height = 136, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, > +}; > + This hunk isn't added at the correct place. Please keep the alphabetical sorting. >  static const struct display_timing hannstar_hsd070pww1_timing = { >   .pixelclock = { 64300000, 71100000, 82000000 }, >   .hactive = { 1280, 1280, 1280 }, > @@ -1146,6 +1169,9 @@ static const struct of_device_id > platform_of_match[] = { >   .compatible = "hannstar,hsd070pww1", >   .data = &hannstar_hsd070pww1, >   }, { > + .compatible = "sharp,lq101k1ly04", > + .data = &sharp_lq101k1ly04, > + }, { Wrong insertion place again. >   .compatible = "hannstar,hsd100pxn1", >   .data = &hannstar_hsd100pxn1, >   }, {