From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
Christoph Hellwig <hch@lst.de>,
Bart von Assche <bart.vanassche@sandisk.com>,
Ewan Milne <emilne@redhat.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv3 12/24] scsi_dh_alua: remove 'rel_port' from alua_dh_data structure
Date: Wed, 13 Jan 2016 09:09:47 +0100 [thread overview]
Message-ID: <1452672599-9820-13-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1452672599-9820-1-git-send-email-hare@suse.de>
The 'relative port' field is not used, and might get stale when
the port group changes. So remove the field altogether.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 10287ac..b73a7ed 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -87,7 +87,6 @@ struct alua_port_group {
struct alua_dh_data {
struct alua_port_group *pg;
int group_id;
- int rel_port;
struct scsi_device *sdev;
activate_complete callback_fn;
void *callback_data;
@@ -325,12 +324,10 @@ static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h,
return SCSI_DH_NOMEM;
return SCSI_DH_DEV_UNSUPP;
}
- h->rel_port = rel_port;
-
sdev_printk(KERN_INFO, sdev,
"%s: device %s port group %02x rel port %02x\n",
ALUA_DH_NAME, h->pg->device_id_str,
- h->group_id, h->rel_port);
+ h->group_id, rel_port);
return alua_rtpg(sdev, h->pg);
}
@@ -766,7 +763,6 @@ static int alua_bus_attach(struct scsi_device *sdev)
if (!h)
return -ENOMEM;
h->pg = NULL;
- h->rel_port = -1;
h->sdev = sdev;
err = alua_initialize(sdev, h);
--
1.8.5.6
next prev parent reply other threads:[~2016-01-13 8:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 8:09 [PATCHv3 00/24] ALUA device handler update, part II Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 01/24] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 02/24] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 03/24] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 04/24] scsi_dh_alua: call alua_rtpg() if stpg fails Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 05/24] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 06/24] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 07/24] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 08/24] scsi_dh_alua: use unique device id Hannes Reinecke
2016-01-18 17:44 ` Christoph Hellwig
2016-01-13 8:09 ` [PATCHv3 09/24] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 10/24] revert commit a8e5a2d593cb ("[SCSI] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning") Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 11/24] scsi_dh_alua: move optimize_stpg evaluation Hannes Reinecke
2016-01-13 8:09 ` Hannes Reinecke [this message]
2016-01-13 8:09 ` [PATCHv3 13/24] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 14/24] scsi_dh_alua: Allow workqueue to run synchronously Hannes Reinecke
2016-01-18 17:45 ` Christoph Hellwig
2016-01-13 8:09 ` [PATCHv3 15/24] scsi_devinfo: move scsi_get_device_flags into scsi_devinfo.h Hannes Reinecke
2016-01-18 17:49 ` Christoph Hellwig
2016-01-13 8:09 ` [PATCHv3 16/24] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA' Hannes Reinecke
2016-01-18 17:50 ` Christoph Hellwig
2016-01-13 8:09 ` [PATCHv3 17/24] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 18/24] scsi_dh_alua: update all port states Hannes Reinecke
2016-01-18 17:51 ` Christoph Hellwig
2016-01-13 8:09 ` [PATCHv3 19/24] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 20/24] scsi_dh: add 'rescan' callback Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 21/24] scsi: Add 'access_state' attribute Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 22/24] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-01-13 8:09 ` [PATCHv3 23/24] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-01-18 17:52 ` Christoph Hellwig
2016-01-13 8:09 ` [PATCHv3 24/24] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2016-01-18 17:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452672599-9820-13-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.