diff for duplicates of <1452706119.2521.3.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 51d18ca..04a6e1e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,41 +7,41 @@ On Wed, 2016-01-13 at 17:39 +0100, Anton Wuerfel wrote: > This comes with a slight change in behaviour: If > pci_netmos_9900_numports > returns 0, an additional warning is printed. ->=20 +> + Suggested-by: And I would recommend to put this patch before #13 in the series. -> Signed-off-by: Anton W=C3=BCrfel <anton.wuerfel@fau.de> +> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de> > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de> > Cc: linux-kernel@i4.cs.fau.de > --- -> =C2=A0drivers/tty/serial/8250/8250_pci.c | 4 +++- -> =C2=A01 file changed, 3 insertions(+), 1 deletion(-) ->=20 +> drivers/tty/serial/8250/8250_pci.c | 4 +++- +> 1 file changed, 3 insertions(+), 1 deletion(-) +> > diff --git a/drivers/tty/serial/8250/8250_pci.c > b/drivers/tty/serial/8250/8250_pci.c > index 1dd607f..50ab301 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -854,8 +854,10 @@ static int pci_netmos_init(struct pci_dev *dev) -> =C2=A0 } -> =C2=A0 } -> =C2=A0 -> - if (num_serial =3D=3D 0) -> + if (num_serial =3D=3D 0) { +> } +> } +> +> - if (num_serial == 0) +> + if (num_serial == 0) { > + moan_device("unknown NetMos/Mostech device", dev); -> =C2=A0 return -ENODEV; +> return -ENODEV; > + } Yep! However, you forgot to fix switch-case as well. -> =C2=A0 -> =C2=A0 return num_serial; -> =C2=A0} +> +> return num_serial; +> } ---=20 +-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy diff --git a/a/content_digest b/N1/content_digest index 9270f4c..797db5b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -37,43 +37,43 @@ "> This comes with a slight change in behaviour: If\n" "> pci_netmos_9900_numports\n" "> returns 0, an additional warning is printed.\n" - ">=20\n" + "> \n" "\n" "+ Suggested-by:\n" "\n" "And I would recommend to put this patch before #13 in the series.\n" "\n" - "> Signed-off-by: Anton W=C3=BCrfel <anton.wuerfel@fau.de>\n" + "> Signed-off-by: Anton W\303\274rfel <anton.wuerfel@fau.de>\n" "> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>\n" "> Cc: linux-kernel@i4.cs.fau.de\n" "> ---\n" - "> =C2=A0drivers/tty/serial/8250/8250_pci.c | 4 +++-\n" - "> =C2=A01 file changed, 3 insertions(+), 1 deletion(-)\n" - ">=20\n" + "> \302\240drivers/tty/serial/8250/8250_pci.c | 4 +++-\n" + "> \302\2401 file changed, 3 insertions(+), 1 deletion(-)\n" + "> \n" "> diff --git a/drivers/tty/serial/8250/8250_pci.c\n" "> b/drivers/tty/serial/8250/8250_pci.c\n" "> index 1dd607f..50ab301 100644\n" "> --- a/drivers/tty/serial/8250/8250_pci.c\n" "> +++ b/drivers/tty/serial/8250/8250_pci.c\n" "> @@ -854,8 +854,10 @@ static int pci_netmos_init(struct pci_dev *dev)\n" - "> =C2=A0\t\t}\n" - "> =C2=A0\t}\n" - "> =C2=A0\n" - "> -\tif (num_serial =3D=3D 0)\n" - "> +\tif (num_serial =3D=3D 0) {\n" + "> \302\240\t\t}\n" + "> \302\240\t}\n" + "> \302\240\n" + "> -\tif (num_serial == 0)\n" + "> +\tif (num_serial == 0) {\n" "> +\t\tmoan_device(\"unknown NetMos/Mostech device\", dev);\n" - "> =C2=A0\t\treturn -ENODEV;\n" + "> \302\240\t\treturn -ENODEV;\n" "> +\t}\n" "\n" "Yep!\n" "However, you forgot to fix switch-case as well.\n" "\n" - "> =C2=A0\n" - "> =C2=A0\treturn num_serial;\n" - "> =C2=A0}\n" + "> \302\240\n" + "> \302\240\treturn num_serial;\n" + "> \302\240}\n" "\n" - "--=20\n" + "-- \n" "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" Intel Finland Oy -2b8f5b720cfaeea92e4c08130b53e9ba77f4517de27672a10f2e4a969939cadf +e0002f416520350c7fd1c6cca030ddb2976b3b112a5d0e2f287674f96886740d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.