From: "Richard Röjfors" <richard.rojfors@gmail.com>
To: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: [meta-fsl-arm][PATCH] gal2d-renderer: Avoid deadlock on exit
Date: Wed, 13 Jan 2016 21:47:21 +0100 [thread overview]
Message-ID: <1452718041.20224.2.camel@gmail.com> (raw)
The way the worker thread was shut down was a bit racy.
Make sure to set the flag indicating the thread to stop spinning
before waking up the thread.
Signed-off-by: Richard Röjfors <richard@puffinpack.se>
---
src/gal2d-renderer.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/gal2d-renderer.c b/src/gal2d-renderer.c
index 7ebbf98..d2a29ff 100644
--- a/src/gal2d-renderer.c
+++ b/src/gal2d-renderer.c
@@ -495,21 +495,21 @@ static void *gal2d_output_worker(void *arg)
{
struct weston_output *output = (struct weston_output *)arg;
struct gal2d_output_state *go = get_output_state(output);
+ int go_on = 1;
- while(1)
+ while(go_on)
{
- if(gcoOS_WaitSignal(gcvNULL, go->signal, gcvINFINITE) == gcvSTATUS_OK )
+ int ok = gcoOS_WaitSignal(gcvNULL, go->signal, gcvINFINITE) == gcvSTATUS_OK;
+
+ pthread_mutex_lock(&go->workerMutex);
+ go_on = go->exitWorker == 0;
+ pthread_mutex_unlock(&go->workerMutex);
+
+ if (ok && go_on)
{
gal2d_flip_surface(output);
gcoOS_Signal(gcvNULL,go->busySignal, gcvTRUE);
}
- pthread_mutex_lock(&go->workerMutex);
- if(go->exitWorker == 1)
- {
- pthread_mutex_unlock(&go->workerMutex);
- break;
- }
- pthread_mutex_unlock(&go->workerMutex);
}
return 0;
}
@@ -1169,10 +1169,10 @@ gal2d_renderer_output_destroy(struct weston_output *output)
}
else
{
- gcoOS_Signal(gcvNULL,go->signal, gcvTRUE);
pthread_mutex_lock(&go->workerMutex);
go->exitWorker = 1;
pthread_mutex_unlock(&go->workerMutex);
+ gcoOS_Signal(gcvNULL,go->signal, gcvTRUE);
pthread_join(go->workerId, NULL);
}
--
2.5.0
next reply other threads:[~2016-01-13 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 20:47 Richard Röjfors [this message]
2016-01-13 21:09 ` [meta-fsl-arm][PATCH] gal2d-renderer: Avoid deadlock on exit Otavio Salvador
2016-01-14 8:17 ` Richard Röjfors
2016-01-18 16:27 ` Richard Röjfors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452718041.20224.2.camel@gmail.com \
--to=richard.rojfors@gmail.com \
--cc=meta-freescale@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.