From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v6 12/15] tty: serial: 8250: Correct conversion specifiers Date: Thu, 14 Jan 2016 11:31:24 +0200 Message-ID: <1452763884.2521.23.camel@linux.intel.com> References: <1452720561-28443-1-git-send-email-anton.wuerfel@fau.de> <1452720561-28443-13-git-send-email-anton.wuerfel@fau.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Joachim Eastwood , Matthias Brugger , Masahiro Yamada , Peter Hurley , Sebastian Andrzej Siewior , Andy Shevchenko , Phillip Raffeck , Heikki Krogerus , Peter Hung , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel To: Anton Wuerfel , Greg Kroah-Hartman Return-path: In-Reply-To: <1452720561-28443-13-git-send-email-anton.wuerfel@fau.de> List-ID: List-Id: linux-parisc.vger.kernel.org On Wed, 2016-01-13 at 22:29 +0100, Anton Wuerfel wrote: > This patch fixes compiler warnings about wrong conversion specifiers=C2= =A0 This patch obviously doesn't _fix_warnings_, rather changes specifiers to get it consistent with argument. > used > in a debug output in 8250_pnp.c. The precise warning is: Usually there is no need to cite all lines=E2=80=A6 >=20 > drivers/tty/serial/8250/8250_pnp.c: In function =E2=80=98serial_pnp_p= robe=E2=80=99: > include/linux/dynamic_debug.h:64:16: warning: format =E2=80=98%x=E2=80= =99 expects > argument > of [...] OK. >=20 > include/linux/dynamic_debug.h:84:2: note: in expansion of macro > =E2=80=98DEFINE_DYNAMIC_DEBUG_METADATA=E2=80=99 >=20 > include/linux/device.h:1179:2: note: in expansion of macro > =E2=80=98dynamic_dev_dbg=E2=80=99 Redundant. >=20 > drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro > =E2=80=98dev_dbg=E2=80=99 > =C2=A0 dev_dbg(&dev->dev, > =C2=A0 ^ > include/linux/dynamic_debug.h:64:16: warning: format =E2=80=98%lx=E2=80= =99 expects > argument > of [...] OK. >=20 > include/linux/dynamic_debug.h:84:2: note: in expansion of macro > =E2=80=98DEFINE_DYNAMIC_DEBUG_METADATA=E2=80=99 >=20 > include/linux/device.h:1179:2: note: in expansion of macro > =E2=80=98dynamic_dev_dbg=E2=80=99 Redundant. >=20 > drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro > =E2=80=98dev_dbg=E2=80=99 > =C2=A0 dev_dbg(&dev->dev, > =C2=A0 ^ >=20 > Those warnings never got triggered, because the command was nested > in an #ifdef, which is removed by a patch of this series. >=20 > Signed-off-by: Anton W=C3=BCrfel > Signed-off-by: Phillip Raffeck > Cc: linux-kernel@i4.cs.fau.de > --- > =C2=A0drivers/tty/serial/8250/8250_pnp.c | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/tty/serial/8250/8250_pnp.c > b/drivers/tty/serial/8250/8250_pnp.c > index 0c32c59..92f4412 100644 > --- a/drivers/tty/serial/8250/8250_pnp.c > +++ b/drivers/tty/serial/8250/8250_pnp.c > @@ -465,8 +465,8 @@ serial_pnp_probe(struct pnp_dev *dev, const > struct pnp_device_id *dev_id) > =C2=A0 return -ENODEV; > =C2=A0 > =C2=A0 dev_dbg(&dev->dev, > - =C2=A0"Setup PNP port: port %x, mem 0x%lx, irq %d, type > %d\n", > - =C2=A0uart.port.iobase, uart.port.mapbase, > + =C2=A0"Setup PNP port: port %lx, mem 0x%lx, irq %d, type > %d\n", > + =C2=A0uart.port.iobase, (unsigned long)uart.port.mapbase, This approach is not fully correct. In Linux kernel we have %p extensions to cover some custom types such as resource_size_t, of which mapbase is. Thus, "Setup PNP port: port %lx, mem %pa, irq %d, type %d\n", uart.port.iobase, &uart.port.mapbase, looks better. > =C2=A0 =C2=A0uart.port.irq, uart.port.iotype); > =C2=A0 > =C2=A0 if (flags & CIR_PORT) { --=20 Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-parisc"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v6 12/15] tty: serial: 8250: Correct conversion specifiers Date: Thu, 14 Jan 2016 11:31:24 +0200 Message-ID: <1452763884.2521.23.camel@linux.intel.com> References: <1452720561-28443-1-git-send-email-anton.wuerfel@fau.de> <1452720561-28443-13-git-send-email-anton.wuerfel@fau.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1452720561-28443-13-git-send-email-anton.wuerfel@fau.de> Sender: linux-parisc-owner@vger.kernel.org To: Anton Wuerfel , Greg Kroah-Hartman Cc: Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Joachim Eastwood , Matthias Brugger , Masahiro Yamada , Peter Hurley , Sebastian Andrzej Siewior , Andy Shevchenko , Phillip Raffeck , Heikki Krogerus , Peter Hung , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel List-Id: linux-serial@vger.kernel.org On Wed, 2016-01-13 at 22:29 +0100, Anton Wuerfel wrote: > This patch fixes compiler warnings about wrong conversion specifiers=C2= =A0 This patch obviously doesn't _fix_warnings_, rather changes specifiers to get it consistent with argument. > used > in a debug output in 8250_pnp.c. The precise warning is: Usually there is no need to cite all lines=E2=80=A6 >=20 > drivers/tty/serial/8250/8250_pnp.c: In function =E2=80=98serial_pnp_p= robe=E2=80=99: > include/linux/dynamic_debug.h:64:16: warning: format =E2=80=98%x=E2=80= =99 expects > argument > of [...] OK. >=20 > include/linux/dynamic_debug.h:84:2: note: in expansion of macro > =E2=80=98DEFINE_DYNAMIC_DEBUG_METADATA=E2=80=99 >=20 > include/linux/device.h:1179:2: note: in expansion of macro > =E2=80=98dynamic_dev_dbg=E2=80=99 Redundant. >=20 > drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro > =E2=80=98dev_dbg=E2=80=99 > =C2=A0 dev_dbg(&dev->dev, > =C2=A0 ^ > include/linux/dynamic_debug.h:64:16: warning: format =E2=80=98%lx=E2=80= =99 expects > argument > of [...] OK. >=20 > include/linux/dynamic_debug.h:84:2: note: in expansion of macro > =E2=80=98DEFINE_DYNAMIC_DEBUG_METADATA=E2=80=99 >=20 > include/linux/device.h:1179:2: note: in expansion of macro > =E2=80=98dynamic_dev_dbg=E2=80=99 Redundant. >=20 > drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro > =E2=80=98dev_dbg=E2=80=99 > =C2=A0 dev_dbg(&dev->dev, > =C2=A0 ^ >=20 > Those warnings never got triggered, because the command was nested > in an #ifdef, which is removed by a patch of this series. >=20 > Signed-off-by: Anton W=C3=BCrfel > Signed-off-by: Phillip Raffeck > Cc: linux-kernel@i4.cs.fau.de > --- > =C2=A0drivers/tty/serial/8250/8250_pnp.c | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/tty/serial/8250/8250_pnp.c > b/drivers/tty/serial/8250/8250_pnp.c > index 0c32c59..92f4412 100644 > --- a/drivers/tty/serial/8250/8250_pnp.c > +++ b/drivers/tty/serial/8250/8250_pnp.c > @@ -465,8 +465,8 @@ serial_pnp_probe(struct pnp_dev *dev, const > struct pnp_device_id *dev_id) > =C2=A0 return -ENODEV; > =C2=A0 > =C2=A0 dev_dbg(&dev->dev, > - =C2=A0"Setup PNP port: port %x, mem 0x%lx, irq %d, type > %d\n", > - =C2=A0uart.port.iobase, uart.port.mapbase, > + =C2=A0"Setup PNP port: port %lx, mem 0x%lx, irq %d, type > %d\n", > + =C2=A0uart.port.iobase, (unsigned long)uart.port.mapbase, This approach is not fully correct. In Linux kernel we have %p extensions to cover some custom types such as resource_size_t, of which mapbase is. Thus, "Setup PNP port: port %lx, mem %pa, irq %d, type %d\n", uart.port.iobase, &uart.port.mapbase, looks better. > =C2=A0 =C2=A0uart.port.irq, uart.port.iotype); > =C2=A0 > =C2=A0 if (flags & CIR_PORT) { --=20 Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-parisc"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753131AbcANJbJ (ORCPT ); Thu, 14 Jan 2016 04:31:09 -0500 Received: from mga09.intel.com ([134.134.136.24]:33048 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752811AbcANJbB (ORCPT ); Thu, 14 Jan 2016 04:31:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,293,1449561600"; d="scan'208";a="890288678" Message-ID: <1452763884.2521.23.camel@linux.intel.com> Subject: Re: [PATCH v6 12/15] tty: serial: 8250: Correct conversion specifiers From: Andy Shevchenko To: Anton Wuerfel , Greg Kroah-Hartman Cc: Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Joachim Eastwood , Matthias Brugger , Masahiro Yamada , Peter Hurley , Sebastian Andrzej Siewior , Andy Shevchenko , Phillip Raffeck , Heikki Krogerus , Peter Hung , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel Date: Thu, 14 Jan 2016 11:31:24 +0200 In-Reply-To: <1452720561-28443-13-git-send-email-anton.wuerfel@fau.de> References: <1452720561-28443-1-git-send-email-anton.wuerfel@fau.de> <1452720561-28443-13-git-send-email-anton.wuerfel@fau.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-01-13 at 22:29 +0100, Anton Wuerfel wrote: > This patch fixes compiler warnings about wrong conversion specifiers  This patch obviously doesn't _fix_warnings_, rather changes specifiers to get it consistent with argument. > used > in a debug output in 8250_pnp.c. The precise warning is: Usually there is no need to cite all lines… > > drivers/tty/serial/8250/8250_pnp.c: In function ‘serial_pnp_probe’: > include/linux/dynamic_debug.h:64:16: warning: format ‘%x’ expects > argument > of [...] OK. > > include/linux/dynamic_debug.h:84:2: note: in expansion of macro > ‘DEFINE_DYNAMIC_DEBUG_METADATA’ > > include/linux/device.h:1179:2: note: in expansion of macro > ‘dynamic_dev_dbg’ Redundant. > > drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro > ‘dev_dbg’ >   dev_dbg(&dev->dev, >   ^ > include/linux/dynamic_debug.h:64:16: warning: format ‘%lx’ expects > argument > of [...] OK. > > include/linux/dynamic_debug.h:84:2: note: in expansion of macro > ‘DEFINE_DYNAMIC_DEBUG_METADATA’ > > include/linux/device.h:1179:2: note: in expansion of macro > ‘dynamic_dev_dbg’ Redundant. > > drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro > ‘dev_dbg’ >   dev_dbg(&dev->dev, >   ^ > > Those warnings never got triggered, because the command was nested > in an #ifdef, which is removed by a patch of this series. > > Signed-off-by: Anton Würfel > Signed-off-by: Phillip Raffeck > Cc: linux-kernel@i4.cs.fau.de > --- >  drivers/tty/serial/8250/8250_pnp.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_pnp.c > b/drivers/tty/serial/8250/8250_pnp.c > index 0c32c59..92f4412 100644 > --- a/drivers/tty/serial/8250/8250_pnp.c > +++ b/drivers/tty/serial/8250/8250_pnp.c > @@ -465,8 +465,8 @@ serial_pnp_probe(struct pnp_dev *dev, const > struct pnp_device_id *dev_id) >   return -ENODEV; >   >   dev_dbg(&dev->dev, > -  "Setup PNP port: port %x, mem 0x%lx, irq %d, type > %d\n", > -  uart.port.iobase, uart.port.mapbase, > +  "Setup PNP port: port %lx, mem 0x%lx, irq %d, type > %d\n", > +  uart.port.iobase, (unsigned long)uart.port.mapbase, This approach is not fully correct. In Linux kernel we have %p extensions to cover some custom types such as resource_size_t, of which mapbase is. Thus, "Setup PNP port: port %lx, mem %pa, irq %d, type %d\n", uart.port.iobase, &uart.port.mapbase, looks better. >    uart.port.irq, uart.port.iotype); >   >   if (flags & CIR_PORT) { -- Andy Shevchenko Intel Finland Oy