diff for duplicates of <1452764635.2521.28.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 98a2647..37874a7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ On Thu, 2016-01-14 at 11:00 +0800, Yisen Zhuang wrote: > -> ? 2016/1/13 11:14, Kejian Yan ??: +> 在 2016/1/13 11:14, Kejian Yan 写道: > > This patch replace the assoication between dsaf and enet from > > string > > matching to object reference. It requires the DTS to be updated @@ -14,51 +14,51 @@ On Thu, 2016-01-14 at 11:00 +0800, Yisen Zhuang wrote: There are few thing below. ->? +> > > --- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c > > +++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c > > @@ -847,6 +847,7 @@ static struct hnae_ae_ops hns_dsaf_ops = { -> > ?int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev) -> > ?{ -> > ? struct hnae_ae_dev *ae_dev = &dsaf_dev->ae_dev; +> > int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev) +> > { +> > struct hnae_ae_dev *ae_dev = &dsaf_dev->ae_dev; > > + static atomic_t id = ATOMIC_INIT(-1); -> > ? -> > ? switch (dsaf_dev->dsaf_ver) { -> > ? case AE_VERSION_1: +> > +> > switch (dsaf_dev->dsaf_ver) { +> > case AE_VERSION_1: > > @@ -858,6 +859,9 @@ int hns_dsaf_ae_init(struct dsaf_device > > *dsaf_dev) -> > ? default: -> > ? break; -> > ? } +> > default: +> > break; +> > } > > + > > + snprintf(ae_dev->name, AE_NAME_SIZE, "%s%d", > > DSAF_DEVICE_NAME, -> > + ?(int)atomic_inc_return(&id)); +> > + (int)atomic_inc_return(&id)); If you bind/unbind device enough times you may get an overflow and end up with name of existing device (if you have 1+ of them in the system). To avoid such situation better to use IDA/IDR framework. -> >? +> > > > --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c > > +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c > > @@ -1802,7 +1802,7 @@ static int hns_nic_try_get_ae(struct > > net_device *ndev) -> > ? int ret; -> > ? -> > ? h = hnae_get_handle(&priv->netdev->dev, -> > - ????priv->ae_name, priv->port_id, NULL); -> > + ????priv->ae_node, priv->port_id, NULL); -> > ? if (IS_ERR_OR_NULL(h)) { -> > ? ret = PTR_ERR(h); -> > ? dev_dbg(priv->dev, "has not handle, register +> > int ret; +> > +> > h = hnae_get_handle(&priv->netdev->dev, +> > - priv->ae_name, priv->port_id, NULL); +> > + priv->ae_node, priv->port_id, NULL); +> > if (IS_ERR_OR_NULL(h)) { +> > ret = PTR_ERR(h); +> > dev_dbg(priv->dev, "has not handle, register > > notifier!\n"); > > @@ -1880,9 +1880,12 @@ static int hns_nic_dev_probe(struct > > platform_device *pdev) -> > ? else -> > ? priv->enet_ver = AE_VERSION_2; -> > ? +> > else +> > priv->enet_ver = AE_VERSION_2; +> > > > - ret = of_property_read_string(node, "ae-name", &priv- > > >ae_name); > > - if (ret) @@ -76,25 +76,30 @@ To avoid such situation better to use IDA/IDR framework. (2) > > + } -> > ? -> > ? ret = of_property_read_u32(node, "port-id", &priv- +> > +> > ret = of_property_read_u32(node, "port-id", &priv- > > >port_id); -> > ? if (ret) +> > if (ret) > > @@ -1945,6 +1948,8 @@ static int hns_nic_dev_probe(struct > > platform_device *pdev) -> > ? -> > ?out_notify_fail: -> > ? (void)cancel_work_sync(&priv->service_task); +> > +> > out_notify_fail: +> > (void)cancel_work_sync(&priv->service_task); > > +out_read_handle_fai: > > + Redundant line -> > ?out_read_string_fail: +> > out_read_string_fail: Leftover? (see (1) and (2) ) -- -Andy Shevchenko <andriy.shevchenko@linux.intel.com> +Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Intel Finland Oy + +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 5b86ea0..e818b07 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,35 @@ "ref\01452654880-28980-1-git-send-email-yankejian@huawei.com\0" "ref\056970F48.9060504@huawei.com\0" - "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" - "Subject\0[PATCH v2 next-next] net: hns: enet specifies a reference to dsaf\0" + "ref\056970F48.9060504-hv44wF8Li93QT0dZR+AlfA@public.gmane.org\0" + "From\0Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" + "Subject\0Re: [PATCH v2 next-next] net: hns: enet specifies a reference to dsaf\0" "Date\0Thu, 14 Jan 2016 11:43:55 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Yisen Zhuang <Yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>" + Kejian Yan <yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> + davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org + robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org + pawel.moll-5wv7dgnIgG8@public.gmane.org + mark.rutland-5wv7dgnIgG8@public.gmane.org + ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org + galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org + catalin.marinas-5wv7dgnIgG8@public.gmane.org + will.deacon-5wv7dgnIgG8@public.gmane.org + huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org + liguozhu-hv44wF8Li93QT0dZR+AlfA@public.gmane.org + arnd-r2nGTMty4D4@public.gmane.org + fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org + salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org + " lisheng011-hv44wF8Li93QT0dZR+AlfA@public.gmane.org\0" + "Cc\0devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" + netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" "\00:1\0" "b\0" "On Thu, 2016-01-14 at 11:00 +0800, Yisen Zhuang wrote:\n" "> \n" - "> ? 2016/1/13 11:14, Kejian Yan ??:\n" + "> \345\234\250 2016/1/13 11:14, Kejian Yan \345\206\231\351\201\223:\n" "> > This patch replace the assoication between dsaf and enet from\n" "> > string\n" "> > matching to object reference. It requires the DTS to be updated\n" @@ -22,51 +43,51 @@ "\n" "There are few thing below.\n" "\n" - ">?\n" + ">\302\240\n" "> > --- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c\n" "> > +++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c\n" "> > @@ -847,6 +847,7 @@ static struct hnae_ae_ops hns_dsaf_ops = {\n" - "> > ?int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev)\n" - "> > ?{\n" - "> > ?\tstruct hnae_ae_dev *ae_dev = &dsaf_dev->ae_dev;\n" + "> > \302\240int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev)\n" + "> > \302\240{\n" + "> > \302\240\tstruct hnae_ae_dev *ae_dev = &dsaf_dev->ae_dev;\n" "> > +\tstatic atomic_t id = ATOMIC_INIT(-1);\n" - "> > ?\n" - "> > ?\tswitch (dsaf_dev->dsaf_ver) {\n" - "> > ?\tcase AE_VERSION_1:\n" + "> > \302\240\n" + "> > \302\240\tswitch (dsaf_dev->dsaf_ver) {\n" + "> > \302\240\tcase AE_VERSION_1:\n" "> > @@ -858,6 +859,9 @@ int hns_dsaf_ae_init(struct dsaf_device\n" "> > *dsaf_dev)\n" - "> > ?\tdefault:\n" - "> > ?\t\tbreak;\n" - "> > ?\t}\n" + "> > \302\240\tdefault:\n" + "> > \302\240\t\tbreak;\n" + "> > \302\240\t}\n" "> > +\n" "> > +\tsnprintf(ae_dev->name, AE_NAME_SIZE, \"%s%d\",\n" "> > DSAF_DEVICE_NAME,\n" - "> > +\t\t?(int)atomic_inc_return(&id));\n" + "> > +\t\t\302\240(int)atomic_inc_return(&id));\n" "\n" "If you bind/unbind device enough times you may get an overflow and end\n" "up with name of existing device (if you have 1+ of them in the system).\n" "\n" "To avoid such situation better to use IDA/IDR framework.\n" "\n" - "> >?\n" + "> >\302\240\n" "> > --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c\n" "> > +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c\n" "> > @@ -1802,7 +1802,7 @@ static int hns_nic_try_get_ae(struct\n" "> > net_device *ndev)\n" - "> > ?\tint ret;\n" - "> > ?\n" - "> > ?\th = hnae_get_handle(&priv->netdev->dev,\n" - "> > -\t\t\t????priv->ae_name, priv->port_id, NULL);\n" - "> > +\t\t\t????priv->ae_node, priv->port_id, NULL);\n" - "> > ?\tif (IS_ERR_OR_NULL(h)) {\n" - "> > ?\t\tret = PTR_ERR(h);\n" - "> > ?\t\tdev_dbg(priv->dev, \"has not handle, register\n" + "> > \302\240\tint ret;\n" + "> > \302\240\n" + "> > \302\240\th = hnae_get_handle(&priv->netdev->dev,\n" + "> > -\t\t\t\302\240\302\240\302\240\302\240priv->ae_name, priv->port_id, NULL);\n" + "> > +\t\t\t\302\240\302\240\302\240\302\240priv->ae_node, priv->port_id, NULL);\n" + "> > \302\240\tif (IS_ERR_OR_NULL(h)) {\n" + "> > \302\240\t\tret = PTR_ERR(h);\n" + "> > \302\240\t\tdev_dbg(priv->dev, \"has not handle, register\n" "> > notifier!\\n\");\n" "> > @@ -1880,9 +1880,12 @@ static int hns_nic_dev_probe(struct\n" "> > platform_device *pdev)\n" - "> > ?\telse\n" - "> > ?\t\tpriv->enet_ver = AE_VERSION_2;\n" - "> > ?\n" + "> > \302\240\telse\n" + "> > \302\240\t\tpriv->enet_ver = AE_VERSION_2;\n" + "> > \302\240\n" "> > -\tret = of_property_read_string(node, \"ae-name\", &priv-\n" "> > >ae_name);\n" "> > -\tif (ret)\n" @@ -84,27 +105,32 @@ "(2)\n" "\n" "> > +\t}\n" - "> > ?\n" - "> > ?\tret = of_property_read_u32(node, \"port-id\", &priv-\n" + "> > \302\240\n" + "> > \302\240\tret = of_property_read_u32(node, \"port-id\", &priv-\n" "> > >port_id);\n" - "> > ?\tif (ret)\n" + "> > \302\240\tif (ret)\n" "> > @@ -1945,6 +1948,8 @@ static int hns_nic_dev_probe(struct\n" "> > platform_device *pdev)\n" - "> > ?\n" - "> > ?out_notify_fail:\n" - "> > ?\t(void)cancel_work_sync(&priv->service_task);\n" + "> > \302\240\n" + "> > \302\240out_notify_fail:\n" + "> > \302\240\t(void)cancel_work_sync(&priv->service_task);\n" "> > +out_read_handle_fai:\n" "\n" "> > +\n" "\n" "Redundant line\n" "\n" - "> > ?out_read_string_fail:\n" + "> > \302\240out_read_string_fail:\n" "\n" "Leftover? (see (1) and (2) )\n" "\n" "-- \n" - "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" - Intel Finland Oy + "Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" + "Intel Finland Oy\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -554bc5ee4d6a5ec468fb59e052fe67941e3f96e676b48e7b7a660a0b01aa875e +a7f732804f55611fa0549c0d45616d1cb7c2a5767d34748445355ab1e01dd12c
diff --git a/a/1.txt b/N2/1.txt index 98a2647..d5f157c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,6 +1,6 @@ On Thu, 2016-01-14 at 11:00 +0800, Yisen Zhuang wrote: > -> ? 2016/1/13 11:14, Kejian Yan ??: +> 在 2016/1/13 11:14, Kejian Yan 写道: > > This patch replace the assoication between dsaf and enet from > > string > > matching to object reference. It requires the DTS to be updated @@ -14,51 +14,51 @@ On Thu, 2016-01-14 at 11:00 +0800, Yisen Zhuang wrote: There are few thing below. ->? +> > > --- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c > > +++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c > > @@ -847,6 +847,7 @@ static struct hnae_ae_ops hns_dsaf_ops = { -> > ?int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev) -> > ?{ -> > ? struct hnae_ae_dev *ae_dev = &dsaf_dev->ae_dev; +> > int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev) +> > { +> > struct hnae_ae_dev *ae_dev = &dsaf_dev->ae_dev; > > + static atomic_t id = ATOMIC_INIT(-1); -> > ? -> > ? switch (dsaf_dev->dsaf_ver) { -> > ? case AE_VERSION_1: +> > +> > switch (dsaf_dev->dsaf_ver) { +> > case AE_VERSION_1: > > @@ -858,6 +859,9 @@ int hns_dsaf_ae_init(struct dsaf_device > > *dsaf_dev) -> > ? default: -> > ? break; -> > ? } +> > default: +> > break; +> > } > > + > > + snprintf(ae_dev->name, AE_NAME_SIZE, "%s%d", > > DSAF_DEVICE_NAME, -> > + ?(int)atomic_inc_return(&id)); +> > + (int)atomic_inc_return(&id)); If you bind/unbind device enough times you may get an overflow and end up with name of existing device (if you have 1+ of them in the system). To avoid such situation better to use IDA/IDR framework. -> >? +> > > > --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c > > +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c > > @@ -1802,7 +1802,7 @@ static int hns_nic_try_get_ae(struct > > net_device *ndev) -> > ? int ret; -> > ? -> > ? h = hnae_get_handle(&priv->netdev->dev, -> > - ????priv->ae_name, priv->port_id, NULL); -> > + ????priv->ae_node, priv->port_id, NULL); -> > ? if (IS_ERR_OR_NULL(h)) { -> > ? ret = PTR_ERR(h); -> > ? dev_dbg(priv->dev, "has not handle, register +> > int ret; +> > +> > h = hnae_get_handle(&priv->netdev->dev, +> > - priv->ae_name, priv->port_id, NULL); +> > + priv->ae_node, priv->port_id, NULL); +> > if (IS_ERR_OR_NULL(h)) { +> > ret = PTR_ERR(h); +> > dev_dbg(priv->dev, "has not handle, register > > notifier!\n"); > > @@ -1880,9 +1880,12 @@ static int hns_nic_dev_probe(struct > > platform_device *pdev) -> > ? else -> > ? priv->enet_ver = AE_VERSION_2; -> > ? +> > else +> > priv->enet_ver = AE_VERSION_2; +> > > > - ret = of_property_read_string(node, "ae-name", &priv- > > >ae_name); > > - if (ret) @@ -76,22 +76,22 @@ To avoid such situation better to use IDA/IDR framework. (2) > > + } -> > ? -> > ? ret = of_property_read_u32(node, "port-id", &priv- +> > +> > ret = of_property_read_u32(node, "port-id", &priv- > > >port_id); -> > ? if (ret) +> > if (ret) > > @@ -1945,6 +1948,8 @@ static int hns_nic_dev_probe(struct > > platform_device *pdev) -> > ? -> > ?out_notify_fail: -> > ? (void)cancel_work_sync(&priv->service_task); +> > +> > out_notify_fail: +> > (void)cancel_work_sync(&priv->service_task); > > +out_read_handle_fai: > > + Redundant line -> > ?out_read_string_fail: +> > out_read_string_fail: Leftover? (see (1) and (2) ) diff --git a/a/content_digest b/N2/content_digest index 5b86ea0..87d8dfa 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,14 +1,34 @@ "ref\01452654880-28980-1-git-send-email-yankejian@huawei.com\0" "ref\056970F48.9060504@huawei.com\0" - "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" - "Subject\0[PATCH v2 next-next] net: hns: enet specifies a reference to dsaf\0" + "From\0Andy Shevchenko <andriy.shevchenko@linux.intel.com>\0" + "Subject\0Re: [PATCH v2 next-next] net: hns: enet specifies a reference to dsaf\0" "Date\0Thu, 14 Jan 2016 11:43:55 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Yisen Zhuang <Yisen.zhuang@huawei.com>" + Kejian Yan <yankejian@huawei.com> + davem@davemloft.net + robh+dt@kernel.org + pawel.moll@arm.com + mark.rutland@arm.com + ijc+devicetree@hellion.org.uk + galak@codeaurora.org + catalin.marinas@arm.com + will.deacon@arm.com + huangdaode@hisilicon.com + liguozhu@huawei.com + arnd@arndb.de + fengguang.wu@intel.com + salil.mehta@huawei.com + " lisheng011@huawei.com\0" + "Cc\0devicetree@vger.kernel.org" + netdev@vger.kernel.org + linuxarm@huawei.com + linux-kernel@vger.kernel.org + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, 2016-01-14 at 11:00 +0800, Yisen Zhuang wrote:\n" "> \n" - "> ? 2016/1/13 11:14, Kejian Yan ??:\n" + "> \345\234\250 2016/1/13 11:14, Kejian Yan \345\206\231\351\201\223:\n" "> > This patch replace the assoication between dsaf and enet from\n" "> > string\n" "> > matching to object reference. It requires the DTS to be updated\n" @@ -22,51 +42,51 @@ "\n" "There are few thing below.\n" "\n" - ">?\n" + ">\302\240\n" "> > --- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c\n" "> > +++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c\n" "> > @@ -847,6 +847,7 @@ static struct hnae_ae_ops hns_dsaf_ops = {\n" - "> > ?int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev)\n" - "> > ?{\n" - "> > ?\tstruct hnae_ae_dev *ae_dev = &dsaf_dev->ae_dev;\n" + "> > \302\240int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev)\n" + "> > \302\240{\n" + "> > \302\240\tstruct hnae_ae_dev *ae_dev = &dsaf_dev->ae_dev;\n" "> > +\tstatic atomic_t id = ATOMIC_INIT(-1);\n" - "> > ?\n" - "> > ?\tswitch (dsaf_dev->dsaf_ver) {\n" - "> > ?\tcase AE_VERSION_1:\n" + "> > \302\240\n" + "> > \302\240\tswitch (dsaf_dev->dsaf_ver) {\n" + "> > \302\240\tcase AE_VERSION_1:\n" "> > @@ -858,6 +859,9 @@ int hns_dsaf_ae_init(struct dsaf_device\n" "> > *dsaf_dev)\n" - "> > ?\tdefault:\n" - "> > ?\t\tbreak;\n" - "> > ?\t}\n" + "> > \302\240\tdefault:\n" + "> > \302\240\t\tbreak;\n" + "> > \302\240\t}\n" "> > +\n" "> > +\tsnprintf(ae_dev->name, AE_NAME_SIZE, \"%s%d\",\n" "> > DSAF_DEVICE_NAME,\n" - "> > +\t\t?(int)atomic_inc_return(&id));\n" + "> > +\t\t\302\240(int)atomic_inc_return(&id));\n" "\n" "If you bind/unbind device enough times you may get an overflow and end\n" "up with name of existing device (if you have 1+ of them in the system).\n" "\n" "To avoid such situation better to use IDA/IDR framework.\n" "\n" - "> >?\n" + "> >\302\240\n" "> > --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c\n" "> > +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c\n" "> > @@ -1802,7 +1802,7 @@ static int hns_nic_try_get_ae(struct\n" "> > net_device *ndev)\n" - "> > ?\tint ret;\n" - "> > ?\n" - "> > ?\th = hnae_get_handle(&priv->netdev->dev,\n" - "> > -\t\t\t????priv->ae_name, priv->port_id, NULL);\n" - "> > +\t\t\t????priv->ae_node, priv->port_id, NULL);\n" - "> > ?\tif (IS_ERR_OR_NULL(h)) {\n" - "> > ?\t\tret = PTR_ERR(h);\n" - "> > ?\t\tdev_dbg(priv->dev, \"has not handle, register\n" + "> > \302\240\tint ret;\n" + "> > \302\240\n" + "> > \302\240\th = hnae_get_handle(&priv->netdev->dev,\n" + "> > -\t\t\t\302\240\302\240\302\240\302\240priv->ae_name, priv->port_id, NULL);\n" + "> > +\t\t\t\302\240\302\240\302\240\302\240priv->ae_node, priv->port_id, NULL);\n" + "> > \302\240\tif (IS_ERR_OR_NULL(h)) {\n" + "> > \302\240\t\tret = PTR_ERR(h);\n" + "> > \302\240\t\tdev_dbg(priv->dev, \"has not handle, register\n" "> > notifier!\\n\");\n" "> > @@ -1880,9 +1880,12 @@ static int hns_nic_dev_probe(struct\n" "> > platform_device *pdev)\n" - "> > ?\telse\n" - "> > ?\t\tpriv->enet_ver = AE_VERSION_2;\n" - "> > ?\n" + "> > \302\240\telse\n" + "> > \302\240\t\tpriv->enet_ver = AE_VERSION_2;\n" + "> > \302\240\n" "> > -\tret = of_property_read_string(node, \"ae-name\", &priv-\n" "> > >ae_name);\n" "> > -\tif (ret)\n" @@ -84,22 +104,22 @@ "(2)\n" "\n" "> > +\t}\n" - "> > ?\n" - "> > ?\tret = of_property_read_u32(node, \"port-id\", &priv-\n" + "> > \302\240\n" + "> > \302\240\tret = of_property_read_u32(node, \"port-id\", &priv-\n" "> > >port_id);\n" - "> > ?\tif (ret)\n" + "> > \302\240\tif (ret)\n" "> > @@ -1945,6 +1948,8 @@ static int hns_nic_dev_probe(struct\n" "> > platform_device *pdev)\n" - "> > ?\n" - "> > ?out_notify_fail:\n" - "> > ?\t(void)cancel_work_sync(&priv->service_task);\n" + "> > \302\240\n" + "> > \302\240out_notify_fail:\n" + "> > \302\240\t(void)cancel_work_sync(&priv->service_task);\n" "> > +out_read_handle_fai:\n" "\n" "> > +\n" "\n" "Redundant line\n" "\n" - "> > ?out_read_string_fail:\n" + "> > \302\240out_read_string_fail:\n" "\n" "Leftover? (see (1) and (2) )\n" "\n" @@ -107,4 +127,4 @@ "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" Intel Finland Oy -554bc5ee4d6a5ec468fb59e052fe67941e3f96e676b48e7b7a660a0b01aa875e +a1eaa17cea95e888937b0359e9e7ed40598bf9b3a67e82e27421a7f015eef6f4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.