From: "Pan, Miaoqing" <miaoqing@qti.qualcomm.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>,
"miaoqing@codeaurora.org" <miaoqing@codeaurora.org>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>
Subject: Re: [PATCH 1/5] ath9k: avoid ANI restart if no trigger
Date: Fri, 15 Jan 2016 08:38:46 +0000 [thread overview]
Message-ID: <1452847122461.2165@qti.qualcomm.com> (raw)
In-Reply-To: <871t9j8e7i.fsf@kamboji.qca.qualcomm.com>
The commit 54da20d83f0e7fe87b75aec44bc2b1448d119320 ("ath9k_hw: improve ANI processing and rx desensitizing parameters") first introduced this issue, ath9k_ani_restart() is always be invoked is wrong.
Thanks,
Miaoqing
________________________________________
From: Valo, Kalle
Sent: Friday, January 15, 2016 4:00 PM
To: miaoqing@codeaurora.org
Cc: linville@tuxdriver.com; linux-wireless@vger.kernel.org; ath9k-devel
Subject: Re: [PATCH 1/5] ath9k: avoid ANI restart if no trigger
<miaoqing@codeaurora.org> writes:
> From: Miaoqing Pan <miaoqing@codeaurora.org>
>
> ath9k_ani_restart() is always be invoked even if the trigger
> condition is false.
>
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
Why? The commit log should always answer that.
--
Kalle Valo
next prev parent reply other threads:[~2016-01-15 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 1:23 [PATCH 0/5] ath9k bug fixes miaoqing
2016-01-15 1:23 ` [PATCH 1/5] ath9k: avoid ANI restart if no trigger miaoqing
2016-01-15 8:00 ` Kalle Valo
2016-01-15 8:38 ` Pan, Miaoqing [this message]
2016-01-15 9:41 ` Kalle Valo
2016-01-15 11:28 ` Felix Fietkau
2016-01-15 1:23 ` [PATCH 2/5] ath9k: clean up ANI per-channel pointer checking miaoqing
2016-01-15 1:23 ` [PATCH 3/5] ath9k: do not reset while BB panic(0x4000409) on ar9561 miaoqing
2016-01-15 1:23 ` [PATCH 4/5] ath9k: fix inconsistent use of tab and space in indentation miaoqing
2016-01-15 1:23 ` [PATCH 5/5] ath9k: fix data bus error on ar9300 and ar9580 miaoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452847122461.2165@qti.qualcomm.com \
--to=miaoqing@qti.qualcomm.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=miaoqing@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.