From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] tools: fix python install with "xentoollog"
Date: Fri, 15 Jan 2016 10:56:36 +0000
Message-ID: <1452855396.32341.66.camel@citrix.com>
References: <1452654971-4522-1-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=815b692d9=Ian.Campbell@citrix.com>)
	id 1aK24A-0005ji-5U
	for xen-devel@lists.xenproject.org; Fri, 15 Jan 2016 10:57:14 +0000
In-Reply-To: <1452654971-4522-1-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2016-01-12 at 22:16 -0500, Konrad Rzeszutek Wilk wrote:
> commit 5d3dc8671521ea4a4f753e77d3e7fb3a3a6f5f80
> "tools: Refactor "xentoollog" into its own library"
> with older python versions (2.6.4) will fail to
> the build if attempted to be done twice (which
> happens due to pygrub dependencies).
> 
> make -C python DESTDIR=/tmp
> make -C python DESTDIR=/tmp
> 
> The second one will fail with:
> error: -Wl, -rpath-link=../../tools/libs/toollog: No such file or
> directory
> 
> even thought the directory is there (with the libs).

"though"

> 
> Andrew pointed out that the linker additions should be in
> the "extra_link_args" rather than "depends".
> 
> And true enough - with that modification it builds.
> 
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Suggested-by: Andrew Cooper <andrew.cooper3@citirx.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Acked + applied, with typo fixed.