From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org, Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH RFC] xen/Kconfig: Use olddefconfig not silentoldconfig to update .config
Date: Fri, 15 Jan 2016 15:07:39 +0000 [thread overview]
Message-ID: <1452870459.6020.29.camel@citrix.com> (raw)
In-Reply-To: <1452869335-28853-1-git-send-email-ian.campbell@citrix.com>
On Fri, 2016-01-15 at 14:48 +0000, Ian Campbell wrote:
> RFC RFC RFC RFC RFC RFC RFC RFC RFC RFC RFC
> BECAUSE THIS BREAKS CLEAN BUILDS WITH:
> In file included from <command-line>:0:0:
> /local/scratch/ianc/devel/arm/xen.git/xen/include/xen/config.h:10:32:
> fatal error: generated/autoconf.h: No such file or directory
> #include <generated/autoconf.h>
>
> I'm not sure why given the descriptions of olddefconfig and
> silentoldconfig below.
xen/tools/kconfig/Makefile holds the answer...
silentoldconfig: $(obj)/conf
$(Q)mkdir -p include/config include/generated
$< $(silent) --$@ $(Kconfig)
vs for olddefconfig (which is in $(simple-targets)):
$(simple-targets): $(obj)/conf
$< $(silent) --$@ $(Kconfig)
However the (seemingly) obvious answer of:
diff --git a/xen/Makefile b/xen/Makefile
index f8f3bb4..2422ba8 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -239,6 +239,7 @@ $(kconfig):
$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(XEN_TARGET_ARCH) $@
include/config/%.conf: include/config/auto.conf.cmd $(KCONFIG_CONFIG)
+ $(Q)mkdir -p include/config include/generated
$(Q)$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(XEN_TARGET_ARCH) olddefconfig
# Allow people to just run `make` as before and not force them to configure
Doesn't help, so I suppose there must be an actual semantic difference in
$(obj)/conf for these two options.
So I'm not sure what to do now.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-15 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 14:48 [PATCH RFC] xen/Kconfig: Use olddefconfig not silentoldconfig to update .config Ian Campbell
2016-01-15 15:07 ` Ian Campbell [this message]
2016-01-15 15:12 ` Ian Campbell
2016-01-15 15:44 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452870459.6020.29.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=cardoe@cardoe.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.