All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
	stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com
Subject: Re: [PATCH v3] xenstat: handle more than 1024 domains
Date: Fri, 15 Jan 2016 16:22:17 +0000	[thread overview]
Message-ID: <1452874937.6020.69.camel@citrix.com> (raw)
In-Reply-To: <1452874059-21099-1-git-send-email-jgross@suse.com>

On Fri, 2016-01-15 at 17:07 +0100, Juergen Gross wrote:
> get_domain_ids() in libxenstat used by read_attributes_qdisk() is
> limited to 1024 domains. Remove that limit.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> V3: Obey 80 character line length limit as requested by Ian Campbell.
>     In order to not have to wrap so many lines just carve out the loop
>     body into a sub-function.

That's a completely reasonable way to avoid excess wrapping (and should
probably be done more often!)

>  As this changes the patch structure, drop
>     the Reviewed-by tag of Wei.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

I took a look at the "git show -b" version, which was a lot easier to read:

Acked-by: Ian Campbell <ian.campbell@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-01-15 16:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 16:07 [PATCH v3] xenstat: handle more than 1024 domains Juergen Gross
2016-01-15 16:22 ` Ian Campbell [this message]
2016-01-19 11:33   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452874937.6020.69.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jgross@suse.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.