From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbcAQLhZ (ORCPT ); Sun, 17 Jan 2016 06:37:25 -0500 Received: from smtprelay0108.hostedemail.com ([216.40.44.108]:37573 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751149AbcAQLhX (ORCPT ); Sun, 17 Jan 2016 06:37:23 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:4321:4552:5007:6261:7904:7974:8957:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12296:12517:12519:12740:13069:13161:13163:13229:13255:13311:13357:13894:14659:21080:30022:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: shelf45_5d4c78d46c218 X-Filterd-Recvd-Size: 2105 Message-ID: <1453030640.3699.25.camel@perches.com> Subject: Re: [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue From: Joe Perches To: Tapan Prakash T , mdharm-usb@one-eyed-alien.net Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 17 Jan 2016 03:37:20 -0800 In-Reply-To: <1453024211-9774-1-git-send-email-tapanprakasht@gmail.com> References: <1453024211-9774-1-git-send-email-tapanprakasht@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-01-17 at 15:20 +0530, Tapan Prakash T wrote: > Fixed two coding style issue. Your email subject is not correct. This driver is not in staging and there's a trivial typo in parenthesis. > diff --git a/drivers/usb/storage/onetouch.c b/drivers/usb/storage/onetouch.c [] > @@ -69,7 +69,7 @@ struct usb_onetouch { >       vendorName, productName, useProtocol, useTransport, \ >       initFunction, flags) \ >  { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \ > -  .driver_info = (flags) } > +.driver_info = (flags) } A more typical style would have been to change the space to a tab before .driver_info >  static struct usb_device_id onetouch_usb_ids[] = { >  # include "unusual_onetouch.h" > @@ -125,7 +125,7 @@ static void usb_onetouch_irq(struct urb *urb) >   input_sync(dev); >   >  resubmit: > - retval = usb_submit_urb (urb, GFP_ATOMIC); > + retval = usb_submit_urb(urb, GFP_ATOMIC); >   if (retval) >   dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, " >   "retval %d\n", onetouch->udev->bus->bus_name, And to coalesce the format string dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, retval %d\n", onetouch->udev->bus->bus_name,