From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 1/5] libxl: tidy libxl_get_scheduler() according to CODING_STYLE Date: Tue, 19 Jan 2016 10:14:32 +0100 Message-ID: <1453194872.11427.113.camel@citrix.com> References: <1451982030.27063.30.camel@citrix.com> <1453183028-50263-1-git-send-email-czylin@uwaterloo.ca> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0280458042461821978==" Return-path: In-Reply-To: <1453183028-50263-1-git-send-email-czylin@uwaterloo.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chester Lin , xen-devel@lists.xen.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, jtotto@uwaterloo.ca, hjarmstr@uwaterloo.ca List-Id: xen-devel@lists.xenproject.org --===============0280458042461821978== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-SlFWsLTznvJEwnwp1T7F" --=-SlFWsLTznvJEwnwp1T7F Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-01-19 at 00:57 -0500, Chester Lin wrote: > To more closely follow the guidelines in CODING_STYLE, store the > result > of xc_sched_id() in the local variable r, and the check the result of > the call in a separate statement.=C2=A0=C2=A0Change the type of the outpu= t > parameter given to xc_sched_id() from libxl_scheduler to int to match > the libxc interface. >=20 > Additionally, change the error log statement to more accurately > reflect > the failure.=C2=A0=C2=A0This is the only functional change introduced by = this > patch. >=20 > Suggested-by: Ian Campbell > Signed-off-by: Chester Lin >=20 Reviewed-by: Dario Faggioli Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-SlFWsLTznvJEwnwp1T7F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlad/ngACgkQk4XaBE3IOsQ44QCeIHLg5MoBNTBiymu/xp1MoVba TpsAn1AaZt8R1zsnhcnJGXkDn114SUq/ =bGr7 -----END PGP SIGNATURE----- --=-SlFWsLTznvJEwnwp1T7F-- --===============0280458042461821978== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0280458042461821978==--