From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v6 2/5] build: Hook the schedulers into Kconfig Date: Tue, 19 Jan 2016 11:55:17 +0100 Message-ID: <1453200917.11427.124.camel@citrix.com> References: <1452877299-59267-1-git-send-email-jonathan.creekmore@gmail.com> <1452877299-59267-3-git-send-email-jonathan.creekmore@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7370266971277059421==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aLTwa-0002yl-Je for xen-devel@lists.xenproject.org; Tue, 19 Jan 2016 10:55:24 +0000 In-Reply-To: <1452877299-59267-3-git-send-email-jonathan.creekmore@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jonathan Creekmore , xen-devel@lists.xenproject.org Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org --===============7370266971277059421== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-XDHxUYblo8Q+ErXp7xhs" --=-XDHxUYblo8Q+ErXp7xhs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-01-15 at 11:01 -0600, Jonathan Creekmore wrote: > Allow the schedulers to be independently enabled or disabled at > compile-time. To match existing behavior, all four schedulers are > compiled in by default, although the Credit2, RTDS, and ARINC653 are > marked EXPERIMENTAL to match their not currently supported status. >=20 > CC: George Dunlap > CC: Dario Faggioli > Signed-off-by: Jonathan Creekmore > Reviewed-by: Doug Goldstein >=20 > --- >=C2=A0 > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index eadfc3b..7cc99c7 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig >=C2=A0 > diff --git a/xen/common/Makefile b/xen/common/Makefile > index 9f8b214..4df71ee 100644 > --- a/xen/common/Makefile > +++ b/xen/common/Makefile The above changes looks fine to me, but I really speak almost no Kconfig. :-/ On the rest of the patch, I only have one comment. > diff --git a/xen/common/schedule.c b/xen/common/schedule.c > index d121896..2f98a48 100644 > --- a/xen/common/schedule.c > +++ b/xen/common/schedule.c > @@ -65,10 +65,18 @@ DEFINE_PER_CPU(struct schedule_data, > schedule_data); > =C2=A0DEFINE_PER_CPU(struct scheduler *, scheduler); > =C2=A0 > =C2=A0static const struct scheduler *schedulers[] =3D { > +#ifdef CONFIG_SCHED_CREDIT > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&sched_credit_def, > +#endif > If I understood correctly, Credit is always going to be there, so I guess these #ifdef could go away? However, since this is just killed later, I don't think it should block the patch (series). So: Acked-by: Dario Faggioli Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-XDHxUYblo8Q+ErXp7xhs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlaeFhYACgkQk4XaBE3IOsRM0gCgmlgJC0ZXmp5T6fgjBUi5dsOR 5y8AnR7+YjzYxAuaK40lDHM7xqRX4+X8 =ni/b -----END PGP SIGNATURE----- --=-XDHxUYblo8Q+ErXp7xhs-- --===============7370266971277059421== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7370266971277059421==--