From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH LIBVIRT] libxl: Support cmdline= in xl config files Date: Tue, 19 Jan 2016 12:03:56 +0000 Message-ID: <1453205036.29930.24.camel@citrix.com> References: <1450267744-19273-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1450267744-19273-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: libvir-list@redhat.com, Jim Fehlig Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SSB3ZW50IHRvIHBpbmcgdGhpcyBidXQgbm90aWNlZCB0aGF0IEkgaGFkIHNlbnQgaXQgdG8gImpp bWZlaGxpZyIgKGkuZS4gbm8KZG9tYWluKSwgc28gbm8gd29uZGVyIHRoZXJlIHdhcyBubyByZXBs eSEKClRvOiBsaW5lIGZpeGVkIGhlcmUsIGxldCBtZSBrbm93IGlmIHlvdSB3b3VsZCBwcmVmZXIg YSByZXNlbmQuCgpJYW4uCgpPbiBXZWQsIDIwMTUtMTItMTYgYXQgMTI6MDkgKzAwMDAsIElhbiBD YW1wYmVsbCB3cm90ZToKPiAuLi4gYW5kIGNvbnNvbGlkYXRlIHRoZSBjbWRsaW5lL2V4dHJhL3Jv b3QgcGFyc2luZyB0byBmYWNpbGl0YXRlIGRvaW5nCj4gc28uCj4gCj4gVGhlIGxvZ2ljIGlzIHRo ZSBzYW1lIGFzIHhsJ3MgcGFyc2VfY21kbGluZSBmcm9tIHRoZSBjdXJyZW50IHhlbi5naXQgbWFz dGVyCj4gYnJhbmNoIChlNmYwZTA5OWQyYzE3ZGU0N2ZkODZlODE3YjE5OThkYjkwM2NhYjYxKSwg ZXhjZXB0IEkgd2FzIHVuYWJsZQo+IHRvIGZpZ3VyZSBvdXQgaG93L3doZXJlIHRvIHJvdXRlIHRo ZSB3YXJuaW5nIGFib3V0IGlnbm9yaW5nCj4gcm9vdCtleHRyYSBpZiBjbWRsaW5lIHdhcyBzcGVj aWZpZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWFuIENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0 cml4LmNvbT4KPiAtLS0KPiDCoHNyYy94ZW5jb25maWcveGVuX3hsLmMgfCA2MiArKysrKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAtLS0tLS0tLQo+IMKgMSBmaWxlIGNo YW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9zcmMveGVuY29uZmlnL3hlbl94bC5jIGIvc3JjL3hlbmNvbmZpZy94ZW5feGwuYwo+IGluZGV4 IDkxY2RmZjYuLmJhOGI5MzggMTAwNjQ0Cj4gLS0tIGEvc3JjL3hlbmNvbmZpZy94ZW5feGwuYwo+ ICsrKyBiL3NyYy94ZW5jb25maWcveGVuX3hsLmMKPiBAQCAtNTgsMTEgKzU4LDQ1IEBAIGV4dGVy biBpbnQgeGx1X2Rpc2tfcGFyc2UoWExVX0NvbmZpZyAqY2ZnLAo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGxpYnhsX2RldmljZV9kaXNrICpk aXNrKTsKPiDCoCNlbmRpZgo+IMKgCj4gK3N0YXRpYyBpbnQgeGVuUGFyc2VDbWRsaW5lKHZpckNv bmZQdHIgY29uZiwgY2hhciAqKnJfY21kbGluZSkKPiArewo+ICvCoMKgwqDCoGNoYXIgKmNtZGxp bmUgPSBOVUxMOwo+ICvCoMKgwqDCoGNvbnN0IGNoYXIgKnJvb3QgPSBOVUxMLCAqZXh0cmEgPSBO VUxMLCAqYnVmID0gTlVMTDsKPiArCj4gK8KgwqDCoMKgaWYgKHhlbkNvbmZpZ0dldFN0cmluZyhj b25mLCAiY21kbGluZSIsICZidWYsIE5VTEwpIDwgMCkKPiArwqDCoMKgwqDCoMKgwqDCoHJldHVy biAtMTsKPiArCj4gK8KgwqDCoMKgaWYgKHhlbkNvbmZpZ0dldFN0cmluZyhjb25mLCAicm9vdCIs ICZyb290LCBOVUxMKSA8IDApCj4gK8KgwqDCoMKgwqDCoMKgwqByZXR1cm4gLTE7Cj4gKwo+ICvC oMKgwqDCoGlmICh4ZW5Db25maWdHZXRTdHJpbmcoY29uZiwgImV4dHJhIiwgJmV4dHJhLCBOVUxM KSA8IDApCj4gK8KgwqDCoMKgwqDCoMKgwqByZXR1cm4gLTE7Cj4gKwo+ICvCoMKgwqDCoGlmIChi dWYpIHsKPiArwqDCoMKgwqDCoMKgwqDCoGlmIChWSVJfU1RSRFVQKGNtZGxpbmUsIGJ1ZikgPCAw KQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gLTE7Cj4gK8KgwqDCoMKgwqDCoMKg wqAvKiByb290IG9yIGV4dHJhIGFyZSBpZ25vcmVkIGluIHRoaXMgY2FzZS4gKi8KPiArwqDCoMKg wqB9IGVsc2Ugewo+ICvCoMKgwqDCoMKgwqDCoMKgaWYgKHJvb3QgJiYgZXh0cmEpIHsKPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgaWYgKHZpckFzcHJpbnRmKCZjbWRsaW5lLCAicm9vdD0lcyAl cyIsIHJvb3QsIGV4dHJhKSA8IDApCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg cmV0dXJuIC0xOwo+ICvCoMKgwqDCoMKgwqDCoMKgfSBlbHNlIGlmIChyb290KSB7Cj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoGlmICh2aXJBc3ByaW50ZigmY21kbGluZSwgInJvb3Q9JXMiLCBy b290KSA8IDApCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0dXJuIC0xOwo+ ICvCoMKgwqDCoMKgwqDCoMKgfSBlbHNlIGlmIChleHRyYSkgewo+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqBpZiAoVklSX1NUUkRVUChjbWRsaW5lLCBleHRyYSkgPCAwKQo+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAtMTsKPiArwqDCoMKgwqDCoMKgwqDCoH0KPiAr wqDCoMKgwqB9Cj4gKwo+ICvCoMKgwqDCoCpyX2NtZGxpbmUgPSBjbWRsaW5lOwo+ICvCoMKgwqDC oHJldHVybiAwOwo+ICt9Cj4gKwo+IMKgc3RhdGljIGludAo+IMKgeGVuUGFyc2VYTE9TKHZpckNv bmZQdHIgY29uZiwgdmlyRG9tYWluRGVmUHRyIGRlZiwgdmlyQ2Fwc1B0ciBjYXBzKQo+IMKgewo+ IMKgwqDCoMKgwqBzaXplX3QgaTsKPiAtwqDCoMKgwqBjb25zdCBjaGFyICpleHRyYSwgKnJvb3Q7 Cj4gwqAKPiDCoMKgwqDCoMKgaWYgKGRlZi0+b3MudHlwZSA9PSBWSVJfRE9NQUlOX09TVFlQRV9I Vk0pIHsKPiDCoMKgwqDCoMKgwqDCoMKgwqBjb25zdCBjaGFyICpib290Owo+IEBAIC04NCwxOSAr MTE4LDggQEAgeGVuUGFyc2VYTE9TKHZpckNvbmZQdHIgY29uZiwgdmlyRG9tYWluRGVmUHRyIGRl ZiwKPiB2aXJDYXBzUHRyIGNhcHMpCj4gwqDCoMKgwqDCoMKgwqDCoMKgaWYgKHhlbkNvbmZpZ0Nv cHlTdHJpbmdPcHQoY29uZiwgInJhbWRpc2siLCAmZGVmLT5vcy5pbml0cmQpIDwKPiAwKQo+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0dXJuIC0xOwo+IMKgCj4gLcKgwqDCoMKgwqDCoMKg wqBpZiAoeGVuQ29uZmlnR2V0U3RyaW5nKGNvbmYsICJleHRyYSIsICZleHRyYSwgTlVMTCkgPCAw KQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gLTE7Cj4gLQo+IC3CoMKgwqDCoMKg wqDCoMKgaWYgKHhlbkNvbmZpZ0dldFN0cmluZyhjb25mLCAicm9vdCIsICZyb290LCBOVUxMKSA8 IDApCj4gK8KgwqDCoMKgwqDCoMKgwqBpZiAoeGVuUGFyc2VDbWRsaW5lKGNvbmYsICZkZWYtPm9z LmNtZGxpbmUpIDwgMCkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAtMTsKPiAt Cj4gLcKgwqDCoMKgwqDCoMKgwqBpZiAocm9vdCkgewo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqBpZiAodmlyQXNwcmludGYoJmRlZi0+b3MuY21kbGluZSwgInJvb3Q9JXMgJXMiLCByb290LCBl eHRyYSkKPiA8IDApCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0dXJuIC0x Owo+IC3CoMKgwqDCoMKgwqDCoMKgfSBlbHNlIHsKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg aWYgKFZJUl9TVFJEVVAoZGVmLT5vcy5jbWRsaW5lLCBleHRyYSkgPCAwKQo+IC3CoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAtMTsKPiAtwqDCoMKgwqDCoMKgwqDCoH0KPiDC oCNlbmRpZgo+IMKgCj4gwqDCoMKgwqDCoMKgwqDCoMKgaWYgKHhlbkNvbmZpZ0dldFN0cmluZyhj b25mLCAiYm9vdCIsICZib290LCAiYyIpIDwgMCkKPiBAQCAtMTMyLDE5ICsxNTUsOCBAQCB4ZW5Q YXJzZVhMT1ModmlyQ29uZlB0ciBjb25mLCB2aXJEb21haW5EZWZQdHIgZGVmLAo+IHZpckNhcHNQ dHIgY2FwcykKPiDCoMKgwqDCoMKgwqDCoMKgwqBpZiAoeGVuQ29uZmlnQ29weVN0cmluZ09wdChj b25mLCAicmFtZGlzayIsICZkZWYtPm9zLmluaXRyZCkgPAo+IDApCj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqByZXR1cm4gLTE7Cj4gwqAKPiAtwqDCoMKgwqDCoMKgwqDCoGlmICh4ZW5Db25m aWdHZXRTdHJpbmcoY29uZiwgImV4dHJhIiwgJmV4dHJhLCBOVUxMKSA8IDApCj4gLcKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoHJldHVybiAtMTsKPiAtCj4gLcKgwqDCoMKgwqDCoMKgwqBpZiAoeGVu Q29uZmlnR2V0U3RyaW5nKGNvbmYsICJyb290IiwgJnJvb3QsIE5VTEwpIDwgMCkKPiArwqDCoMKg wqDCoMKgwqDCoGlmICh4ZW5QYXJzZUNtZGxpbmUoY29uZiwgJmRlZi0+b3MuY21kbGluZSkgPCAw KQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0dXJuIC0xOwo+IC0KPiAtwqDCoMKgwqDC oMKgwqDCoGlmIChyb290KSB7Cj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGlmICh2aXJBc3By aW50ZigmZGVmLT5vcy5jbWRsaW5lLCAicm9vdD0lcyAlcyIsIHJvb3QsIGV4dHJhKQo+IDwgMCkK PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gLTE7Cj4gLcKgwqDCoMKg wqDCoMKgwqB9IGVsc2Ugewo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBpZiAoVklSX1NUUkRV UChkZWYtPm9zLmNtZGxpbmUsIGV4dHJhKSA8IDApCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgcmV0dXJuIC0xOwo+IC3CoMKgwqDCoMKgwqDCoMKgfQo+IMKgwqDCoMKgwqB9Cj4g wqAKPiDCoMKgwqDCoMKgcmV0dXJuIDA7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==