From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse Date: Wed, 20 Jan 2016 11:23:43 +0200 Message-ID: <1453281823.2594.21.camel@gmail.com> References: <1453199833-10401-1-git-send-email-shubhangi.shrivastava@intel.com> <1453199833-10401-2-git-send-email-shubhangi.shrivastava@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA48E6E463 for ; Wed, 20 Jan 2016 01:23:47 -0800 (PST) Received: by mail-pf0-f195.google.com with SMTP id 65so144750pff.2 for ; Wed, 20 Jan 2016 01:23:47 -0800 (PST) In-Reply-To: <1453199833-10401-2-git-send-email-shubhangi.shrivastava@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shubhangi Shrivastava , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE2LTAxLTE5IGF0IDE2OjA3ICswNTMwLCBTaHViaGFuZ2kgU2hyaXZhc3RhdmEg d3JvdGU6Cj4gQ3VycmVudCBEUCBkZXRlY3Rpb24gaGFzIERQQ0Qgb3BlcmF0aW9ucyBzcGxpdCBh Y3Jvc3MKPiBpbnRlbF9kcF9ocGRfcHVsc2UgYW5kIGludGVsX2RwX2RldGVjdCB3aGljaCBjb250 YWlucwo+IGR1cGxpY2F0ZXMgYXMgd2VsbC4gQWxzbyBpbnRlbF9kcF9kZXRlY3QgaXMgY2FsbGVk Cj4gZHVyaW5nIG1vZGVzIGVudW1lcmF0aW9uIGFzIHdlbGwgd2hpY2ggd2lsbCByZXN1bHQKPiBp biBtdWx0aXBsZSBkcGNkIG9wZXJhdGlvbnMuIFNvIHRoaXMgcGF0Y2ggdHJpZXMKPiB0byBzb2x2 ZSBib3RoIHRoZXNlIGJ5IGJyaW5naW5nIGFsbCBEUENEIG9wZXJhdGlvbnMKPiBpbiBvbmUgc2lu Z2xlIGZ1bmN0aW9uIGFuZCBtYWtlIGludGVsX2RwX2RldGVjdAo+IHVzZSBleGlzdGluZyB2YWx1 ZXMgaW5zdGVhZCBvZiByZXBlYXRpbmcgc2FtZSBzdGVwcy4KPiAKPiB2MjogUHVsbGVkIGluIGEg aHVuayBmcm9tIGxhc3QgcGF0Y2ggb2YgdGhlIHNlcmllcyB0bwo+ICAgICB0aGlzIHBhdGNoLiAo QW5kZXIpCj4gdjM6IEFkZGVkIE1TVCBob3RwbHVnIGhhbmRsaW5nLiAoQW5kZXIpCgpQbGVhc2Ug cGljayB1cCBwcmV2aW91cyByZXZpZXcgdGFncyB3aGVuIHJlc2VuZGluZyBwYXRjaGVzLiBJbiB0 aGlzIGNhc2UsIHRoaXMKd2FzIGFscmVhZHkKClJldmlld2VkLWJ5OiBBbmRlciBDb25zZWx2YW4g ZGUgT2xpdmVpcmEgPGNvbnNlbHZhbjJAZ21haWwuY29tPgoKPiBUZXN0ZWQtYnk6IE5hdGhhbiBE IENpb2JhbnUgPG5hdGhhbi5kLmNpb2JhbnVAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFNp dmFrdW1hciBUaHVsYXNpbWFuaSA8c2l2YWt1bWFyLnRodWxhc2ltYW5pQGludGVsLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBTaHViaGFuZ2kgU2hyaXZhc3RhdmEgPHNodWJoYW5naS5zaHJpdmFzdGF2 YUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCA3 MSArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gLQo+ICAxIGZpbGUg Y2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgMjcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jCj4gaW5kZXggODk2OWZmOS4uODJlZTE4ZCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHAuYwo+IEBAIC00NjM4LDggKzQ2MzgsMTkgQEAgaW50ZWxfZHBfbG9uZ19wdWxzZShz dHJ1Y3QgaW50ZWxfY29ubmVjdG9yCj4gKmludGVsX2Nvbm5lY3RvcikKPiAgCWludGVsX2RwX3By b2JlX291aShpbnRlbF9kcCk7Cj4gIAo+ICAJcmV0ID0gaW50ZWxfZHBfcHJvYmVfbXN0KGludGVs X2RwKTsKPiAtCWlmIChyZXQpCj4gKwlpZiAocmV0KSB7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9IGVs c2UgaWYgKGNvbm5lY3Rvci0+c3RhdHVzID09IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkKSB7 Cj4gKwkJLyoKPiArCQkgKiBJZiBkaXNwbGF5IHdhcyBjb25uZWN0ZWQgYWxyZWFkeSBhbmQgaXMg c3RpbGwgY29ubmVjdGVkCj4gKwkJICogY2hlY2sgbGlua3Mgc3RhdHVzLCB0aGVyZSBoYXMgYmVl biBrbm93biBpc3N1ZXMgb2YKPiArCQkgKiBsaW5rIGxvc3MgdHJpZ2dlcnJpbmcgbG9uZyBwdWxz ZSEhISEKPiArCQkgKi8KPiArCQlkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNv bm5lY3Rpb25fbXV0ZXgsIE5VTEwpOwo+ICsJCWludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKGlu dGVsX2RwKTsKPiArCQlkcm1fbW9kZXNldF91bmxvY2soJmRldi0+bW9kZV9jb25maWcuY29ubmVj dGlvbl9tdXRleCk7Cj4gIAkJZ290byBvdXQ7Cj4gKwl9Cj4gIAo+ICAJLyoKPiAgCSAqIENsZWFy aW5nIE5BQ0sgYW5kIGRlZmVyIGNvdW50cyB0byBnZXQgdGhlaXIgZXhhY3QgdmFsdWVzCj4gQEAg LTQ2NjgsOCArNDY3OSwyMSBAQCBpbnRlbF9kcF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25u ZWN0b3IKPiAqaW50ZWxfY29ubmVjdG9yKQo+ICAJfQo+ICAKPiAgb3V0Ogo+IC0JaWYgKHN0YXR1 cyAhPSBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZCkKPiArCWlmIChzdGF0dXMgIT0gY29ubmVj dG9yX3N0YXR1c19jb25uZWN0ZWQpIHsKPiAgCQlpbnRlbF9kcF91bnNldF9lZGlkKGludGVsX2Rw KTsKPiArCQkvKgo+ICsJCSAqIElmIHdlIHdlcmUgaW4gTVNUIG1vZGUsIGFuZCBkZXZpY2UgaXMg bm90IHRoZXJlLAo+ICsJCSAqIGdldCBvdXQgb2YgTVNUIG1vZGUKPiArCQkgKi8KPiArCQlpZiAo aW50ZWxfZHAtPmlzX21zdCkgewo+ICsJCQlEUk1fREVCVUdfS01TKCJNU1QgZGV2aWNlIG1heSBo YXZlIGRpc2FwcGVhcmVkICVkIHZzCj4gJWRcbiIsCj4gKwkJCQlpbnRlbF9kcC0+aXNfbXN0LCBp bnRlbF9kcAo+IC0+bXN0X21nci5tc3Rfc3RhdGUpOwo+ICsJCQlpbnRlbF9kcC0+aXNfbXN0ID0g ZmFsc2U7Cj4gKwkJCWRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVsX2RwLT5t c3RfbWdyLAo+ICsJCQkJCQkJaW50ZWxfZHAtPmlzX21zdCk7Cj4gKwkJfQo+ICsJfQo+ICsKPiAg CWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KHRvX2k5MTUoZGV2KSwgcG93ZXJfZG9tYWluKTsKPiAg CXJldHVybjsKPiAgfQo+IEBAIC00NjkzLDcgKzQ3MTcsOCBAQCBpbnRlbF9kcF9kZXRlY3Qoc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwgYm9vbAo+IGZvcmNlKQo+ICAJCXJldHVybiBj b25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsKPiAgCX0KPiAgCj4gLQlpbnRlbF9kcF9sb25n X3B1bHNlKGludGVsX2RwLT5hdHRhY2hlZF9jb25uZWN0b3IpOwo+ICsJaWYgKGZvcmNlKQo+ICsJ CWludGVsX2RwX2xvbmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rvcik7Cj4gIAo+ ICAJaWYgKGludGVsX2Nvbm5lY3Rvci0+ZGV0ZWN0X2VkaWQpCj4gIAkJcmV0dXJuIGNvbm5lY3Rv cl9zdGF0dXNfY29ubmVjdGVkOwo+IEBAIC01MDI2LDI1ICs1MDUxLDI1IEBAIGludGVsX2RwX2hw ZF9wdWxzZShzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0Cj4gKmludGVsX2RpZ19wb3J0LCBib29s IGxvbmdfaHBkKQo+ICAJCS8qIGluZGljYXRlIHRoYXQgd2UgbmVlZCB0byByZXN0YXJ0IGxpbmsg dHJhaW5pbmcgKi8KPiAgCQlpbnRlbF9kcC0+dHJhaW5fc2V0X3ZhbGlkID0gZmFsc2U7Cj4gIAo+ IC0JCWlmICghaW50ZWxfZGlnaXRhbF9wb3J0X2Nvbm5lY3RlZChkZXZfcHJpdiwgaW50ZWxfZGln X3BvcnQpKQo+IC0JCQlnb3RvIG1zdF9mYWlsOwo+IC0KPiAtCQlpZiAoIWludGVsX2RwX2dldF9k cGNkKGludGVsX2RwKSkgewo+IC0JCQlnb3RvIG1zdF9mYWlsOwo+IC0JCX0KPiAtCj4gLQkJaW50 ZWxfZHBfcHJvYmVfb3VpKGludGVsX2RwKTsKPiArCQlpbnRlbF9kcF9sb25nX3B1bHNlKGludGVs X2RwLT5hdHRhY2hlZF9jb25uZWN0b3IpOwo+ICsJCWlmIChpbnRlbF9kcC0+aXNfbXN0KQo+ICsJ CQlyZXQgPSBJUlFfSEFORExFRDsKPiArCQlnb3RvIHB1dF9wb3dlcjsKPiAgCj4gLQkJaWYgKCFp bnRlbF9kcF9wcm9iZV9tc3QoaW50ZWxfZHApKSB7Cj4gLQkJCWRybV9tb2Rlc2V0X2xvY2soJmRl di0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCwKPiBOVUxMKTsKPiAtCQkJaW50ZWxfZHBf Y2hlY2tfbGlua19zdGF0dXMoaW50ZWxfZHApOwo+IC0JCQlkcm1fbW9kZXNldF91bmxvY2soJmRl dgo+IC0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCk7Cj4gLQkJCWdvdG8gbXN0X2ZhaWw7 Cj4gLQkJfQo+ICAJfSBlbHNlIHsKPiAgCQlpZiAoaW50ZWxfZHAtPmlzX21zdCkgewo+IC0JCQlp ZiAoaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhpbnRlbF9kcCkgPT0gLUVJTlZBTCkKPiAtCQkJ CWdvdG8gbXN0X2ZhaWw7Cj4gKwkJCWlmIChpbnRlbF9kcF9jaGVja19tc3Rfc3RhdHVzKGludGVs X2RwKSA9PSAtRUlOVkFMKSB7Cj4gKwkJCQkvKgo+ICsJCQkJICogSWYgd2Ugd2VyZSBpbiBNU1Qg bW9kZSwgYW5kIGRldmljZSBpcyBub3QKPiArCQkJCSAqIHRoZXJlLCBnZXQgb3V0IG9mIE1TVCBt b2RlCj4gKwkJCQkgKi8KPiArCQkJCURSTV9ERUJVR19LTVMoIk1TVCBkZXZpY2UgbWF5IGhhdmUK PiBkaXNhcHBlYXJlZCAlZCB2cyAlZFxuIiwKPiArCQkJCQlpbnRlbF9kcC0+aXNfbXN0LCBpbnRl bF9kcAo+IC0+bXN0X21nci5tc3Rfc3RhdGUpOwo+ICsJCQkJaW50ZWxfZHAtPmlzX21zdCA9IGZh bHNlOwo+ICsJCQkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAKPiAt Pm1zdF9tZ3IsCj4gKwkJCQkJCQkJaW50ZWxfZHAKPiAtPmlzX21zdCk7Cj4gKwkJCQlnb3RvIHB1 dF9wb3dlcjsKPiArCQkJfQo+ICAJCX0KPiAgCj4gIAkJaWYgKCFpbnRlbF9kcC0+aXNfbXN0KSB7 Cj4gQEAgLTUwNTYsMTQgKzUwODEsNiBAQCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydAo+ICppbnRlbF9kaWdfcG9ydCwgYm9vbCBsb25nX2hwZCkKPiAgCj4gIAly ZXQgPSBJUlFfSEFORExFRDsKPiAgCj4gLQlnb3RvIHB1dF9wb3dlcjsKPiAtbXN0X2ZhaWw6Cj4g LQkvKiBpZiB3ZSB3ZXJlIGluIE1TVCBtb2RlLCBhbmQgZGV2aWNlIGlzIG5vdCB0aGVyZSBnZXQg b3V0IG9mIE1TVAo+IG1vZGUgKi8KPiAtCWlmIChpbnRlbF9kcC0+aXNfbXN0KSB7Cj4gLQkJRFJN X0RFQlVHX0tNUygiTVNUIGRldmljZSBtYXkgaGF2ZSBkaXNhcHBlYXJlZCAlZCB2cyAlZFxuIiwK PiBpbnRlbF9kcC0+aXNfbXN0LCBpbnRlbF9kcC0+bXN0X21nci5tc3Rfc3RhdGUpOwo+IC0JCWlu dGVsX2RwLT5pc19tc3QgPSBmYWxzZTsKPiAtCQlkcm1fZHBfbXN0X3RvcG9sb2d5X21ncl9zZXRf bXN0KCZpbnRlbF9kcC0+bXN0X21nciwgaW50ZWxfZHAKPiAtPmlzX21zdCk7Cj4gLQl9Cj4gIHB1 dF9wb3dlcjoKPiAgCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBwb3dlcl9kb21h aW4pOwo+ICAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK