From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Wed, 20 Jan 2016 15:36:03 -0800 Subject: [Intel-wired-lan] [PATCH] net: i40e: avoid unused function warnings In-Reply-To: <6894276.2dlRmisKUo@wuerfel> References: <2806620.EpZqDlZTO3@wuerfel> <8814508.SjLecHrQqA@wuerfel> <1453329885.2958.32.camel@intel.com> <6894276.2dlRmisKUo@wuerfel> Message-ID: <1453332963.2958.39.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wed, 2016-01-20 at 23:54 +0100, Arnd Bergmann wrote: > On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote: > > Yeah, I have a fix for that as well. > >? > > You can confirm by pulling my next-queue tree (dev-queue branch). > > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next- > queue.git d > > ev-queue > >? > > I checked out that branch, but still see both warnings in that one, > plus > a new build error in igb, which I don't see in linux-next: > > drivers/net/ethernet/intel/igb/igb_cdev.c: In function 'igb_mapring': > drivers/net/ethernet/intel/igb/igb_cdev.c:150:2: error: implicit > declaration of function 'set_pages_uc' [-Werror=implicit-function- > declaration] > ? set_pages_uc(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT); > ? ^ > drivers/net/ethernet/intel/igb/igb_cdev.c: In function > 'igb_unmapring': > drivers/net/ethernet/intel/igb/igb_cdev.c:275:2: error: implicit > declaration of function 'set_pages_wb' [-Werror=implicit-function- > declaration] > ? set_pages_wb(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT); Oops, I just realized I had not pushed my latest tree to kernel.org. The igb issue still remains, I am working with the developer who introduced the issue. ?Looks like the i40e issue about possible uninitialized variables still exists. ?I thought we had resolved that issue, but apparently not. You should see Eric Dumazet's patch on the tree to resolve the other i40e build warnings. I can add your second patch to resolve the uninitialized variables to my tree. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffrey.t.kirsher@intel.com (Jeff Kirsher) Date: Wed, 20 Jan 2016 15:36:03 -0800 Subject: [PATCH] net: i40e: avoid unused function warnings In-Reply-To: <6894276.2dlRmisKUo@wuerfel> References: <2806620.EpZqDlZTO3@wuerfel> <8814508.SjLecHrQqA@wuerfel> <1453329885.2958.32.camel@intel.com> <6894276.2dlRmisKUo@wuerfel> Message-ID: <1453332963.2958.39.camel@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2016-01-20 at 23:54 +0100, Arnd Bergmann wrote: > On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote: > > Yeah, I have a fix for that as well. > >? > > You can confirm by pulling my next-queue tree (dev-queue branch). > > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next- > queue.git d > > ev-queue > >? > > I checked out that branch, but still see both warnings in that one, > plus > a new build error in igb, which I don't see in linux-next: > > drivers/net/ethernet/intel/igb/igb_cdev.c: In function 'igb_mapring': > drivers/net/ethernet/intel/igb/igb_cdev.c:150:2: error: implicit > declaration of function 'set_pages_uc' [-Werror=implicit-function- > declaration] > ? set_pages_uc(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT); > ? ^ > drivers/net/ethernet/intel/igb/igb_cdev.c: In function > 'igb_unmapring': > drivers/net/ethernet/intel/igb/igb_cdev.c:275:2: error: implicit > declaration of function 'set_pages_wb' [-Werror=implicit-function- > declaration] > ? set_pages_wb(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT); Oops, I just realized I had not pushed my latest tree to kernel.org. The igb issue still remains, I am working with the developer who introduced the issue. ?Looks like the i40e issue about possible uninitialized variables still exists. ?I thought we had resolved that issue, but apparently not. You should see Eric Dumazet's patch on the tree to resolve the other i40e build warnings. I can add your second patch to resolve the uninitialized variables to my tree. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934687AbcATXgK (ORCPT ); Wed, 20 Jan 2016 18:36:10 -0500 Received: from mga03.intel.com ([134.134.136.65]:30492 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbcATXgF (ORCPT ); Wed, 20 Jan 2016 18:36:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,322,1449561600"; d="asc'?scan'208";a="865032863" Message-ID: <1453332963.2958.39.camel@intel.com> Subject: Re: [PATCH] net: i40e: avoid unused function warnings From: Jeff Kirsher To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Shannon Nelson , netdev@vger.kernel.org, Mitch Williams , Bruce Allan , Jesse Brandeburg , linux-kernel@vger.kernel.org, John Ronciak , intel-wired-lan@lists.osuosl.org, Don Skidmore , Carolyn Wyborny , davem@davemloft.net Date: Wed, 20 Jan 2016 15:36:03 -0800 In-Reply-To: <6894276.2dlRmisKUo@wuerfel> References: <2806620.EpZqDlZTO3@wuerfel> <8814508.SjLecHrQqA@wuerfel> <1453329885.2958.32.camel@intel.com> <6894276.2dlRmisKUo@wuerfel> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-YYSWXs7SlrtGA43Hsfl4" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-YYSWXs7SlrtGA43Hsfl4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-01-20 at 23:54 +0100, Arnd Bergmann wrote: > On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote: > > Yeah, I have a fix for that as well. > >=C2=A0 > > You can confirm by pulling my next-queue tree (dev-queue branch). > > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next- > queue.git d > > ev-queue > >=C2=A0 >=20 > I checked out that branch, but still see both warnings in that one, > plus > a new build error in igb, which I don't see in linux-next: >=20 > drivers/net/ethernet/intel/igb/igb_cdev.c: In function 'igb_mapring': > drivers/net/ethernet/intel/igb/igb_cdev.c:150:2: error: implicit > declaration of function 'set_pages_uc' [-Werror=3Dimplicit-function- > declaration] > =C2=A0 set_pages_uc(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT); > =C2=A0 ^ > drivers/net/ethernet/intel/igb/igb_cdev.c: In function > 'igb_unmapring': > drivers/net/ethernet/intel/igb/igb_cdev.c:275:2: error: implicit > declaration of function 'set_pages_wb' [-Werror=3Dimplicit-function- > declaration] > =C2=A0 set_pages_wb(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT); Oops, I just realized I had not pushed my latest tree to kernel.org. The igb issue still remains, I am working with the developer who introduced the issue. =C2=A0Looks like the i40e issue about possible uninitialized variables still exists. =C2=A0I thought we had resolved that issue, but apparently not. You should see Eric Dumazet's patch on the tree to resolve the other i40e build warnings. I can add your second patch to resolve the uninitialized variables to my tree. --=-YYSWXs7SlrtGA43Hsfl4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABCgAGBQJWoBnjAAoJEOVv75VaS+3OOrgQAIyHEk7JvQl2MUVayyhru5Zj JjOZ+iPn2VWqJyIfBIwDrVyk3CkDSCcJzcY+OsT5AcbQAtgd/HmK/ekrCl/nZJ3E iKg2b+rRfqyT1SnX9foftv/H2sN1G6Bj2u03LKs2HUmeCPonaNfE7SNICQtQXRVz 7xEJJeFMNMTO4lCiHkqxdzVM+bpxGRL+C0Lww+knJzrTCIX1O0W1b51zGKbI89SO JVFxNZoYu4nwGcdGvJyG8MXLinKurM/X2b89PtAYjJLv4RIl+fCENMgzSbYjms08 QxTpaV8Y6Ze7+kdMHJbi/P9oor0n3k1JYsmjaaP9EPTaJnWVjAW0E9H6klqdgSfZ hGf6s0r66eDbeyehWJjx775AAYk6JbOw32GELATbdV3DY/np9qY953JnnlCl4WJ/ oDnqihnD9AnFhp7eDGgAIigXCnkICGGzR2SMghXwrzSpkeP0/irFm8NsB1+JJtdo ElPOXMo1DGpEGeGa0msSuYvc+6qna8zKrFz08/lCPve/xJxTK5mbXvyM9RyvOTxY nkdcOJQZAi6UwT6D4av+Gur8xnnAz2HYnQVWhbhq+d5CjeF2I/HNiKkt1mpiQiO6 UjoYwmD+RzXdX9SJFXZCOtlTXhzr16+WJtspS5cTQfOtNOi5eNhwHzVSy4+ovfXo FSoB1msU4U+MTYk+srI2 =JrvJ -----END PGP SIGNATURE----- --=-YYSWXs7SlrtGA43Hsfl4--