From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit Date: Thu, 21 Jan 2016 13:52:09 +0200 Message-ID: <1453377129.19574.1.camel@linux.intel.com> References: <1450519123-28206-1-git-send-email-chris@chris-wilson.co.uk> <1452790243.27879.37.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 73B0A890A8 for ; Thu, 21 Jan 2016 03:51:01 -0800 (PST) In-Reply-To: <1452790243.27879.37.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com, Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTYtMDEtMTQgYXQgMTg6NTAgKzAyMDAsIEltcmUgRGVhayB3cm90ZToKPiBPbiBs YSwgMjAxNS0xMi0xOSBhdCAwOTo1OCArMDAwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+ID4gT25j ZSBhbGwgdGhlIHByZXBhcmF0aW9ucyBhcmUgY29tcGxldGUsIHdlIGFyZSByZWFkeSB0byB3cml0 ZSB0aGUKPiA+IG1vZGVzZXR0aW5nIHRvIHRoZSBoYXJkd2FyZS4gRHVyaW5nIHRoaXMgcGhhc2Us IHdlIHdpbGwgYmUgbWFraW5nCj4gPiBsb3RzCj4gPiBvZiBIVyByZWdpc3RlciBhY2Nlc3MsIHNv IHRha2UgYSB0b3AgbGV2ZWwgd2FrZXJlZiB0byBwcmV2ZW50IGFuCj4gPiB1bndhcnJhbnRlZCBy cG0gc3VzcGVuZCBjeWNsZSBtaWQtY29tbWl0LiBMb3dlciBsZXZlbCBmdW5jdGlvbnMKPiA+IHNo b3VsZAo+ID4gYmUgd2FraW5nIHRoZSBpbmRpdmlkdWFsIHBvd2VyIHdlbGxzIGFzIHJlcXVpcmVk Lgo+ID4gCj4gPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTM0MzkKPiAKPiBJIHdvdWxkIHNlcGFyYXRlIGhlcmUgdHdvIHRoaW5nczoKPiAK PiBUaGUgZGV2aWNlIGxldmVsIHBvd2VyIGZsaXAtZmxvcHBpbmcgeW91IG1lbnRpb24gYW5kIHRo ZSBmaXggZm9yIHRoZQo+IGFib3ZlIGJ1Zy4gRm9yIHRoZSBmbGlwLWZsb3BwaW5nIHdlIGNvdWxk IHVzZSB3aGF0IHlvdSBzdWdnZXN0LAo+IHBlcmhhcHMKPiBieSBhbHNvIGF2b2lkaW5nIHdha2lu ZyB1cCB0aGUgZGV2aWNlIGlmIG5vdGhpbmcgd2lsbCBjaGFuZ2UgYW5kCj4gZXZlcnl0aGluZyB3 aWxsIHN0YXkgZGlzYWJsZWQuCj4gCj4gQXMgZm9yIHRoZSBmaXggSSB3b3VsZCBnbyB3aXRoIHdo YXQgVmlsbGUgc3VnZ2VzdGVkLiBCeSBlbnN1cmluZyB3ZQo+IGtlZXAgYW4gUlBNIHJlZmVyZW5j ZSB3ZSBzdGlsbCBhbGxvdyBmb3IgYSBkaXNwbGF5IHBvd2VyIGRvbWFpbgo+IHJlZmVyZW5jZSB0 byBjb21lIGFuZCBnbyBpbiB0aGUgbWlkZGxlIG9mIHRoZSBIVyByZWFkb3V0LiBJIHdlbnQKPiBh aGVhZAo+IGFuZCB0cmllZCB0aGUgZm9sbG93aW5nIHdoaWNoIGdvdCByaWQgb2YgdGhlIHByb2Js ZW0gdG9vLCBpZiBwZW9wbGUKPiBhcmUKPiBvayB3aXRoIGl0IEkgY291bGQgY29udmVydCB0aGUg cmVzdCBvZiB0aGUgSFcgcmVhZG91dCBwbGFjZXMKPiBhY2NvcmRpbmdseSBhbmQgc2VuZCBvdXQg dGhlIHBhdGNoLiBXZSBjYW4gYWxzbwo+IGdldMKgcG1fcnVudGltZV9nZXRfaWZfaW5fdXNlKCkg aW50byB1c2Ugb25jZSBpdCdzIGFkZGVkLCBidXQgaXQnc8KgCj4gbm90IGNydWNpYWwgZm9yIHRo ZSBmaXguCj4gCgpCZWxvdyBwYXRjaCBsb29rcyBmaW5lLiBKdXN0IHRoYXQgSSdkIHVzZSBzL2lm X2VuYWJsZWQvaWZfaW5fdXNlLyB0bwptYXRjaCB0aGUgUE0gQVBJIGJldHRlci4gV2UncmUgYWxy ZWFkeSBkb2luZyB0b28gbXVjaCBvZiBhIGdvb2Qgam9iIHRvCmhhdmluZyBtYW55IG5hbWVzIGZv ciBzYW1lIHRoaW5nLgoKUmVnYXJkcywgSm9vbmFzCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRp LmMKPiBpbmRleCAxZjlhMzY4Li45MDczNzdkYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rk aS5jCj4gQEAgLTE5MTAsMTMgKzE5MTAsMTYgQEAgYm9vbCBpbnRlbF9kZGlfY29ubmVjdG9yX2dl dF9od19zdGF0ZShzdHJ1Y3QKPiBpbnRlbF9jb25uZWN0b3IgKmludGVsX2Nvbm5lY3RvcikKPiDC oAllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXI7Cj4gwqAJZW51bSBpbnRlbF9kaXNwbGF5 X3Bvd2VyX2RvbWFpbiBwb3dlcl9kb21haW47Cj4gwqAJdWludDMyX3QgdG1wOwo+ICsJYm9vbCBy ZXQ7Cj4gwqAKPiDCoAlwb3dlcl9kb21haW4gPQo+IGludGVsX2Rpc3BsYXlfcG9ydF9wb3dlcl9k b21haW4oaW50ZWxfZW5jb2Rlcik7Cj4gLQlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJfaXNfZW5h YmxlZChkZXZfcHJpdiwgcG93ZXJfZG9tYWluKSkKPiArCWlmICghaW50ZWxfZGlzcGxheV9wb3dl cl9nZXRfaWZfZW5hYmxlZChkZXZfcHJpdiwKPiBwb3dlcl9kb21haW4pKQo+IMKgCQlyZXR1cm4g ZmFsc2U7Cj4gwqAKPiAtCWlmICghaW50ZWxfZW5jb2Rlci0+Z2V0X2h3X3N0YXRlKGludGVsX2Vu Y29kZXIsICZwaXBlKSkKPiAtCQlyZXR1cm4gZmFsc2U7Cj4gKwlpZiAoIWludGVsX2VuY29kZXIt PmdldF9od19zdGF0ZShpbnRlbF9lbmNvZGVyLCAmcGlwZSkpIHsKPiArCQlyZXQgPSBmYWxzZTsK PiArCQlnb3RvIG91dDsKPiArCX0KPiDCoAo+IMKgCWlmIChwb3J0ID09IFBPUlRfQSkKPiDCoAkJ Y3B1X3RyYW5zY29kZXIgPSBUUkFOU0NPREVSX0VEUDsKPiBAQCAtMTkyOCwyMyArMTkzMSwzMCBA QCBib29sIGludGVsX2RkaV9jb25uZWN0b3JfZ2V0X2h3X3N0YXRlKHN0cnVjdAo+IGludGVsX2Nv bm5lY3RvciAqaW50ZWxfY29ubmVjdG9yKQo+IMKgCXN3aXRjaCAodG1wICYgVFJBTlNfRERJX01P REVfU0VMRUNUX01BU0spIHsKPiDCoAljYXNlIFRSQU5TX0RESV9NT0RFX1NFTEVDVF9IRE1JOgo+ IMKgCWNhc2UgVFJBTlNfRERJX01PREVfU0VMRUNUX0RWSToKPiAtCQlyZXR1cm4gKHR5cGUgPT0g RFJNX01PREVfQ09OTkVDVE9SX0hETUlBKTsKPiArCQlyZXQgPSB0eXBlID09IERSTV9NT0RFX0NP Tk5FQ1RPUl9IRE1JQTsKPiArCQlnb3RvIG91dDsKPiDCoAo+IMKgCWNhc2UgVFJBTlNfRERJX01P REVfU0VMRUNUX0RQX1NTVDoKPiAtCQlpZiAodHlwZSA9PSBEUk1fTU9ERV9DT05ORUNUT1JfZURQ KQo+IC0JCQlyZXR1cm4gdHJ1ZTsKPiAtCQlyZXR1cm4gKHR5cGUgPT0gRFJNX01PREVfQ09OTkVD VE9SX0Rpc3BsYXlQb3J0KTsKPiArCQlyZXQgPSB0eXBlID09IERSTV9NT0RFX0NPTk5FQ1RPUl9l RFAgfHwKPiArCQnCoMKgwqDCoMKgwqB0eXBlID09IERSTV9NT0RFX0NPTk5FQ1RPUl9EaXNwbGF5 UG9ydDsKPiArCQlnb3RvIG91dDsKPiDCoAljYXNlIFRSQU5TX0RESV9NT0RFX1NFTEVDVF9EUF9N U1Q6Cj4gwqAJCS8qIGlmIHRoZSB0cmFuc2NvZGVyIGlzIGluIE1TVCBzdGF0ZSB0aGVuCj4gwqAJ CcKgKiBjb25uZWN0b3IgaXNuJ3QgY29ubmVjdGVkICovCj4gLQkJcmV0dXJuIGZhbHNlOwo+ICsJ CXJldCA9IGZhbHNlOwo+ICsJCWdvdG8gb3V0Owo+IMKgCj4gwqAJY2FzZSBUUkFOU19ERElfTU9E RV9TRUxFQ1RfRkRJOgo+IC0JCXJldHVybiAodHlwZSA9PSBEUk1fTU9ERV9DT05ORUNUT1JfVkdB KTsKPiArCQlyZXQgPSB0eXBlID09IERSTV9NT0RFX0NPTk5FQ1RPUl9WR0E7Cj4gKwkJZ290byBv dXQ7Cj4gwqAKPiDCoAlkZWZhdWx0Ogo+IC0JCXJldHVybiBmYWxzZTsKPiArCQlyZXQgPSBmYWxz ZTsKPiDCoAl9Cj4gK291dDoKPiArCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBw b3dlcl9kb21haW4pOwo+ICsKPiArCXJldHVybiByZXQ7Cj4gwqB9Cj4gwqAKPiDCoGJvb2wgaW50 ZWxfZGRpX2dldF9od19zdGF0ZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXggMDU5YjQ2ZS4uM2M4NDE1OSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTE0NTYsNiArMTQ1Niw4IEBAIGJvb2wgX19pbnRl bF9kaXNwbGF5X3Bvd2VyX2lzX2VuYWJsZWQoc3RydWN0Cj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gwqAJCQkJwqDCoMKgwqDCoMKgZW51bQo+IGludGVsX2Rpc3BsYXlfcG93ZXJfZG9t YWluIGRvbWFpbik7Cj4gwqB2b2lkIGludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiDCoAkJCcKgwqDCoMKgwqBlbnVtIGludGVsX2Rpc3Bs YXlfcG93ZXJfZG9tYWluCj4gZG9tYWluKTsKPiArYm9vbCBpbnRlbF9kaXNwbGF5X3Bvd2VyX2dl dF9pZl9lbmFibGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gKmRldl9wcml2LAo+ICsJCQkJ CWVudW0KPiBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbiBkb21haW4pOwo+IMKgdm9pZCBpbnRl bF9kaXNwbGF5X3Bvd2VyX3B1dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g wqAJCQnCoMKgwqDCoMKgZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbgo+IGRvbWFpbik7 Cj4gwqAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9w bS5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBpbmRleCBi YmNhNTI3Li42YzRmMTcwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3J1bnRpbWVfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVf cG0uYwo+IEBAIC0xNDcwLDYgKzE0NzAsMTcgQEAgdm9pZCBpbnRlbF9kaXNwbGF5X3Bvd2VyX2dl dChzdHJ1Y3QKPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiDCoAltdXRleF91bmxvY2so JnBvd2VyX2RvbWFpbnMtPmxvY2spOwo+IMKgfQo+IMKgCj4gK2Jvb2wgaW50ZWxfZGlzcGxheV9w b3dlcl9nZXRfaWZfZW5hYmxlZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ICpkZXZfcHJpdiwK PiArCQkJCQllbnVtCj4gaW50ZWxfZGlzcGxheV9wb3dlcl9kb21haW4gZG9tYWluKQo+ICt7Cj4g KwlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJfaXNfZW5hYmxlZChkZXZfcHJpdiwgZG9tYWluKSkK PiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICsJaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3By aXYsIGRvbWFpbik7Cj4gKwo+ICsJcmV0dXJuIHRydWU7Cj4gK30KPiArCj4gwqAvKioKPiDCoCAq IGludGVsX2Rpc3BsYXlfcG93ZXJfcHV0IC0gcmVsZWFzZSBhIHBvd2VyIGRvbWFpbiByZWZlcmVu Y2UKPiDCoCAqIEBkZXZfcHJpdjogaTkxNSBkZXZpY2UgaW5zdGFuY2UKPiAKPiAtLUltcmUKPiAK PiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+ID4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gwqBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA5ICsrKysrKysrKwo+ID4gwqAx IGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCBhYmQyZDI5NDQwMjIuLjYwNDUxYzM5MzJkYiAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMTM0NzAs NiArMTM0NzAsMTMgQEAgc3RhdGljIGludCBpbnRlbF9hdG9taWNfY29tbWl0KHN0cnVjdAo+ID4g ZHJtX2RldmljZSAqZGV2LAo+ID4gwqAJZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShkZXYs IHN0YXRlKTsKPiA+IMKgCWRldl9wcml2LT53bS5jb25maWcgPSB0b19pbnRlbF9hdG9taWNfc3Rh dGUoc3RhdGUpLQo+ID4gPiB3bV9jb25maWc7Cj4gPiDCoAo+ID4gKwkvKiBUYWtlIGEgcnBtIHdh a2VyZWYgZm9yIHRoZSBkdXJhdGlvbiBvZiB0aGUgY29tbWl0Lgo+ID4gTG93ZXIKPiA+IGxldmVs Cj4gPiArCcKgKiBmdW5jdGlvbnMgc2hvdWxkIGJlIGFjcXVpcmluZyB0aGUgcG93ZXIgd2VsbHMg Zm9yIHRoZWlyCj4gPiBvd24gdXNlLAo+ID4gKwnCoCogd2UgdGFrZSB0aGlzIHRvcGxldmVsIHJl ZmVyZW5jZSB0byBwcmV2ZW50IHJwbSBzdXNwZW5kCj4gPiBjeWNsZXMKPiA+ICsJwqAqIG1pZC1j b21taXQuCj4gPiArCcKgKi8KPiA+ICsJaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+ ID4gKwo+ID4gwqAJZm9yX2VhY2hfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0 ZSwgaSkgewo+ID4gwqAJCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0KPiA+IHRvX2lu dGVsX2NydGMoY3J0Yyk7Cj4gPiDCoAo+ID4gQEAgLTEzNTU4LDYgKzEzNTY1LDggQEAgc3RhdGlj IGludCBpbnRlbF9hdG9taWNfY29tbWl0KHN0cnVjdAo+ID4gZHJtX2RldmljZSAqZGV2LAo+ID4g wqAJaWYgKGFueV9tcykKPiA+IMKgCQlpbnRlbF9tb2Rlc2V0X2NoZWNrX3N0YXRlKGRldiwgc3Rh dGUpOwo+ID4gwqAKPiA+ICsJaW50ZWxfcnVudGltZV9wbV9wdXQoZGV2X3ByaXYpOwo+ID4gKwo+ ID4gwqAJZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRlKTsKPiA+IMKgCj4gPiDCoAlyZXR1cm4g MDsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK