From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Koen Kooi <koen.kooi@linaro.org>,
Robert Yang <liezhi.yang@windriver.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] e2fsprogs: disable libblkid again
Date: Thu, 21 Jan 2016 21:53:57 +0000 [thread overview]
Message-ID: <1453413237.27999.172.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAP0W-R=Nqx=eqhvXD6Ex=RB8NxiPZcpwWqSMA+RvT1W3CMct2g@mail.gmail.com>
On Thu, 2016-01-21 at 08:44 +0100, Koen Kooi wrote:
> On 21 January 2016 at 08:42, Robert Yang <liezhi.yang@windriver.com>
> wrote:
> >
> >
> > On 01/21/2016 03:20 PM, Koen Kooi wrote:
> > >
> > > We use the util-linux one and do_install deletes it anyway.
> > >
> > > See OE-core commit fb8e776ea91c39d586b46400ad30aeea8dead1c4 for
> > > more info.
> > >
> > > Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> > > ---
> > > meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> > > b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> > > index c82e99a..f244473 100644
> > > --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> > > +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> > > @@ -14,7 +14,7 @@ UPSTREAM_CHECK_GITTAGREGEX =
> > > "v(?P<pver>\d+\.\d+(\.\d+)*)$"
> > >
> > > EXTRA_OECONF += "--libdir=${base_libdir} -
> > > -sbindir=${base_sbindir} \
> > > --enable-elf-shlibs --disable-libuuid --disable
> > > -uuidd \
> > > - --enable-libblkid --enable-verbose-makecmds"
> > > + --disable-libblkid --enable-verbose-makecmds"
> >
> >
> > Thanks, maybe we also need cleanup other codes like:
> >
> > # We use blkid from util-linux now so remove from here
> > rm -f ${D}${base_libdir}/libblkid*
>
> That one should stay in, because we *really* don't want it to end up
> in packages.
>
> >
> > And:
> >
> > ALTERNATIVE_${PN}-doc = "libblkid.3 blkid.8"
> > ALTERNATIVE_LINK_NAME[libblkid.3] = "${mandir}/man3/libblkid.3"
> > ALTERNATIVE_LINK_NAME[blkid.8] = "${mandir}/man8/blkid.8"
>
> I don't have a strong opinion on those, RP?
The reply from Ross suggests we do need to remove these otherwise the
system warns about missing files...
Cheers,
Richard
next prev parent reply other threads:[~2016-01-21 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 7:20 [PATCH] e2fsprogs: disable libblkid again Koen Kooi
2016-01-21 7:42 ` Robert Yang
2016-01-21 7:44 ` Koen Kooi
2016-01-21 21:53 ` Richard Purdie [this message]
2016-01-21 20:32 ` Burton, Ross
2016-01-22 9:20 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453413237.27999.172.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=koen.kooi@linaro.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.