From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit Date: Fri, 22 Jan 2016 11:21:00 +0200 Message-ID: <1453454460.5903.9.camel@intel.com> References: <1450519123-28206-1-git-send-email-chris@chris-wilson.co.uk> <1452790243.27879.37.camel@intel.com> <1453377129.19574.1.camel@linux.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 6824E6EBA6 for ; Fri, 22 Jan 2016 01:21:20 -0800 (PST) In-Reply-To: <1453377129.19574.1.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen , Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE2LTAxLTIxIGF0IDEzOjUyICswMjAwLCBKb29uYXMgTGFodGluZW4gd3JvdGU6 Cj4gT24gdG8sIDIwMTYtMDEtMTQgYXQgMTg6NTAgKzAyMDAsIEltcmUgRGVhayB3cm90ZToKPiBb Li4uXQo+IEJlbG93IHBhdGNoIGxvb2tzIGZpbmUuIEp1c3QgdGhhdCBJJ2QgdXNlIHMvaWZfZW5h YmxlZC9pZl9pbl91c2UvIHRvCj4gbWF0Y2ggdGhlIFBNIEFQSSBiZXR0ZXIuIFdlJ3JlIGFscmVh ZHkgZG9pbmcgdG9vIG11Y2ggb2YgYSBnb29kIGpvYgo+IHRvCj4gaGF2aW5nIG1hbnkgbmFtZXMg Zm9yIHNhbWUgdGhpbmcuCgpXZSBkbyBoYXZlIHR3byBzZXBhcmF0ZSBzdGF0ZXMgdGhhdCB3ZSBo YW5kbGUgc2VwYXJhdGVseSBpbiBib3RoCmZyYW1ld29ya3M6Ci0gZW5hYmxlZC9hY3RpdmU6IHRo ZSBIVyBpcyBwb3dlcmVkLW9uIGF0IHRoZSBtb21lbnQKLSBpbl91c2U6IHRoZSBIVyBpcyBwb3dl cmVkLW9uIF9hbmRfIHdlIGhvbGQgYSByZWZlcmVuY2UKClNvIGltbyBpdCBtYWtlcyBzZW5zZSB0 byBtYWtlIHRoaXMgZGlzdGluY3Rpb24gaW4gdGhlIGZ1bmN0aW9uIG5hbWVzCnRvby4KCi0tSW1y ZQoKPiBSZWdhcmRzLCBKb29uYXMKPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZGkuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ ID4gaW5kZXggMWY5YTM2OC4uOTA3Mzc3ZGMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGRpLmMKPiA+IEBAIC0xOTEwLDEzICsxOTEwLDE2IEBAIGJvb2wKPiA+IGludGVsX2RkaV9jb25u ZWN0b3JfZ2V0X2h3X3N0YXRlKHN0cnVjdAo+ID4gaW50ZWxfY29ubmVjdG9yICppbnRlbF9jb25u ZWN0b3IpCj4gPiDCoAllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXI7Cj4gPiDCoAllbnVt IGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIHBvd2VyX2RvbWFpbjsKPiA+IMKgCXVpbnQzMl90 IHRtcDsKPiA+ICsJYm9vbCByZXQ7Cj4gPiDCoAo+ID4gwqAJcG93ZXJfZG9tYWluID0KPiA+IGlu dGVsX2Rpc3BsYXlfcG9ydF9wb3dlcl9kb21haW4oaW50ZWxfZW5jb2Rlcik7Cj4gPiAtCWlmICgh aW50ZWxfZGlzcGxheV9wb3dlcl9pc19lbmFibGVkKGRldl9wcml2LAo+ID4gcG93ZXJfZG9tYWlu KSkKPiA+ICsJaWYgKCFpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldF9pZl9lbmFibGVkKGRldl9wcml2 LAo+ID4gcG93ZXJfZG9tYWluKSkKPiA+IMKgCQlyZXR1cm4gZmFsc2U7Cj4gPiDCoAo+ID4gLQlp ZiAoIWludGVsX2VuY29kZXItPmdldF9od19zdGF0ZShpbnRlbF9lbmNvZGVyLCAmcGlwZSkpCj4g PiAtCQlyZXR1cm4gZmFsc2U7Cj4gPiArCWlmICghaW50ZWxfZW5jb2Rlci0+Z2V0X2h3X3N0YXRl KGludGVsX2VuY29kZXIsICZwaXBlKSkgewo+ID4gKwkJcmV0ID0gZmFsc2U7Cj4gPiArCQlnb3Rv IG91dDsKPiA+ICsJfQo+ID4gwqAKPiA+IMKgCWlmIChwb3J0ID09IFBPUlRfQSkKPiA+IMKgCQlj cHVfdHJhbnNjb2RlciA9IFRSQU5TQ09ERVJfRURQOwo+ID4gQEAgLTE5MjgsMjMgKzE5MzEsMzAg QEAgYm9vbAo+ID4gaW50ZWxfZGRpX2Nvbm5lY3Rvcl9nZXRfaHdfc3RhdGUoc3RydWN0Cj4gPiBp bnRlbF9jb25uZWN0b3IgKmludGVsX2Nvbm5lY3RvcikKPiA+IMKgCXN3aXRjaCAodG1wICYgVFJB TlNfRERJX01PREVfU0VMRUNUX01BU0spIHsKPiA+IMKgCWNhc2UgVFJBTlNfRERJX01PREVfU0VM RUNUX0hETUk6Cj4gPiDCoAljYXNlIFRSQU5TX0RESV9NT0RFX1NFTEVDVF9EVkk6Cj4gPiAtCQly ZXR1cm4gKHR5cGUgPT0gRFJNX01PREVfQ09OTkVDVE9SX0hETUlBKTsKPiA+ICsJCXJldCA9IHR5 cGUgPT0gRFJNX01PREVfQ09OTkVDVE9SX0hETUlBOwo+ID4gKwkJZ290byBvdXQ7Cj4gPiDCoAo+ ID4gwqAJY2FzZSBUUkFOU19ERElfTU9ERV9TRUxFQ1RfRFBfU1NUOgo+ID4gLQkJaWYgKHR5cGUg PT0gRFJNX01PREVfQ09OTkVDVE9SX2VEUCkKPiA+IC0JCQlyZXR1cm4gdHJ1ZTsKPiA+IC0JCXJl dHVybiAodHlwZSA9PSBEUk1fTU9ERV9DT05ORUNUT1JfRGlzcGxheVBvcnQpOwo+ID4gKwkJcmV0 ID0gdHlwZSA9PSBEUk1fTU9ERV9DT05ORUNUT1JfZURQIHx8Cj4gPiArCQnCoMKgwqDCoMKgwqB0 eXBlID09IERSTV9NT0RFX0NPTk5FQ1RPUl9EaXNwbGF5UG9ydDsKPiA+ICsJCWdvdG8gb3V0Owo+ ID4gwqAJY2FzZSBUUkFOU19ERElfTU9ERV9TRUxFQ1RfRFBfTVNUOgo+ID4gwqAJCS8qIGlmIHRo ZSB0cmFuc2NvZGVyIGlzIGluIE1TVCBzdGF0ZSB0aGVuCj4gPiDCoAkJwqAqIGNvbm5lY3RvciBp c24ndCBjb25uZWN0ZWQgKi8KPiA+IC0JCXJldHVybiBmYWxzZTsKPiA+ICsJCXJldCA9IGZhbHNl Owo+ID4gKwkJZ290byBvdXQ7Cj4gPiDCoAo+ID4gwqAJY2FzZSBUUkFOU19ERElfTU9ERV9TRUxF Q1RfRkRJOgo+ID4gLQkJcmV0dXJuICh0eXBlID09IERSTV9NT0RFX0NPTk5FQ1RPUl9WR0EpOwo+ ID4gKwkJcmV0ID0gdHlwZSA9PSBEUk1fTU9ERV9DT05ORUNUT1JfVkdBOwo+ID4gKwkJZ290byBv dXQ7Cj4gPiDCoAo+ID4gwqAJZGVmYXVsdDoKPiA+IC0JCXJldHVybiBmYWxzZTsKPiA+ICsJCXJl dCA9IGZhbHNlOwo+ID4gwqAJfQo+ID4gK291dDoKPiA+ICsJaW50ZWxfZGlzcGxheV9wb3dlcl9w dXQoZGV2X3ByaXYsIHBvd2VyX2RvbWFpbik7Cj4gPiArCj4gPiArCXJldHVybiByZXQ7Cj4gPiDC oH0KPiA+IMKgCj4gPiDCoGJvb2wgaW50ZWxfZGRpX2dldF9od19zdGF0ZShzdHJ1Y3QgaW50ZWxf ZW5jb2RlciAqZW5jb2RlciwKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gaW5k ZXggMDU5YjQ2ZS4uM2M4NDE1OSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ ID4gQEAgLTE0NTYsNiArMTQ1Niw4IEBAIGJvb2wgX19pbnRlbF9kaXNwbGF5X3Bvd2VyX2lzX2Vu YWJsZWQoc3RydWN0Cj4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+IMKgCQkJCcKg wqDCoMKgwqDCoGVudW0KPiA+IGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIGRvbWFpbik7Cj4g PiDCoHZvaWQgaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ID4gwqAJCQnCoMKgwqDCoMKgZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2Rv bWFpbgo+ID4gZG9tYWluKTsKPiA+ICtib29sIGludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2Vu YWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiA+ICpkZXZfcHJpdiwKPiA+ICsJCQkJCWVu dW0KPiA+IGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIGRvbWFpbik7Cj4gPiDCoHZvaWQgaW50 ZWxfZGlzcGxheV9wb3dlcl9wdXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ID4gwqAJCQnCoMKgwqDCoMKgZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbgo+ID4gZG9t YWluKTsKPiA+IMKgCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cnVudGltZV9wbS5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0u Ywo+ID4gaW5kZXggYmJjYTUyNy4uNmM0ZjE3MCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gPiBAQCAtMTQ3MCw2ICsxNDcwLDE3IEBAIHZvaWQgaW50 ZWxfZGlzcGxheV9wb3dlcl9nZXQoc3RydWN0Cj4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiA+IMKgCW11dGV4X3VubG9jaygmcG93ZXJfZG9tYWlucy0+bG9jayk7Cj4gPiDCoH0KPiA+ IMKgCj4gPiArYm9vbCBpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldF9pZl9lbmFibGVkKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlCj4gPiAqZGV2X3ByaXYsCj4gPiArCQkJCQllbnVtCj4gPiBpbnRlbF9k aXNwbGF5X3Bvd2VyX2RvbWFpbiBkb21haW4pCj4gPiArewo+ID4gKwlpZiAoIWludGVsX2Rpc3Bs YXlfcG93ZXJfaXNfZW5hYmxlZChkZXZfcHJpdiwgZG9tYWluKSkKPiA+ICsJCXJldHVybiBmYWxz ZTsKPiA+ICsKPiA+ICsJaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIGRvbWFpbik7 Cj4gPiArCj4gPiArCXJldHVybiB0cnVlOwo+ID4gK30KPiA+ICsKPiA+IMKgLyoqCj4gPiDCoCAq IGludGVsX2Rpc3BsYXlfcG93ZXJfcHV0IC0gcmVsZWFzZSBhIHBvd2VyIGRvbWFpbiByZWZlcmVu Y2UKPiA+IMKgICogQGRldl9wcml2OiBpOTE1IGRldmljZSBpbnN0YW5jZQo+ID4gCj4gPiAtLUlt cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK