From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Greg KH <gregkh@linuxfoundation.org>,
Ming Lei <ming.lei@canonical.com>,
Johannes Berg <johannes@sipsolutions.net>,
Andy Lutomirski <luto@amacapital.net>,
Jonathan Corbet <corbet@lwn.net>,
David Woodhouse <dwmw2@infradead.org>,
David Howells <dhowells@redhat.com>,
Seth Forshee <seth.forshee@canonical.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Michal Marek <mmarek@suse.cz>,
Matthew Garrett <mjg59@srcf.ucam.org>,
kyle@kernel.org, dmitry.kasatkin@gmail.com,
Vivek Goyal <vgoyal@redhat.com>,
Brian Norris <computersforpeace@gmail.com>,
Kees Cook <keescook@chromium.org>,
shuahkh@osg.samsung.com,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-security-module <linux-security-module@vger.kernel.org>,
keyrings@linux-nfs.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] firmware: fold successful fw read early
Date: Fri, 22 Jan 2016 06:56:52 -0500 [thread overview]
Message-ID: <1453463812.9549.202.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160122014541.GV20964@wotan.suse.de>
On Fri, 2016-01-22 at 02:45 +0100, Luis R. Rodriguez wrote:
> On Mon, Jan 04, 2016 at 03:48:29PM -0500, Josh Boyer wrote:
> > On Wed, Dec 23, 2015 at 4:34 PM, Luis R. Rodriguez
> > <mcgrof@do-not-panic.com> wrote:
> > > From: David Howells <dhowells@redhat.com>
> > >
> > > We'll be folding in some more checks on fw_read_file_contents(),
> > > this will make the success case easier to follow.
> > >
> > > Signed-off-by: David Howells <dhowells@redhat.com>
> > > Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> >
> > Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org>
>
> Thanks Josh.
>
> Mimi, this is the other patch that I was referring to.
After this patch set, replacing the fw_read_file calls with the
kernel_read_file_from_path() version is straight forward. Nice!
Mimi
next prev parent reply other threads:[~2016-01-22 11:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 21:34 [PATCH v3 0/5] firmware_class: extensible firmware API Luis R. Rodriguez
2015-12-23 21:34 ` [PATCH v3 1/5] firmware: generalize "firmware" as "system data" helpers Luis R. Rodriguez
2016-01-04 20:41 ` Kees Cook
2016-01-22 20:10 ` Luis R. Rodriguez
2015-12-23 21:34 ` [PATCH v3 2/5] firmware: move completing fw into a helper Luis R. Rodriguez
2016-01-04 20:44 ` Josh Boyer
2015-12-23 21:34 ` [PATCH v3 3/5] firmware: fold successful fw read early Luis R. Rodriguez
2016-01-04 20:48 ` Josh Boyer
2016-01-22 1:45 ` Luis R. Rodriguez
2016-01-22 11:56 ` Mimi Zohar [this message]
2016-01-22 19:50 ` Luis R. Rodriguez
2015-12-23 21:34 ` [PATCH v3 4/5] firmware: generalize reading file contents as a helper Luis R. Rodriguez
2016-01-22 1:43 ` Luis R. Rodriguez
2015-12-23 21:34 ` [PATCH v3 5/5] firmware: add an extensible system data helpers Luis R. Rodriguez
2015-12-23 22:26 ` kbuild test robot
2016-01-22 1:27 ` Luis R. Rodriguez
2016-01-04 20:31 ` Kees Cook
2016-01-22 1:58 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453463812.9549.202.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=computersforpeace@gmail.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=jwboyer@fedoraproject.org \
--cc=keescook@chromium.org \
--cc=keyrings@linux-nfs.org \
--cc=kyle@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=ming.lei@canonical.com \
--cc=mjg59@srcf.ucam.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=seth.forshee@canonical.com \
--cc=shuahkh@osg.samsung.com \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.