Re: [meta-oe][PATCH] networkmanager: Warning Fix

[Adrian Freihofer <adrian.freihofer@gmail.com>]

Hi Martin,

Thank you for the response. But it is confusing to me...
Networkmanager is always built with nmtui enabled, and we split it into package networkmanager-nmtui:
EXTRA_OECONF = \
    ...
    --with-nmtui=yes \
"
PACKAGES =+ "... ${PN}-nmtui"
FILES_${PN}-nmtui = " ...

I guess an additional package option for --with-nmtui does not fit. Either we have a compile time option or a package split.

Regarding rdepends:
Since libnewt is already listed as a build dependency pkgconfig automatically creates the correct rdepends:
 - libnewt is a runntime dependency of networkmanager-nmtui
 - networkmanager itself does not rdepend on it.
This is exatly what I expect. There is no need to force rdepends at all.

Again: I'm on jethro and I cannot see this warning.
What are we going to fix with this patch?

Please give me a hint, I cannot understand it.
Regards,
Adrian



On Fri, 2016-01-22 at 09:26 +0100, Martin Jansa wrote:
> It is correct approach to fix it.
> 
> This isn't:
> RDEPENDS_${PN}-nmtui += "libnewt"
> 
> On Fri, Jan 22, 2016 at 9:07 AM, Adrian Freihofer <
> adrian.freihofer@gmail.com> wrote:
> 
> > Hi
> > 
> > This is not the right approach to fix this warning.
> > Please try something like this:
> > RDEPENDS_${PN}-nmtui += "libnewt"
> > 
> > Notes:
> > - I never saw this warning.
> > - I would expect that pkgconfig does this automatically.
> > 
> > Regards,
> > Adrian
> > 
> > On Thu, 2016-01-21 at 12:21 +0300, Li Xin wrote:
> > > WARNING: QA Issue: networkmanager rdepends on libnewt, but it isn't a
> > build dependency? [build-deps]
> > > 
> > > Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com>
> > > ---
> > >  meta-oe/recipes-connectivity/networkmanager/networkmanager_1.0.6.bb |
> > 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/meta-oe/recipes-connectivity/networkmanager/
> > networkmanager_1.0.6.bb b/meta-oe/recipes-
> > > connectivity/networkmanager/networkmanager_1.0.6.bb
> > > index 1ddb66f..72b4e46 100644
> > > --- a/meta-oe/recipes-connectivity/networkmanager/
> > networkmanager_1.0.6.bb
> > > +++ b/meta-oe/recipes-connectivity/networkmanager/
> > networkmanager_1.0.6.bb
> > > @@ -56,6 +56,7 @@ PACKAGECONFIG[wifi] =
> > "--enable-wifi=yes,--enable-wifi=no,wireless-tools,wpa-sup
> > >  PACKAGECONFIG[ifupdown] = "--enable-ifupdown,--disable-ifupdown"
> > >  PACKAGECONFIG[netconfig] = "--with-netconfig=yes,--with-netconfig=no"
> > >  PACKAGECONFIG[qt4-x11-free] = "--enable-qt,--disable-qt,qt4-x11-free"
> > > +PACKAGECONFIG[libnewt] = "--with-nmtui=yes,--with-nmtui=no,libnewt"
> > > 
> > >  PACKAGES =+ "libnmutil libnmglib libnmglib-vpn ${PN}-tests
> > ${PN}-bash-completion \
> > >    ${PN}-nmtui ${PN}-nmtui-doc \
> > > --
> > > 1.8.4.2
> > > 
> > > 
> > > 
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >