diff for duplicates of <1453711547.2521.209.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 1536982..e147091 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ -On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote: +On Mon, 2016-01-25 at 07:32 +0000, Vineet Gupta wrote: > On Monday 25 January 2016 12:55 AM, Mans Rullgard wrote: -> > From: Andy Shevchenko <andriy.shevchenko at linux.intel.com> +> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > There are several changes are done here: > > @@ -20,8 +20,8 @@ On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote: > > > > ?- While here, replace dwc_fast_ffs() by __ffs(). > > -> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com> -> > Signed-off-by: Mans Rullgard <mans at mansr.com> +> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> +> > Signed-off-by: Mans Rullgard <mans@mansr.com> > > --- > > This patch changes the DT binding, so it should probably be amended > > for @@ -83,5 +83,5 @@ to be' or something like that. > -Vineet -- -Andy Shevchenko <andriy.shevchenko at linux.intel.com> +Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy diff --git a/a/content_digest b/N1/content_digest index 305d263..54ec0ab 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,12 +4,12 @@ "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" "Subject\0[PATCH 07/15] dmaengine: dw: revisit data_width property\0" "Date\0Mon, 25 Jan 2016 10:45:47 +0200\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote:\n" + "On Mon, 2016-01-25 at 07:32 +0000, Vineet Gupta wrote:\n" "> On Monday 25 January 2016 12:55 AM, Mans Rullgard wrote:\n" - "> > From: Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" + "> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" "> > \n" "> > There are several changes are done here:\n" "> > \n" @@ -29,8 +29,8 @@ "> > \n" "> > ?- While here, replace dwc_fast_ffs() by __ffs().\n" "> > \n" - "> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" - "> > Signed-off-by: Mans Rullgard <mans at mansr.com>\n" + "> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" + "> > Signed-off-by: Mans Rullgard <mans@mansr.com>\n" "> > ---\n" "> > This patch changes the DT binding, so it should probably be amended\n" "> > for\n" @@ -92,7 +92,7 @@ "> -Vineet\n" "\n" "-- \n" - "Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" + "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" Intel Finland Oy -a7c11968c134fbe18e8e66575059f0927b4b4f84eadab426d4f6b0a7d29d2159 +7ab9246da614b08dfae071c2b7c717c798ec6c0bb80e511c8046755e8187a1ef
diff --git a/a/1.txt b/N2/1.txt index 1536982..f9e1a02 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,43 +1,43 @@ -On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote: +On Mon, 2016-01-25 at 07:32 +0000, Vineet Gupta wrote: > On Monday 25 January 2016 12:55 AM, Mans Rullgard wrote: -> > From: Andy Shevchenko <andriy.shevchenko at linux.intel.com> +> > From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > > > > There are several changes are done here: > > -> > ?- Convert the property to be in bytes +> > - Convert the property to be in bytes > > -> > ???Much more convenient than keeping encoded value. +> > Much more convenient than keeping encoded value. > > -> > ?- Use one value for all AHB masters for now +> > - Use one value for all AHB masters for now > > -> > ???It seems in practice we have no controllers where masters have +> > It seems in practice we have no controllers where masters have > > different -> > ???data bus width, we still might return to distinct values when +> > data bus width, we still might return to distinct values when > > there is a use -> > ???case. +> > case. > > -> > ?- Rename data_width to data-width in the device tree bindings. +> > - Rename data_width to data-width in the device tree bindings. > > -> > ?- While here, replace dwc_fast_ffs() by __ffs(). +> > - While here, replace dwc_fast_ffs() by __ffs(). > > -> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com> -> > Signed-off-by: Mans Rullgard <mans at mansr.com> +> > Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> +> > Signed-off-by: Mans Rullgard <mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org> > > --- > > This patch changes the DT binding, so it should probably be amended > > for -> > compatibility with old device trees.??I've included it as is since +> > compatibility with old device trees. I've included it as is since > > I think > > the change as such is good. > > --- -> > ?Documentation/devicetree/bindings/dma/snps-dma.txt |??5 ++- -> > ?arch/arc/boot/dts/abilis_tb10x.dtsi????????????????|??2 +- -> > ?arch/arm/boot/dts/spear13xx.dtsi???????????????????|??4 +-- -> > ?drivers/dma/dw/core.c??????????????????????????????| 40 +++------- +> > Documentation/devicetree/bindings/dma/snps-dma.txt | 5 ++- +> > arch/arc/boot/dts/abilis_tb10x.dtsi | 2 +- +> > arch/arm/boot/dts/spear13xx.dtsi | 4 +-- +> > drivers/dma/dw/core.c | 40 +++------- > > ------------ -> > ?drivers/dma/dw/platform.c??????????????????????????|??8 ++--- -> > ?drivers/dma/dw/regs.h??????????????????????????????|??2 +- -> > ?include/linux/platform_data/dma-dw.h???????????????|??5 ++- -> > ?7 files changed, 16 insertions(+), 50 deletions(-) +> > drivers/dma/dw/platform.c | 8 ++--- +> > drivers/dma/dw/regs.h | 2 +- +> > include/linux/platform_data/dma-dw.h | 5 ++- +> > 7 files changed, 16 insertions(+), 50 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt > > b/Documentation/devicetree/bindings/dma/snps-dma.txt @@ -45,13 +45,13 @@ On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote: > > --- a/Documentation/devicetree/bindings/dma/snps-dma.txt > > +++ b/Documentation/devicetree/bindings/dma/snps-dma.txt > > @@ -13,8 +13,7 @@ Required properties: -> > ?- chan_priority: priority of channels. 0 (default): increase from +> > - chan_priority: priority of channels. 0 (default): increase from > > chan 0->n, 1: -> > ???increase from chan n->0 -> > ?- block_size: Maximum block size supported by the controller +> > increase from chan n->0 +> > - block_size: Maximum block size supported by the controller > > -- data_width: Maximum data width supported by hardware per AHB > > master -> > -??(0 - 8bits, 1 - 16bits, ..., 5 - 256bits) +> > - (0 - 8bits, 1 - 16bits, ..., 5 - 256bits) > > +- data-width: Maximum data width supported by hardware (in bytes) > > To the reader this suggests a value truely byte granular, but code @@ -68,13 +68,13 @@ to be' or something like that. > > ... > > @@ -726,10 +710,7 @@ dwc_prep_dma_memcpy(struct dma_chan *chan, > > dma_addr_t dest, dma_addr_t src, -> > ? -> > ? dwc->direction = DMA_MEM_TO_MEM; -> > ? +> > +> > dwc->direction = DMA_MEM_TO_MEM; +> > > > - data_width = dw->data_width[dwc->m_master]; > > - > > - src_width = dst_width = min_t(unsigned int, data_width, -> > - ??????dwc_fast_ffs(src | dest | +> > - dwc_fast_ffs(src | dest | > > len)); > > + src_width = dst_width = __ffs(dw->data_width | src | dest > > | len); @@ -83,5 +83,10 @@ to be' or something like that. > -Vineet -- -Andy Shevchenko <andriy.shevchenko at linux.intel.com> +Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Intel Finland Oy + +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 305d263..87b00b0 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,52 +1,68 @@ "ref\01453663322-14474-1-git-send-email-mans@mansr.com\0" "ref\01453663322-14474-8-git-send-email-mans@mansr.com\0" "ref\0C2D7FE5348E1B147BCA15975FBA23075F4E86560@us01wembx1.internal.synopsys.com\0" - "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" - "Subject\0[PATCH 07/15] dmaengine: dw: revisit data_width property\0" + "ref\0C2D7FE5348E1B147BCA15975FBA23075F4E86560-cALIpNOex2c3t6iM5Z/N3fufCSb+aD3WLzEdoUbNIic@public.gmane.org\0" + "From\0Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" + "Subject\0Re: [PATCH 07/15] dmaengine: dw: revisit data_width property\0" "Date\0Mon, 25 Jan 2016 10:45:47 +0200\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0Vineet Gupta <Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>" + Mans Rullgard <mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org> + Viresh Kumar <vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + " dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "Cc\0Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>" + Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> + Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> + Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> + Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> + Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> + Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> + " linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>\0" "\00:1\0" "b\0" - "On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote:\n" + "On Mon, 2016-01-25 at 07:32 +0000, Vineet Gupta wrote:\n" "> On Monday 25 January 2016 12:55 AM, Mans Rullgard wrote:\n" - "> > From: Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" + "> > From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" "> > \n" "> > There are several changes are done here:\n" "> > \n" - "> > ?- Convert the property to be in bytes\n" + "> > \302\240- Convert the property to be in bytes\n" "> > \n" - "> > ???Much more convenient than keeping encoded value.\n" + "> > \302\240\302\240\302\240Much more convenient than keeping encoded value.\n" "> > \n" - "> > ?- Use one value for all AHB masters for now\n" + "> > \302\240- Use one value for all AHB masters for now\n" "> > \n" - "> > ???It seems in practice we have no controllers where masters have\n" + "> > \302\240\302\240\302\240It seems in practice we have no controllers where masters have\n" "> > different\n" - "> > ???data bus width, we still might return to distinct values when\n" + "> > \302\240\302\240\302\240data bus width, we still might return to distinct values when\n" "> > there is a use\n" - "> > ???case.\n" + "> > \302\240\302\240\302\240case.\n" "> > \n" - "> > ?- Rename data_width to data-width in the device tree bindings.\n" + "> > \302\240- Rename data_width to data-width in the device tree bindings.\n" "> > \n" - "> > ?- While here, replace dwc_fast_ffs() by __ffs().\n" + "> > \302\240- While here, replace dwc_fast_ffs() by __ffs().\n" "> > \n" - "> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" - "> > Signed-off-by: Mans Rullgard <mans at mansr.com>\n" + "> > Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" + "> > Signed-off-by: Mans Rullgard <mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>\n" "> > ---\n" "> > This patch changes the DT binding, so it should probably be amended\n" "> > for\n" - "> > compatibility with old device trees.??I've included it as is since\n" + "> > compatibility with old device trees.\302\240\302\240I've included it as is since\n" "> > I think\n" "> > the change as such is good.\n" "> > ---\n" - "> > ?Documentation/devicetree/bindings/dma/snps-dma.txt |??5 ++-\n" - "> > ?arch/arc/boot/dts/abilis_tb10x.dtsi????????????????|??2 +-\n" - "> > ?arch/arm/boot/dts/spear13xx.dtsi???????????????????|??4 +--\n" - "> > ?drivers/dma/dw/core.c??????????????????????????????| 40 +++-------\n" + "> > \302\240Documentation/devicetree/bindings/dma/snps-dma.txt |\302\240\302\2405 ++-\n" + "> > \302\240arch/arc/boot/dts/abilis_tb10x.dtsi\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2402 +-\n" + "> > \302\240arch/arm/boot/dts/spear13xx.dtsi\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2404 +--\n" + "> > \302\240drivers/dma/dw/core.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 40 +++-------\n" "> > ------------\n" - "> > ?drivers/dma/dw/platform.c??????????????????????????|??8 ++---\n" - "> > ?drivers/dma/dw/regs.h??????????????????????????????|??2 +-\n" - "> > ?include/linux/platform_data/dma-dw.h???????????????|??5 ++-\n" - "> > ?7 files changed, 16 insertions(+), 50 deletions(-)\n" + "> > \302\240drivers/dma/dw/platform.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2408 ++---\n" + "> > \302\240drivers/dma/dw/regs.h\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2402 +-\n" + "> > \302\240include/linux/platform_data/dma-dw.h\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2405 ++-\n" + "> > \302\2407 files changed, 16 insertions(+), 50 deletions(-)\n" "> > \n" "> > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt\n" "> > b/Documentation/devicetree/bindings/dma/snps-dma.txt\n" @@ -54,13 +70,13 @@ "> > --- a/Documentation/devicetree/bindings/dma/snps-dma.txt\n" "> > +++ b/Documentation/devicetree/bindings/dma/snps-dma.txt\n" "> > @@ -13,8 +13,7 @@ Required properties:\n" - "> > ?- chan_priority: priority of channels. 0 (default): increase from\n" + "> > \302\240- chan_priority: priority of channels. 0 (default): increase from\n" "> > chan 0->n, 1:\n" - "> > ???increase from chan n->0\n" - "> > ?- block_size: Maximum block size supported by the controller\n" + "> > \302\240\302\240\302\240increase from chan n->0\n" + "> > \302\240- block_size: Maximum block size supported by the controller\n" "> > -- data_width: Maximum data width supported by hardware per AHB\n" "> > master\n" - "> > -??(0 - 8bits, 1 - 16bits, ..., 5 - 256bits)\n" + "> > -\302\240\302\240(0 - 8bits, 1 - 16bits, ..., 5 - 256bits)\n" "> > +- data-width: Maximum data width supported by hardware (in bytes)\n" "> \n" "> To the reader this suggests a value truely byte granular, but code\n" @@ -77,13 +93,13 @@ "> > ...\n" "> > @@ -726,10 +710,7 @@ dwc_prep_dma_memcpy(struct dma_chan *chan,\n" "> > dma_addr_t dest, dma_addr_t src,\n" - "> > ?\n" - "> > ?\tdwc->direction = DMA_MEM_TO_MEM;\n" - "> > ?\n" + "> > \302\240\n" + "> > \302\240\tdwc->direction = DMA_MEM_TO_MEM;\n" + "> > \302\240\n" "> > -\tdata_width = dw->data_width[dwc->m_master];\n" "> > -\n" "> > -\tsrc_width = dst_width = min_t(unsigned int, data_width,\n" - "> > -\t\t\t\t??????dwc_fast_ffs(src | dest |\n" + "> > -\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240dwc_fast_ffs(src | dest |\n" "> > len));\n" "> > +\tsrc_width = dst_width = __ffs(dw->data_width | src | dest\n" "> > | len);\n" @@ -92,7 +108,12 @@ "> -Vineet\n" "\n" "-- \n" - "Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" - Intel Finland Oy + "Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" + "Intel Finland Oy\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -a7c11968c134fbe18e8e66575059f0927b4b4f84eadab426d4f6b0a7d29d2159 +74834544d698c67c78334a128118f283e3f8b22806cd4783d62edf29ac074cc5
diff --git a/a/1.txt b/N3/1.txt index 1536982..63ad86a 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -1,43 +1,43 @@ -On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote: +On Mon, 2016-01-25 at 07:32 +0000, Vineet Gupta wrote: > On Monday 25 January 2016 12:55 AM, Mans Rullgard wrote: -> > From: Andy Shevchenko <andriy.shevchenko at linux.intel.com> +> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > There are several changes are done here: > > -> > ?- Convert the property to be in bytes +> > - Convert the property to be in bytes > > -> > ???Much more convenient than keeping encoded value. +> > Much more convenient than keeping encoded value. > > -> > ?- Use one value for all AHB masters for now +> > - Use one value for all AHB masters for now > > -> > ???It seems in practice we have no controllers where masters have +> > It seems in practice we have no controllers where masters have > > different -> > ???data bus width, we still might return to distinct values when +> > data bus width, we still might return to distinct values when > > there is a use -> > ???case. +> > case. > > -> > ?- Rename data_width to data-width in the device tree bindings. +> > - Rename data_width to data-width in the device tree bindings. > > -> > ?- While here, replace dwc_fast_ffs() by __ffs(). +> > - While here, replace dwc_fast_ffs() by __ffs(). > > -> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com> -> > Signed-off-by: Mans Rullgard <mans at mansr.com> +> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> +> > Signed-off-by: Mans Rullgard <mans@mansr.com> > > --- > > This patch changes the DT binding, so it should probably be amended > > for -> > compatibility with old device trees.??I've included it as is since +> > compatibility with old device trees. I've included it as is since > > I think > > the change as such is good. > > --- -> > ?Documentation/devicetree/bindings/dma/snps-dma.txt |??5 ++- -> > ?arch/arc/boot/dts/abilis_tb10x.dtsi????????????????|??2 +- -> > ?arch/arm/boot/dts/spear13xx.dtsi???????????????????|??4 +-- -> > ?drivers/dma/dw/core.c??????????????????????????????| 40 +++------- +> > Documentation/devicetree/bindings/dma/snps-dma.txt | 5 ++- +> > arch/arc/boot/dts/abilis_tb10x.dtsi | 2 +- +> > arch/arm/boot/dts/spear13xx.dtsi | 4 +-- +> > drivers/dma/dw/core.c | 40 +++------- > > ------------ -> > ?drivers/dma/dw/platform.c??????????????????????????|??8 ++--- -> > ?drivers/dma/dw/regs.h??????????????????????????????|??2 +- -> > ?include/linux/platform_data/dma-dw.h???????????????|??5 ++- -> > ?7 files changed, 16 insertions(+), 50 deletions(-) +> > drivers/dma/dw/platform.c | 8 ++--- +> > drivers/dma/dw/regs.h | 2 +- +> > include/linux/platform_data/dma-dw.h | 5 ++- +> > 7 files changed, 16 insertions(+), 50 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt > > b/Documentation/devicetree/bindings/dma/snps-dma.txt @@ -45,13 +45,13 @@ On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote: > > --- a/Documentation/devicetree/bindings/dma/snps-dma.txt > > +++ b/Documentation/devicetree/bindings/dma/snps-dma.txt > > @@ -13,8 +13,7 @@ Required properties: -> > ?- chan_priority: priority of channels. 0 (default): increase from +> > - chan_priority: priority of channels. 0 (default): increase from > > chan 0->n, 1: -> > ???increase from chan n->0 -> > ?- block_size: Maximum block size supported by the controller +> > increase from chan n->0 +> > - block_size: Maximum block size supported by the controller > > -- data_width: Maximum data width supported by hardware per AHB > > master -> > -??(0 - 8bits, 1 - 16bits, ..., 5 - 256bits) +> > - (0 - 8bits, 1 - 16bits, ..., 5 - 256bits) > > +- data-width: Maximum data width supported by hardware (in bytes) > > To the reader this suggests a value truely byte granular, but code @@ -68,13 +68,13 @@ to be' or something like that. > > ... > > @@ -726,10 +710,7 @@ dwc_prep_dma_memcpy(struct dma_chan *chan, > > dma_addr_t dest, dma_addr_t src, -> > ? -> > ? dwc->direction = DMA_MEM_TO_MEM; -> > ? +> > +> > dwc->direction = DMA_MEM_TO_MEM; +> > > > - data_width = dw->data_width[dwc->m_master]; > > - > > - src_width = dst_width = min_t(unsigned int, data_width, -> > - ??????dwc_fast_ffs(src | dest | +> > - dwc_fast_ffs(src | dest | > > len)); > > + src_width = dst_width = __ffs(dw->data_width | src | dest > > | len); @@ -83,5 +83,5 @@ to be' or something like that. > -Vineet -- -Andy Shevchenko <andriy.shevchenko at linux.intel.com> +Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy diff --git a/a/content_digest b/N3/content_digest index 305d263..86d49d3 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,52 +1,67 @@ "ref\01453663322-14474-1-git-send-email-mans@mansr.com\0" "ref\01453663322-14474-8-git-send-email-mans@mansr.com\0" "ref\0C2D7FE5348E1B147BCA15975FBA23075F4E86560@us01wembx1.internal.synopsys.com\0" - "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" - "Subject\0[PATCH 07/15] dmaengine: dw: revisit data_width property\0" + "From\0Andy Shevchenko <andriy.shevchenko@linux.intel.com>\0" + "Subject\0Re: [PATCH 07/15] dmaengine: dw: revisit data_width property\0" "Date\0Mon, 25 Jan 2016 10:45:47 +0200\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0Vineet Gupta <Vineet.Gupta1@synopsys.com>" + Mans Rullgard <mans@mansr.com> + Viresh Kumar <vireshk@kernel.org> + Vinod Koul <vinod.koul@intel.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " dmaengine@vger.kernel.org <dmaengine@vger.kernel.org>\0" + "Cc\0Rob Herring <robh+dt@kernel.org>" + Pawel Moll <pawel.moll@arm.com> + Mark Rutland <mark.rutland@arm.com> + Ian Campbell <ijc+devicetree@hellion.org.uk> + Kumar Gala <galak@codeaurora.org> + Russell King <linux@arm.linux.org.uk> + Dan Williams <dan.j.williams@intel.com> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" "\00:1\0" "b\0" - "On Mon, 2016-01-25@07:32 +0000, Vineet Gupta wrote:\n" + "On Mon, 2016-01-25 at 07:32 +0000, Vineet Gupta wrote:\n" "> On Monday 25 January 2016 12:55 AM, Mans Rullgard wrote:\n" - "> > From: Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" + "> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" "> > \n" "> > There are several changes are done here:\n" "> > \n" - "> > ?- Convert the property to be in bytes\n" + "> > \302\240- Convert the property to be in bytes\n" "> > \n" - "> > ???Much more convenient than keeping encoded value.\n" + "> > \302\240\302\240\302\240Much more convenient than keeping encoded value.\n" "> > \n" - "> > ?- Use one value for all AHB masters for now\n" + "> > \302\240- Use one value for all AHB masters for now\n" "> > \n" - "> > ???It seems in practice we have no controllers where masters have\n" + "> > \302\240\302\240\302\240It seems in practice we have no controllers where masters have\n" "> > different\n" - "> > ???data bus width, we still might return to distinct values when\n" + "> > \302\240\302\240\302\240data bus width, we still might return to distinct values when\n" "> > there is a use\n" - "> > ???case.\n" + "> > \302\240\302\240\302\240case.\n" "> > \n" - "> > ?- Rename data_width to data-width in the device tree bindings.\n" + "> > \302\240- Rename data_width to data-width in the device tree bindings.\n" "> > \n" - "> > ?- While here, replace dwc_fast_ffs() by __ffs().\n" + "> > \302\240- While here, replace dwc_fast_ffs() by __ffs().\n" "> > \n" - "> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" - "> > Signed-off-by: Mans Rullgard <mans at mansr.com>\n" + "> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" + "> > Signed-off-by: Mans Rullgard <mans@mansr.com>\n" "> > ---\n" "> > This patch changes the DT binding, so it should probably be amended\n" "> > for\n" - "> > compatibility with old device trees.??I've included it as is since\n" + "> > compatibility with old device trees.\302\240\302\240I've included it as is since\n" "> > I think\n" "> > the change as such is good.\n" "> > ---\n" - "> > ?Documentation/devicetree/bindings/dma/snps-dma.txt |??5 ++-\n" - "> > ?arch/arc/boot/dts/abilis_tb10x.dtsi????????????????|??2 +-\n" - "> > ?arch/arm/boot/dts/spear13xx.dtsi???????????????????|??4 +--\n" - "> > ?drivers/dma/dw/core.c??????????????????????????????| 40 +++-------\n" + "> > \302\240Documentation/devicetree/bindings/dma/snps-dma.txt |\302\240\302\2405 ++-\n" + "> > \302\240arch/arc/boot/dts/abilis_tb10x.dtsi\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2402 +-\n" + "> > \302\240arch/arm/boot/dts/spear13xx.dtsi\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2404 +--\n" + "> > \302\240drivers/dma/dw/core.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 40 +++-------\n" "> > ------------\n" - "> > ?drivers/dma/dw/platform.c??????????????????????????|??8 ++---\n" - "> > ?drivers/dma/dw/regs.h??????????????????????????????|??2 +-\n" - "> > ?include/linux/platform_data/dma-dw.h???????????????|??5 ++-\n" - "> > ?7 files changed, 16 insertions(+), 50 deletions(-)\n" + "> > \302\240drivers/dma/dw/platform.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2408 ++---\n" + "> > \302\240drivers/dma/dw/regs.h\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2402 +-\n" + "> > \302\240include/linux/platform_data/dma-dw.h\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\2405 ++-\n" + "> > \302\2407 files changed, 16 insertions(+), 50 deletions(-)\n" "> > \n" "> > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt\n" "> > b/Documentation/devicetree/bindings/dma/snps-dma.txt\n" @@ -54,13 +69,13 @@ "> > --- a/Documentation/devicetree/bindings/dma/snps-dma.txt\n" "> > +++ b/Documentation/devicetree/bindings/dma/snps-dma.txt\n" "> > @@ -13,8 +13,7 @@ Required properties:\n" - "> > ?- chan_priority: priority of channels. 0 (default): increase from\n" + "> > \302\240- chan_priority: priority of channels. 0 (default): increase from\n" "> > chan 0->n, 1:\n" - "> > ???increase from chan n->0\n" - "> > ?- block_size: Maximum block size supported by the controller\n" + "> > \302\240\302\240\302\240increase from chan n->0\n" + "> > \302\240- block_size: Maximum block size supported by the controller\n" "> > -- data_width: Maximum data width supported by hardware per AHB\n" "> > master\n" - "> > -??(0 - 8bits, 1 - 16bits, ..., 5 - 256bits)\n" + "> > -\302\240\302\240(0 - 8bits, 1 - 16bits, ..., 5 - 256bits)\n" "> > +- data-width: Maximum data width supported by hardware (in bytes)\n" "> \n" "> To the reader this suggests a value truely byte granular, but code\n" @@ -77,13 +92,13 @@ "> > ...\n" "> > @@ -726,10 +710,7 @@ dwc_prep_dma_memcpy(struct dma_chan *chan,\n" "> > dma_addr_t dest, dma_addr_t src,\n" - "> > ?\n" - "> > ?\tdwc->direction = DMA_MEM_TO_MEM;\n" - "> > ?\n" + "> > \302\240\n" + "> > \302\240\tdwc->direction = DMA_MEM_TO_MEM;\n" + "> > \302\240\n" "> > -\tdata_width = dw->data_width[dwc->m_master];\n" "> > -\n" "> > -\tsrc_width = dst_width = min_t(unsigned int, data_width,\n" - "> > -\t\t\t\t??????dwc_fast_ffs(src | dest |\n" + "> > -\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240dwc_fast_ffs(src | dest |\n" "> > len));\n" "> > +\tsrc_width = dst_width = __ffs(dw->data_width | src | dest\n" "> > | len);\n" @@ -92,7 +107,7 @@ "> -Vineet\n" "\n" "-- \n" - "Andy Shevchenko <andriy.shevchenko at linux.intel.com>\n" + "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" Intel Finland Oy -a7c11968c134fbe18e8e66575059f0927b4b4f84eadab426d4f6b0a7d29d2159 +16c90258f788372bfb94e34356efa09deb2dd017c66cb546d853171e957e0da4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.