From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932285AbcAYM6l (ORCPT ); Mon, 25 Jan 2016 07:58:41 -0500 Received: from smtprelay0188.hostedemail.com ([216.40.44.188]:50189 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751259AbcAYM6i (ORCPT ); Mon, 25 Jan 2016 07:58:38 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2904:2911:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:3874:4321:4425:5007:6261:7996:9010:9390:10004:10400:10848:11232:11658:11783:11914:12043:12296:12438:12517:12519:12555:12679:12740:13069:13095:13311:13357:13894:14659:21080:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: legs62_684109686a907 X-Filterd-Recvd-Size: 1958 Message-ID: <1453726713.28952.58.camel@perches.com> Subject: Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay" From: Joe Perches To: Sudip Mukherjee , Patrick Pannuto Cc: Dan Carpenter , Willy Tarreau , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Sirnam Swetha , linux-kernel@vger.kernel.org Date: Mon, 25 Jan 2016 04:58:33 -0800 In-Reply-To: <20160125125127.GB29998@sudip-pc> References: <1453540760-31034-1-git-send-email-sudipm.mukherjee@gmail.com> <20160125091601.GG5325@mwanda> <1453726046.28952.54.camel@perches.com> <20160125125127.GB29998@sudip-pc> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-01-25 at 18:21 +0530, Sudip Mukherjee wrote: > On Mon, Jan 25, 2016 at 04:47:26AM -0800, Joe Perches wrote: > > On Mon, 2016-01-25 at 12:16 +0300, Dan Carpenter wrote: > > > Ugh...  Checkpatch told us to introduce bugs...  :(  We almost certainly > > > would have missed this bug in review, but it wasn't sent to the list so > > > I guess we'll never know. > > > > So when isn't usleep_range preferred over udelay? > > inside a spin_lock or in some interrupt routine. That's what timers-howto says and the checkpatch message for this refers to it. This message has been in checkpatch since 2010 commit 1a15a250862fda3fbdf8454cc7131e24de904e7c Author: Patrick Pannuto Maybe the checkpatch message can have "when not atomic" added or some such.