From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/3] printk: make preferred_console local static bool Date: Mon, 25 Jan 2016 05:23:25 -0800 Message-ID: <1453728205.28952.62.camel@perches.com> References: <1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org> <1453722324-22407-2-git-send-email-aleksey.makarov@linaro.org> <1453725901.28952.53.camel@perches.com> <56A61A6F.10409@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtprelay0192.hostedemail.com ([216.40.44.192]:35541 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750846AbcAYNX3 (ORCPT ); Mon, 25 Jan 2016 08:23:29 -0500 In-Reply-To: <56A61A6F.10409@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Aleksey Makarov , linux-acpi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Graeme Gregory , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Leif Lindholm On Mon, 2016-01-25 at 18:51 +0600, Aleksey Makarov wrote: >=20 > On 25.01.2016 18:45, Joe Perches wrote: > > On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote: > > > The variable preferred_console is used only inside register_conso= le() > > > and it's semantics is boolean.=A0=A0Make it clear. > >=20 > > This loses the index of the preferred console. > > I'm not sure this is better. >=20 > That index is not used anywhere.=A0=A0I believe the patch makes thing= s clear. Well, with this change the name and its use is a bit misleading. =A0Maybe changing it to something like use_selected_console is better. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Mon, 25 Jan 2016 05:23:25 -0800 Subject: [PATCH 1/3] printk: make preferred_console local static bool In-Reply-To: <56A61A6F.10409@linaro.org> References: <1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org> <1453722324-22407-2-git-send-email-aleksey.makarov@linaro.org> <1453725901.28952.53.camel@perches.com> <56A61A6F.10409@linaro.org> Message-ID: <1453728205.28952.62.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2016-01-25 at 18:51 +0600, Aleksey Makarov wrote: > > On 25.01.2016 18:45, Joe Perches wrote: > > On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote: > > > The variable preferred_console is used only inside register_console() > > > and it's semantics is boolean.??Make it clear. > > > > This loses the index of the preferred console. > > I'm not sure this is better. > > That index is not used anywhere.??I believe the patch makes things clear. Well, with this change the name and its use is a bit misleading. ?Maybe changing it to something like use_selected_console is better. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756817AbcAYNXb (ORCPT ); Mon, 25 Jan 2016 08:23:31 -0500 Received: from smtprelay0192.hostedemail.com ([216.40.44.192]:35541 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750846AbcAYNX3 (ORCPT ); Mon, 25 Jan 2016 08:23:29 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3874:4321:5007:6261:10004:10400:10848:11026:11232:11473:11658:11783:11914:12296:12438:12517:12519:12663:12740:13069:13311:13357:13894:13972:14659:21080:30029:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: stick69_1dfffa778ae02 X-Filterd-Recvd-Size: 1842 Message-ID: <1453728205.28952.62.camel@perches.com> Subject: Re: [PATCH 1/3] printk: make preferred_console local static bool From: Joe Perches To: Aleksey Makarov , linux-acpi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Graeme Gregory , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Leif Lindholm Date: Mon, 25 Jan 2016 05:23:25 -0800 In-Reply-To: <56A61A6F.10409@linaro.org> References: <1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org> <1453722324-22407-2-git-send-email-aleksey.makarov@linaro.org> <1453725901.28952.53.camel@perches.com> <56A61A6F.10409@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-01-25 at 18:51 +0600, Aleksey Makarov wrote: > > On 25.01.2016 18:45, Joe Perches wrote: > > On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote: > > > The variable preferred_console is used only inside register_console() > > > and it's semantics is boolean.  Make it clear. > > > > This loses the index of the preferred console. > > I'm not sure this is better. > > That index is not used anywhere.  I believe the patch makes things clear. Well, with this change the name and its use is a bit misleading.  Maybe changing it to something like use_selected_console is better.