From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap Date: Mon, 25 Jan 2016 07:25:34 -0800 Message-ID: <1453735534.2363.7.camel@HansenPartnership.com> References: <1453560913-134672-1-git-send-email-andriy.shevchenko@linux.intel.com> <1453560913-134672-4-git-send-email-andriy.shevchenko@linux.intel.com> <1453567445.2470.24.camel@HansenPartnership.com> <1453572191.2470.52.camel@HansenPartnership.com> <1453710713.2521.200.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453710713.2521.200.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko , Andy Shevchenko Cc: Matt Fleming , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rasmus Villemoes , Andrew Morton , "linux-kernel @ vger . kernel . org" , Robert Elliott List-Id: linux-efi@vger.kernel.org On Mon, 2016-01-25 at 10:31 +0200, Andy Shevchenko wrote: > On Sat, 2016-01-23 at 10:03 -0800, James Bottomley wrote: > > On Sat, 2016-01-23 at 19:18 +0200, Andy Shevchenko wrote: > > > > If the goal is to have a clean interface reporting only the > > > > first > > > > four significant figures and a size exponent, then a helper > > > > would > > > > be much better than trying to open code this ad hoc. > > > > > > No. You get it wrong. The initial idea was (actually not mine, > > > see > > > authorship) to print an exact number with units and reduce > > > whenever > > > it's possible, i.e number is a multiplication of certain unit. > > > > so you must implement the original idea no matter how inconsistent > > it > > leads us to be? Is it wrong to try to do better? > > For both comments I prefer to hear Matt's opinion as he is maintainer > of EFI stuff. > > My role in this all is to reduce the code base by avoiding 'not > invented here' syndrome. To get up to the starting blocks on that one, you need a usable interface. Neither of the series has that for lib/string_helper.c, so this is a NAK to both of those parts. I already told you how to do it in a way that creates a maintainable interface. It looks obvious to me and I was politely waiting for you to produce it, but if you're saying your not able to, I suppose I can produce the patch. James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932664AbcAYPZi (ORCPT ); Mon, 25 Jan 2016 10:25:38 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:53218 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932102AbcAYPZg (ORCPT ); Mon, 25 Jan 2016 10:25:36 -0500 Message-ID: <1453735534.2363.7.camel@HansenPartnership.com> Subject: Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap From: James Bottomley To: Andy Shevchenko , Andy Shevchenko Cc: Matt Fleming , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , linux-efi@vger.kernel.org, Rasmus Villemoes , Andrew Morton , "linux-kernel @ vger . kernel . org" , Robert Elliott Date: Mon, 25 Jan 2016 07:25:34 -0800 In-Reply-To: <1453710713.2521.200.camel@linux.intel.com> References: <1453560913-134672-1-git-send-email-andriy.shevchenko@linux.intel.com> <1453560913-134672-4-git-send-email-andriy.shevchenko@linux.intel.com> <1453567445.2470.24.camel@HansenPartnership.com> <1453572191.2470.52.camel@HansenPartnership.com> <1453710713.2521.200.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-01-25 at 10:31 +0200, Andy Shevchenko wrote: > On Sat, 2016-01-23 at 10:03 -0800, James Bottomley wrote: > > On Sat, 2016-01-23 at 19:18 +0200, Andy Shevchenko wrote: > > > > If the goal is to have a clean interface reporting only the > > > > first > > > > four significant figures and a size exponent, then a helper > > > > would > > > > be much better than trying to open code this ad hoc. > > > > > > No. You get it wrong. The initial idea was (actually not mine, > > > see > > > authorship) to print an exact number with units and reduce > > > whenever > > > it's possible, i.e number is a multiplication of certain unit. > > > > so you must implement the original idea no matter how inconsistent > > it > > leads us to be? Is it wrong to try to do better? > > For both comments I prefer to hear Matt's opinion as he is maintainer > of EFI stuff. > > My role in this all is to reduce the code base by avoiding 'not > invented here' syndrome. To get up to the starting blocks on that one, you need a usable interface. Neither of the series has that for lib/string_helper.c, so this is a NAK to both of those parts. I already told you how to do it in a way that creates a maintainable interface. It looks obvious to me and I was politely waiting for you to produce it, but if you're saying your not able to, I suppose I can produce the patch. James