From: Ian Campbell <ian.campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: ian.jackson@eu.citrix.com,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
wei.liu2@citrix.com, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] tools: avoid redefinition of typedefs
Date: Mon, 25 Jan 2016 17:12:39 +0000 [thread overview]
Message-ID: <1453741959.4320.208.camel@citrix.com> (raw)
In-Reply-To: <1453739834.4320.206.camel@citrix.com>
On Mon, 2016-01-25 at 16:37 +0000, Ian Campbell wrote:
> On Mon, 2016-01-25 at 17:24 +0100, Olaf Hering wrote:
> > On Mon, Jan 25, Ian Campbell wrote:
> >
> > > When splitting out various functionality from libxc into tools/libs/*
> > > I attempted to make it possible to avoid callers being unnecessarily
> > > exposed to the xentoollog interface by providing a typedef of the
> > > xentoollog_logger handle in each of the headers.
> >
> > Perhaps you already have another change in the queue. staging still
> > fails for me with evtchn_port_or_error_t xenevtchn_handle, like:
>
> I'm afraid not.
>
> I'll take a look.
I managed to reproduce with gcc-4.4 on my workstation, except I had to
disable the Python bits (because it apparently hardcodes CFLAGS from the
default compiler but still obey's $(CC) or something).
With that I've sent two more fixes for issues in this area.
Boris, copying you since you are suffering from these sorts of issues too.
>
>
> >
> > [ 130s] In file included from xc_private.h:35,
> > [ 130s] from xc_suspend.c:21:
> > [ 130s] ./include/xenctrl.h:1080: error: redefinition of typedef
> > 'evtchn_port_or_error_t'
> > [ 130s] /usr/src/packages/BUILD/xen-4.7.20160125T154552.84e0616/non-
> > dbg/tools/libxc/../../tools/libs/evtchn/include/xenevtchn.h:31: error:
> > previous declaration of 'evtchn_port_or_error_t' was here
> > [ 130s] In file included from xc_suspend.c:22:
> > [ 130s] ./include/xenguest.h:41: error: redefinition of typedef
> > 'xenevtchn_handle'
> > [ 130s] /usr/src/packages/BUILD/xen-4.7.20160125T154552.84e0616/non-
> > dbg/tools/libxc/../../tools/libs/evtchn/include/xenevtchn.h:33: error:
> > previous declaration of 'xenevtchn_handle' was here
> >
> > Olaf
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-01-25 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:29 [PATCH] tools: avoid redefinition of typedefs Ian Campbell
2016-01-25 15:46 ` Ian Jackson
2016-01-25 16:24 ` Olaf Hering
2016-01-25 16:37 ` Ian Campbell
2016-01-25 17:12 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453741959.4320.208.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.