From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Mon, 25 Jan 2016 16:01:43 -0800 Subject: [Intel-wired-lan] [PATCH 1/3] i40e: fix build warning In-Reply-To: <1453702251-464-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1453702251-464-1-git-send-email-sudipm.mukherjee@gmail.com> Message-ID: <1453766503.2932.13.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Mon, 2016-01-25 at 11:40 +0530, Sudip Mukherjee wrote: > While building we are getting warning about: > i40e_main.c:8604:13: warning: 'i40e_add_geneve_port' defined but not > used > and > i40e_main.c:8651:13: warning: 'i40e_del_geneve_port' defined but not > used > > The contents of these functions are defined under CONFIG_GENEVE, so > if > CONFIG_GENEVE is not defined then we are having unused empty > functions. > Lets have these functions under CONFIG_GENEVE as the callback is > already > defined under CONFIG_GENEVE there is no chance of any failure. > > Signed-off-by: Sudip Mukherjee > --- > ?drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++---- > ?1 file changed, 2 insertions(+), 4 deletions(-) This is not a complete fix for the issue and Eric Dumazet has already submitted a fix for the issue, which I have just sent to David Miller in a pull-request. So I have dropped this patch, in favor of Eric's solution. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755723AbcAZABt (ORCPT ); Mon, 25 Jan 2016 19:01:49 -0500 Received: from mga01.intel.com ([192.55.52.88]:40450 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbcAZABq (ORCPT ); Mon, 25 Jan 2016 19:01:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,347,1449561600"; d="asc'?scan'208";a="898215659" Message-ID: <1453766503.2932.13.camel@intel.com> Subject: Re: [PATCH 1/3] i40e: fix build warning From: Jeff Kirsher To: Sudip Mukherjee , Jesse Brandeburg , Shannon Nelson , Carolyn Wyborny , Don Skidmore , Bruce Allan , John Ronciak , Mitch Williams Cc: linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Date: Mon, 25 Jan 2016 16:01:43 -0800 In-Reply-To: <1453702251-464-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1453702251-464-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-9wnR8JnbcmE2cJdF2IOg" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-9wnR8JnbcmE2cJdF2IOg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-01-25 at 11:40 +0530, Sudip Mukherjee wrote: > While building we are getting warning about: > i40e_main.c:8604:13: warning: 'i40e_add_geneve_port' defined but not > used > and > i40e_main.c:8651:13: warning: 'i40e_del_geneve_port' defined but not > used >=20 > The contents of these functions are defined under CONFIG_GENEVE, so > if > CONFIG_GENEVE is not defined then we are having unused empty > functions. > Lets have these functions under CONFIG_GENEVE as the callback is > already > defined under CONFIG_GENEVE there is no chance of any failure. >=20 > Signed-off-by: Sudip Mukherjee > --- > =C2=A0drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++---- > =C2=A01 file changed, 2 insertions(+), 4 deletions(-) This is not a complete fix for the issue and Eric Dumazet has already submitted a fix for the issue, which I have just sent to David Miller in a pull-request. So I have dropped this patch, in favor of Eric's solution. --=-9wnR8JnbcmE2cJdF2IOg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABCgAGBQJWprdnAAoJEOVv75VaS+3OA+4P/0lUOQ9EGk9/M2qVIu8SIsaS UBMHalnL+3iI0yqC0MkI8Om7wGHoJJeIlU+lwWaUBU8KaONM01znJTgG3zzQ7a4Q LrKTySLiBSYFHArbRzoTH3cZYoLBzdUhnuQMp9jrLOZtQsSYHLyNBBzvEE7ueT7F 1eJuWDRaTnAxQUHC+hXYBwA81HlCmfU8xQPKQWOK35qOlHDQMGe3SQXdgrdd7jpw W5l4C8WFUD+G3J8OvmtyBp2DAMbEQthoW9hj6vZIsw45aQQ+3uIUbcKiCaYSBRY7 JQZujo6hAPkOieZ7+CzUDlR5/GUhn+TsyaEQiIKmnIW0R9Lpg92VApvUlk/Ovs/a Q+tzhEWCTpj4cVFv/HlIhvQ7K0PJUmfmx2OPJ9GcwdcMocmCxloaHUVbv3zyipis KJtWJxEdHWGKSKMHrJvgf4fvaBzNj6rS3pizyqrTTX75g32S7uHy0ACvcpoq8coX MlIp5uIk0ObA6vF/fOg51ZV/LQPhMVkVe4DcMVfEhFDBBEzVCvM7by4fiRn9rt0Y dg+jIIH/1wDiozk0BUDxrpz9eEAq2BKpd+j9bmI8hYXjKOrwaP1hwPkIkNOdQ1/D rLFCuyJ8J1fNhri1l5uXQZZdOlj5SDEY4H10gNH1/hTPA/VXwz3DLbkvrYFjKe3p f7QpWhAgicUc6G0E+3Uw =b4Lh -----END PGP SIGNATURE----- --=-9wnR8JnbcmE2cJdF2IOg--