All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: tiwai@suse.de, dvyukov@google.com, gregkh@linuxfoundation.org
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "ALSA: control: Avoid kernel warnings from tlv ioctl with numid 0" has been added to the 3.14-stable tree
Date: Mon, 25 Jan 2016 16:52:35 -0800	[thread overview]
Message-ID: <1453769555151165@kroah.com> (raw)


This is a note to let you know that I've just added the patch titled

    ALSA: control: Avoid kernel warnings from tlv ioctl with numid 0

to the 3.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     alsa-control-avoid-kernel-warnings-from-tlv-ioctl-with-numid-0.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From c0bcdbdff3ff73a54161fca3cb8b6cdbd0bb8762 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 18 Jan 2016 14:12:40 +0100
Subject: ALSA: control: Avoid kernel warnings from tlv ioctl with numid 0

From: Takashi Iwai <tiwai@suse.de>

commit c0bcdbdff3ff73a54161fca3cb8b6cdbd0bb8762 upstream.

When a TLV ioctl with numid zero is handled, the driver may spew a
kernel warning with a stack trace at each call.  The check was
intended obviously only for a kernel driver, but not for a user
interaction.  Let's fix it.

This was spotted by syzkaller fuzzer.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 sound/core/control.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1325,6 +1325,8 @@ static int snd_ctl_tlv_ioctl(struct snd_
 		return -EFAULT;
 	if (tlv.length < sizeof(unsigned int) * 2)
 		return -EINVAL;
+	if (!tlv.numid)
+		return -EINVAL;
 	down_read(&card->controls_rwsem);
 	kctl = snd_ctl_find_numid(card, tlv.numid);
 	if (kctl == NULL) {


Patches currently in stable-queue which might be from tiwai@suse.de are

queue-3.14/alsa-hrtimer-fix-stall-by-hrtimer_cancel.patch
queue-3.14/alsa-timer-harden-slave-timer-list-handling.patch
queue-3.14/alsa-timer-fix-double-unlink-of-active_list.patch
queue-3.14/alsa-control-avoid-kernel-warnings-from-tlv-ioctl-with-numid-0.patch
queue-3.14/alsa-hda-realtek-fix-silent-headphone-output-on-macpro-4-1-v2.patch
queue-3.14/alsa-rme96-fix-unexpected-volume-reset-after-rate-changes.patch
queue-3.14/alsa-hda-set-skl-hda-controller-power-at-freeze-and-thaw.patch
queue-3.14/alsa-hda-add-inverted-dmic-for-packard-bell-dots.patch
queue-3.14/alsa-hda-add-intel-lewisburg-device-ids-audio.patch
queue-3.14/alsa-seq-fix-race-at-timer-setup-and-close.patch
queue-3.14/alsa-pcm-fix-snd_pcm_hw_params-struct-copy-in-compat-mode.patch
queue-3.14/alsa-seq-fix-snd_seq_call_port_info_ioctl-in-compat-mode.patch
queue-3.14/alsa-seq-fix-missing-null-check-at-remove_events-ioctl.patch
queue-3.14/alsa-timer-fix-race-among-timer-ioctls.patch
queue-3.14/alsa-hda-apply-pin-fixup-for-hp-probook-6550b.patch

                 reply	other threads:[~2016-01-26  0:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453769555151165@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dvyukov@google.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.