From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 2/2] tools: avoid redefinining xenevtchn_handle typedef for xc_suspend_* Date: Tue, 26 Jan 2016 09:55:03 +0000 Message-ID: <1453802103.4320.225.camel@citrix.com> References: <1453741849-5484-2-git-send-email-ian.campbell@citrix.com> <22182.22982.932050.428228@mariner.uk.xensource.com> <56A65D0E.3030400@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56A65D0E.3030400@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , Ian Jackson Cc: Olaf Hering , wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2016-01-25 at 12:36 -0500, Boris Ostrovsky wrote: > On 01/25/2016 12:22 PM, Ian Jackson wrote: > > Ian Campbell writes ("[PATCH 2/2] tools: avoid redefinining > > xenevtchn_handle typedef for xc_suspend_*"): > > > Similar to the previous xentoollog case this is not allowed. Switch > > > to > > > a forward decl of the struct and use of it in the APIs. > > Both of these > > > > Acked-by: Ian Jackson > > Committed-by: Ian Jackson > > > It's too late by now, so really FYI: > > Tested-by: Boris Ostrovsky > > (for all three patches) Thanks Boris and Olaf for testing. Hopefully that's the last of this batch of issues. /me stands on one leg, touches wood, crosses fingers. Ian.