From: Johannes Berg <johannes@sipsolutions.net>
To: Sven Eckelmann <sven@narfation.org>
Cc: linux-wireless@vger.kernel.org, Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH] mac80211: Parse legacy and HT rate in injected frames
Date: Tue, 26 Jan 2016 14:23:35 +0100 [thread overview]
Message-ID: <1453814615.2759.48.camel@sipsolutions.net> (raw)
In-Reply-To: <1844534.ZYplpSov4f@bentobox>
On Mon, 2016-01-25 at 13:59 +0100, Sven Eckelmann wrote:
>
> The flag itself has to be set when the radiotap information is
> available+parsed and when the actual rate information calculation
> should
> happen.
>
> Afaik the ieee80211_tx_data is always a local variable on the stack.
> Either
> from ieee80211_tx_prepare_skb, ieee80211_tx, ieee80211_xmit_fast or
> ieee80211_get_buffered_bc. But the parsing of the radiotap header
> happens
> before that in ieee80211_monitor_start_xmit. And after that it calls
> ieee80211_xmit -> ieee80211_tx. So tx_data is definitely not
> available when
> the radiotap header is parsed.
Fair enough. We could put that data elsewhere, but it's probably not
worth it for a simple flag.
johannes
prev parent reply other threads:[~2016-01-26 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 14:36 [PATCH] mac80211: Parse legacy and HT rate in injected frames Sven Eckelmann
2015-10-13 14:40 ` [RFC] " Sven Eckelmann
2015-11-26 17:25 ` [PATCH] " Johannes Berg
2016-01-25 12:59 ` Sven Eckelmann
2016-01-26 13:23 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453814615.2759.48.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.