From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC V4 2/2] brcmfmac: add support for nl80211 BSS_SELECT feature
Date: Tue, 26 Jan 2016 15:02:36 +0100 [thread overview]
Message-ID: <1453816956.2759.73.camel@sipsolutions.net> (raw)
In-Reply-To: <1453813592-5266-3-git-send-email-arend@broadcom.com>
On Tue, 2016-01-26 at 14:06 +0100, Arend van Spriel wrote:
>
> +static u8 nl80211_band_to_fwil(enum nl80211_band band)
> +{
> + switch (band) {
> + case NL80211_BAND_2GHZ:
> + return WLC_BAND_2G;
> + case NL80211_BAND_5GHZ:
> + return WLC_BAND_5G;
> + default:
> + WARN_ON(1);
>
This, btw, is trivially triggerable - you need to check in nl80211 that
the specified band is actually supported by the driver, otherwise even
non-sense like "17" can be specified.
johannes
prev parent reply other threads:[~2016-01-26 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 13:06 [RFC V4 0/2] nl80211: allow configuration of BSS selection Arend van Spriel
2016-01-26 13:06 ` [RFC V4 1/2] nl80211: add feature for BSS selection support Arend van Spriel
2016-01-26 13:56 ` Johannes Berg
2016-01-27 21:53 ` Arend van Spriel
2016-01-28 9:50 ` Johannes Berg
2016-01-26 13:06 ` [RFC V4 2/2] brcmfmac: add support for nl80211 BSS_SELECT feature Arend van Spriel
2016-01-26 14:02 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453816956.2759.73.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.