From: Johannes Berg <johannes@sipsolutions.net>
To: Jonas Gorski <jogo@openwrt.org>, Florian Fainelli <f.fainelli@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Kevin Cernekee <cernekee@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
MIPS Mailing List <linux-mips@linux-mips.org>,
Simon Arlott <simon@fire.lp0.eu>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon
Date: Wed, 27 Jan 2016 11:45:54 +0100 [thread overview]
Message-ID: <1453891554.2351.1.camel@sipsolutions.net> (raw)
In-Reply-To: <CAOiHx=kk06ythGn=a3UGs-BBUUYxdm7zLsNtBFiCiwxF5m6VxA@mail.gmail.com>
On Wed, 2016-01-27 at 11:33 +0100, Jonas Gorski wrote:
>
> > +++ b/arch/mips/boot/dts/brcm/bcm6368.dtsi
> > @@ -54,7 +54,7 @@
> > periph_cntl: syscon@10000000 {
> > compatible = "syscon";
> > reg = <0x10000000 0x14>;
> > - little-endian;
> > + native-endian;
>
> But native-endian == big-endian usually for bcm63xx, so is this
> actually a bugfix?
>
It's complicated :)
These were originally specified as little-endian because it _worked_,
but that was only because of an issue with the code - it was getting
byteswapped twice.
This was "fixed" in commit 29bb45f25ff3051354ed330c0d0f10418a2b8c7c,
and I assume this DT file was created/copied before that commit and
didn't get that update due to merge delays. So after that commit, this
file couldn't have worked, but that's how it got to this point.
johannes
next prev parent reply other threads:[~2016-01-27 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 22:46 [PATCH 1/2] regmap: Add explict native endian flag to DT bindings Mark Brown
2016-01-26 22:46 ` [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon Mark Brown
2016-01-26 23:16 ` Florian Fainelli
2016-01-27 9:37 ` Ralf Baechle
2016-01-27 10:33 ` Jonas Gorski
2016-01-27 10:45 ` Johannes Berg [this message]
2016-01-27 11:10 ` Mark Brown
2016-01-27 18:51 ` Mark Brown
2016-01-27 11:02 ` [PATCH 1/2] regmap: Add explict native endian flag to DT bindings Arnd Bergmann
2016-01-27 12:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453891554.2351.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cernekee@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.