From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: Beniamino Galvani <bgalvani@redhat.com>
Subject: Re: [PATCH] wext: fix message delay/ordering
Date: Wed, 27 Jan 2016 13:18:34 +0100 [thread overview]
Message-ID: <1453897114.2351.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1453897040.2351.3.camel@sipsolutions.net> (sfid-20160127_131726_366051_5927EBBD)
> > + if (state == NETDEV_UNREGISTER)
> > + wireless_nlevent_flush();
> >
> It could be argued that the state check isn't really necessary and
> should be removed to avoid ordering issues with up/down vs. wext, but
> this fixes the really strange issue where you get an RTM_NEWLINK
> after
> RTM_DELLINK (with the same ifidx), and I don't see how any software
> would care much about the ordering otherwise.
>
Actually though, with the fix I still get:
5: wlan1: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN group default
link/ether 02:00:00:00:01:00 brd ff:ff:ff:ff:ff:ff
5: wlan1: <BROADCAST,MULTICAST,UP>
link/ether
Deleted 5: wlan1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default
link/ether 02:00:00:00:01:00 brd ff:ff:ff:ff:ff:ff
which is clearly odd (see the UP flag), so I'll change it.
johannes
next prev parent reply other threads:[~2016-01-27 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 12:14 [PATCH] wext: fix message delay/ordering Johannes Berg
2016-01-27 12:17 ` Johannes Berg
2016-01-27 12:18 ` Johannes Berg [this message]
2016-01-27 12:28 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453897114.2351.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bgalvani@redhat.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.