diff for duplicates of <1453922722.3014.29.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index e8f1d25..836e7e8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,33 +1,33 @@ On Wed, 2016-01-27 at 14:28 +0100, Corinna Vinschen wrote: > Problem: When switching off VLAN offloading on an i350, the VLAN -> interface gets unusable.? For testing, set up a VLAN on an i350 +> interface gets unusable. For testing, set up a VLAN on an i350 > and some remote machine, e.g.: > -> ? $ ip link add link eth0 name eth0.42 type vlan id 42 -> ? $ ip addr add 192.168.42.1/24 dev eth0.42 -> ? $ ip link set dev eth0.42 up +> $ ip link add link eth0 name eth0.42 type vlan id 42 +> $ ip addr add 192.168.42.1/24 dev eth0.42 +> $ ip link set dev eth0.42 up > > Offloading is switched on by default: > -> ? $ ethtool -k eth0 | grep vlan-offload -> ? rx-vlan-offload: on -> ? tx-vlan-offload: on +> $ ethtool -k eth0 | grep vlan-offload +> rx-vlan-offload: on +> tx-vlan-offload: on > -> ? $ ping -c 3 -I eth0.42 192.168.42.2 -> ? [...works as usual...] +> $ ping -c 3 -I eth0.42 192.168.42.2 +> [...works as usual...] > > Now switch off VLAN offloading and try again: > -> ? $ ethtool -K eth0 rxvlan off -> ? Actual changes: -> ? rx-vlan-offload: off -> ? tx-vlan-offload: off [requested on] -> ? $ ping -c 3 -I eth0.42 192.168.42.2 -> ? PING 192.168.42.2 (192.168.42.2) from 192.168.42.1 eth0.42: 56(84) +> $ ethtool -K eth0 rxvlan off +> Actual changes: +> rx-vlan-offload: off +> tx-vlan-offload: off [requested on] +> $ ping -c 3 -I eth0.42 192.168.42.2 +> PING 192.168.42.2 (192.168.42.2) from 192.168.42.1 eth0.42: 56(84) > bytes of data. > -> ? --- 192.168.42.2 ping statistics --- -> ? 3 packets transmitted, 0 received, 100% packet loss, time 1999ms +> --- 192.168.42.2 ping statistics --- +> 3 packets transmitted, 0 received, 100% packet loss, time 1999ms > > I can only reproduce it on an i350, the above works fine on a 82580. > @@ -36,18 +36,18 @@ On Wed, 2016-01-27 at 14:28 +0100, Corinna Vinschen wrote: > which sets the E1000_VMOLR_STRVLAN/E1000_DVMOLR_STRVLAN flags once > and > for all, and in all of the igb code there's no other place where the -> STRVLAN is set or cleared.? Thus, VLAN stripping is enabled in igb +> STRVLAN is set or cleared. Thus, VLAN stripping is enabled in igb > unconditionally, independently of the offloading setting. > > I compared that to the latest Intel igb-5.3.3.5 driver from -> http://sourceforge.net/projects/e1000/?which in fact sets and clears +> http://sourceforge.net/projects/e1000/ which in fact sets and clears > the > STRVLAN flag independently from igb_set_vmolr in its own function > igb_set_vf_vlan_strip, depending on the vlan settings. > > So I included the STRVLAN handling from the igb-5.3.3.5 driver into > our -> current igb driver and tested the above scenario again.? This time +> current igb driver and tested the above scenario again. This time > ping > still works after switching off VLAN offloading. > @@ -56,9 +56,9 @@ On Wed, 2016-01-27 at 14:28 +0100, Corinna Vinschen wrote: > > Signed-off-by: Corinna Vinschen <vinschen@redhat.com> > --- -> ?drivers/net/ethernet/intel/igb/igb_main.c | 39 +> drivers/net/ethernet/intel/igb/igb_main.c | 39 > ++++++++++++++++++++++++------- -> ?1 file changed, 31 insertions(+), 8 deletions(-) +> 1 file changed, 31 insertions(+), 8 deletions(-) I tried applying your patch to my tree for review and validation, but due to patches already applied against the igb driver in my tree, your @@ -69,10 +69,3 @@ git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue (next-queue tree and dev-queue branch) --------------- next part -------------- -A non-text attachment was scrubbed... -Name: signature.asc -Type: application/pgp-signature -Size: 819 bytes -Desc: This is a digitally signed message part -URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160127/25bfcc6e/attachment-0001.asc> diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..07b9bab --- /dev/null +++ b/N1/2.bin @@ -0,0 +1,17 @@ +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iQIcBAABCgAGBQJWqRmiAAoJEOVv75VaS+3OSP4P/REMz91LDBvSdjtfA0IKVdq0 +i1JPCBvQs4zmHudyJKj08Uw4eD632D+xVUYD1tafLQQiwL0rXrWBCP04k9PP1uOY +EuJnOyHjuXJJqyBkPkzkcwlUcZaVXJOUIQWqG7BmWl/+w81VHlmT1EZwnCK8lSzP +ZWAzLFs5cdJjmga0l9umDeDB3erJ5meiret8jUfS/4p8vLyj3cfv2F9p4dmW2au7 +W+QfGPlrFvI/XXFydtmyNKhYuZ9kSTHQm69sUPa3Yo+W8tpIIdAo+oqXITk86odV +N7kxHPwra4Q0niTT4dJiROIrfaQk5QJjpr9HJVqyWYOz8nC57Q1M9T1cojf8ktzU +M7a1XzbOBSZTL+1N8UjoRv7yRGVqeaJxtp19eWaywb1inrXfFmSMXAQ0LgRBRp4L +q+2AZgaDnhK90inxCvOcjegBu/tv4tW70lXta7KeV3uGpadFuEyGwAF/Pj0VMrvZ +26fQkQyx1SiyvE6xcbBYYLp9oytP9ZesfJetiDNn4jadAha3Y0ysq1Vibb6XKY33 +rXH8bcmEJgT3Ri9+7knsq6neuJ+xhkZBs0e3eGA/ZtWuJeCzpxnVmLb9PdTwEh7P +5KaUv9qtAbvOmqYKr8nvOBr6Duio++g8fOpqC2bYuNyLZ08sta8qTwRSwid0vZVd +IoJPfItfRbZM8MKFhvQS +=brAN +-----END PGP SIGNATURE----- diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..da6d245 --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: This is a digitally signed message part +Content-Transfer-Encoding: 7bit diff --git a/a/content_digest b/N1/content_digest index b617bf1..5b690ef 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,40 +1,42 @@ "ref\01453901284-32628-1-git-send-email-vinschen@redhat.com\0" "From\0Jeff Kirsher <jeffrey.t.kirsher@intel.com>\0" - "Subject\0[Intel-wired-lan] [PATCH] igb: Fix VLAN tag stripping on Intel i350\0" + "Subject\0Re: [PATCH] igb: Fix VLAN tag stripping on Intel i350\0" "Date\0Wed, 27 Jan 2016 11:25:22 -0800\0" - "To\0intel-wired-lan@osuosl.org\0" - "\00:1\0" + "To\0Corinna Vinschen <vinschen@redhat.com>" + " intel-wired-lan@lists.osuosl.org\0" + "Cc\0netdev@vger.kernel.org\0" + "\01:1\0" "b\0" "On Wed, 2016-01-27 at 14:28 +0100, Corinna Vinschen wrote:\n" "> Problem: When switching off VLAN offloading on an i350, the VLAN\n" - "> interface gets unusable.? For testing, set up a VLAN on an i350\n" + "> interface gets unusable.\302\240 For testing, set up a VLAN on an i350\n" "> and some remote machine, e.g.:\n" "> \n" - "> ? $ ip link add link eth0 name eth0.42 type vlan id 42\n" - "> ? $ ip addr add 192.168.42.1/24 dev eth0.42\n" - "> ? $ ip link set dev eth0.42 up\n" + "> \302\240 $ ip link add link eth0 name eth0.42 type vlan id 42\n" + "> \302\240 $ ip addr add 192.168.42.1/24 dev eth0.42\n" + "> \302\240 $ ip link set dev eth0.42 up\n" "> \n" "> Offloading is switched on by default:\n" "> \n" - "> ? $ ethtool -k eth0 | grep vlan-offload\n" - "> ? rx-vlan-offload: on\n" - "> ? tx-vlan-offload: on\n" + "> \302\240 $ ethtool -k eth0 | grep vlan-offload\n" + "> \302\240 rx-vlan-offload: on\n" + "> \302\240 tx-vlan-offload: on\n" "> \n" - "> ? $ ping -c 3 -I eth0.42 192.168.42.2\n" - "> ? [...works as usual...]\n" + "> \302\240 $ ping -c 3 -I eth0.42 192.168.42.2\n" + "> \302\240 [...works as usual...]\n" "> \n" "> Now switch off VLAN offloading and try again:\n" "> \n" - "> ? $ ethtool -K eth0 rxvlan off\n" - "> ? Actual changes:\n" - "> ? rx-vlan-offload: off\n" - "> ? tx-vlan-offload: off [requested on]\n" - "> ? $ ping -c 3 -I eth0.42 192.168.42.2\n" - "> ? PING 192.168.42.2 (192.168.42.2) from 192.168.42.1 eth0.42: 56(84)\n" + "> \302\240 $ ethtool -K eth0 rxvlan off\n" + "> \302\240 Actual changes:\n" + "> \302\240 rx-vlan-offload: off\n" + "> \302\240 tx-vlan-offload: off [requested on]\n" + "> \302\240 $ ping -c 3 -I eth0.42 192.168.42.2\n" + "> \302\240 PING 192.168.42.2 (192.168.42.2) from 192.168.42.1 eth0.42: 56(84)\n" "> bytes of data.\n" "> \n" - "> ? --- 192.168.42.2 ping statistics ---\n" - "> ? 3 packets transmitted, 0 received, 100% packet loss, time 1999ms\n" + "> \302\240 --- 192.168.42.2 ping statistics ---\n" + "> \302\240 3 packets transmitted, 0 received, 100% packet loss, time 1999ms\n" "> \n" "> I can only reproduce it on an i350, the above works fine on a 82580.\n" "> \n" @@ -43,18 +45,18 @@ "> which sets the E1000_VMOLR_STRVLAN/E1000_DVMOLR_STRVLAN flags once\n" "> and\n" "> for all, and in all of the igb code there's no other place where the\n" - "> STRVLAN is set or cleared.? Thus, VLAN stripping is enabled in igb\n" + "> STRVLAN is set or cleared.\302\240 Thus, VLAN stripping is enabled in igb\n" "> unconditionally, independently of the offloading setting.\n" "> \n" "> I compared that to the latest Intel igb-5.3.3.5 driver from\n" - "> http://sourceforge.net/projects/e1000/?which in fact sets and clears\n" + "> http://sourceforge.net/projects/e1000/\302\240which in fact sets and clears\n" "> the\n" "> STRVLAN flag independently from igb_set_vmolr in its own function\n" "> igb_set_vf_vlan_strip, depending on the vlan settings.\n" "> \n" "> So I included the STRVLAN handling from the igb-5.3.3.5 driver into\n" "> our\n" - "> current igb driver and tested the above scenario again.? This time\n" + "> current igb driver and tested the above scenario again.\302\240 This time\n" "> ping\n" "> still works after switching off VLAN offloading.\n" "> \n" @@ -63,9 +65,9 @@ "> \n" "> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>\n" "> ---\n" - "> ?drivers/net/ethernet/intel/igb/igb_main.c | 39\n" + "> \302\240drivers/net/ethernet/intel/igb/igb_main.c | 39\n" "> ++++++++++++++++++++++++-------\n" - "> ?1 file changed, 31 insertions(+), 8 deletions(-)\n" + "> \302\2401 file changed, 31 insertions(+), 8 deletions(-)\n" "\n" "I tried applying your patch to my tree for review and validation, but\n" "due to patches already applied against the igb driver in my tree, your\n" @@ -75,13 +77,27 @@ "git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git\n" "dev-queue\n" "\n" - "(next-queue tree and dev-queue branch)\n" - "-------------- next part --------------\n" - "A non-text attachment was scrubbed...\n" - "Name: signature.asc\n" - "Type: application/pgp-signature\n" - "Size: 819 bytes\n" - "Desc: This is a digitally signed message part\n" - URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160127/25bfcc6e/attachment-0001.asc> + (next-queue tree and dev-queue branch) + "\01:2\0" + "fn\0signature.asc\0" + "d\0This is a digitally signed message part\0" + "b\0" + "-----BEGIN PGP SIGNATURE-----\n" + "Version: GnuPG v1\n" + "\n" + "iQIcBAABCgAGBQJWqRmiAAoJEOVv75VaS+3OSP4P/REMz91LDBvSdjtfA0IKVdq0\n" + "i1JPCBvQs4zmHudyJKj08Uw4eD632D+xVUYD1tafLQQiwL0rXrWBCP04k9PP1uOY\n" + "EuJnOyHjuXJJqyBkPkzkcwlUcZaVXJOUIQWqG7BmWl/+w81VHlmT1EZwnCK8lSzP\n" + "ZWAzLFs5cdJjmga0l9umDeDB3erJ5meiret8jUfS/4p8vLyj3cfv2F9p4dmW2au7\n" + "W+QfGPlrFvI/XXFydtmyNKhYuZ9kSTHQm69sUPa3Yo+W8tpIIdAo+oqXITk86odV\n" + "N7kxHPwra4Q0niTT4dJiROIrfaQk5QJjpr9HJVqyWYOz8nC57Q1M9T1cojf8ktzU\n" + "M7a1XzbOBSZTL+1N8UjoRv7yRGVqeaJxtp19eWaywb1inrXfFmSMXAQ0LgRBRp4L\n" + "q+2AZgaDnhK90inxCvOcjegBu/tv4tW70lXta7KeV3uGpadFuEyGwAF/Pj0VMrvZ\n" + "26fQkQyx1SiyvE6xcbBYYLp9oytP9ZesfJetiDNn4jadAha3Y0ysq1Vibb6XKY33\n" + "rXH8bcmEJgT3Ri9+7knsq6neuJ+xhkZBs0e3eGA/ZtWuJeCzpxnVmLb9PdTwEh7P\n" + "5KaUv9qtAbvOmqYKr8nvOBr6Duio++g8fOpqC2bYuNyLZ08sta8qTwRSwid0vZVd\n" + "IoJPfItfRbZM8MKFhvQS\n" + "=brAN\n" + "-----END PGP SIGNATURE-----\n" -bcdf6e747866a28660928907d857c4a085ec65f438b9df626c644cf6b7369a4f +ba33d5a5b297ef9743f60828f63660c9c2314609bda54b773463593460f48543
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.