From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOe32-0008LI-Gt for qemu-devel@nongnu.org; Wed, 27 Jan 2016 23:19:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOe2z-0003qy-8F for qemu-devel@nongnu.org; Wed, 27 Jan 2016 23:19:08 -0500 Message-ID: <1453954736.3148.49.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Thu, 28 Jan 2016 15:18:56 +1100 In-Reply-To: <1453889591-30968-6-git-send-email-david@gibson.dropbear.id.au> References: <1453889591-30968-1-git-send-email-david@gibson.dropbear.id.au> <1453889591-30968-6-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Re: [Qemu-devel] [PATCHv2 05/10] target-ppc: Use actual page size encodings from HPTE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: lvivier@redhat.com, thuth@redhat.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org T24gV2VkLCAyMDE2LTAxLTI3IGF0IDIxOjEzICsxMTAwLCBEYXZpZCBHaWJzb24gd3JvdGU6 DQo+IEF0IHByZXNlbnQgdGhlIDY0LWJpdCBoYXNoIE1NVSBjb2RlIHVzZXMgaW5mb3JtYXRp b24gZnJvbSB0aGUgU0xCIHRvDQo+IGRldGVybWluZSB0aGUgcGFnZSBzaXplIG9mIGEgdHJh bnNsYXRpb24uwqDCoFdlIGRvIG5lZWQgdGhhdA0KPiBpbmZvcm1hdGlvbiB0bw0KPiBjb3Jy ZWN0bHkgbG9vayB1cCB0aGUgaGFzaCB0YWJsZS7CoMKgSG93ZXZlciB0aGUgTU1VIGFsc28g YWxsb3dzIGENCj4gcG9zc2libHkgbGFyZ2VyIHBhZ2Ugc2l6ZSB0byBiZSBlbmNvZGVkIGlu dG8gdGhlIEhQVEUgaXRzZWxmLCB3aGljaA0KPiBpcyB1c2VkDQo+IHRvIHBvcHVsYXRlIHRo ZSBUTEIuwqDCoEF0IHByZXNlbnQgcWVtdSBkb2Vzbid0IGNoZWNrIHRoYXQsIGFuZCBzbw0K PiBkb2Vzbid0DQo+IHN1cHBvcnQgdGhlIE1QU1MgIk11bHRpcGxlIFBhZ2UgU2l6ZSBwZXIg U2VnbWVudCIgZmVhdHVyZS4NCj4gDQo+IFRoaXMgbWFrZXMgYSBzdGFydCBvbiBhbGxvd2lu ZyB0aGlzLCBieSBhZGRpbmcgYW4gaHB0ZV9wYWdlX3NoaWZ0KCkNCj4gZnVuY3Rpb24gd2hp Y2ggbG9va3MgdXAgdGhlIHBhZ2Ugc2l6ZSBvZiBhbiBIUFRFLsKgwqBXZSB1c2UgdGhpcyB0 bw0KPiB2YWxpZGF0ZQ0KPiBwYWdlIHNpemVzIGVuY29kaW5ncyBvbiBmYXVsdHMsIGFuZCBw b3B1bGF0ZSB0aGUgcWVtdSBUTEIgd2l0aCBsYXJnZXINCj4gcGFnZSBzaXplcyB3aGVuIGFw cHJvcHJpYXRlLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogRGF2aWQgR2lic29uIDxkYXZpZEBn aWJzb24uZHJvcGJlYXIuaWQuYXU+DQoNCkFja2VkLWJ5OiBCZW5qYW1pbiBIZXJyZW5zY2ht aWR0IDxiZW5oQGtlcm5lbC5jcmFzaGluZy5vcmc+DQoNCihOb3RlIHRoYXQgd2UgZG9uJ3Qg YWN0dWFsbHkgcG9wdWxhdGUgdGhlIFFFTVUgVExCIHdpdGggYWxyZ2VyIHBhZ2UNCnNpemVz LCBpdCBkb2Vzbid0IHN1cHBvcnQgaXQgLi4uIEFsc28gaXQgdHJpZXMgdG8ga2VlcCB0cmFj ayBvZg0KdGhlIHByZXNlbmNlIG9mIGxhcmdlIHBhZ2VzIHRvIGRlYWwgd2l0aCB0YXJnZXR0 ZWQgaW52YWxpZGF0aW9ucw0KYnV0IHdlIGRvbid0IGRvIHRoZSBsYXR0ZXIgb24gaGFzaDY0 IGFuZCB3ZSB3b3VsZG4ndCBuZWVkIHRoYXQNCmV4dHJhIGNhcmUgYW55d2F5IHNpbmNlIG91 ciB0bGJpZSBjYXJyaWVzIHRoZSBwYWdlIHNpemUgYXMgd2VsbCkuDQoNCkNoZWVycywNCkJl bi4NCg0KPiAtLS0NCj4gwqB0YXJnZXQtcHBjL21tdS1oYXNoNjQuYyB8IDYzDQo+ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0NCj4gwqAxIGZp bGUgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4gDQo+IGRp ZmYgLS1naXQgYS90YXJnZXQtcHBjL21tdS1oYXNoNjQuYyBiL3RhcmdldC1wcGMvbW11LWhh c2g2NC5jDQo+IGluZGV4IGI3ODQ3OTEuLmVlMWU4YmYgMTAwNjQ0DQo+IC0tLSBhL3Rhcmdl dC1wcGMvbW11LWhhc2g2NC5jDQo+ICsrKyBiL3RhcmdldC1wcGMvbW11LWhhc2g2NC5jDQo+ IEBAIC0yMSw2ICsyMSw3IEBADQo+IMKgI2luY2x1ZGUgImV4ZWMvaGVscGVyLXByb3RvLmgi DQo+IMKgI2luY2x1ZGUgInFlbXUvZXJyb3ItcmVwb3J0LmgiDQo+IMKgI2luY2x1ZGUgInN5 c2VtdS9rdm0uaCINCj4gKyNpbmNsdWRlICJxZW11L2Vycm9yLXJlcG9ydC5oIg0KPiDCoCNp bmNsdWRlICJrdm1fcHBjLmgiDQo+IMKgI2luY2x1ZGUgIm1tdS1oYXNoNjQuaCINCj4gwqAN Cj4gQEAgLTQ3NCwxMiArNDc1LDUwIEBAIHN0YXRpYyBod2FkZHIgcHBjX2hhc2g2NF9odGFi X2xvb2t1cChQb3dlclBDQ1BVDQo+ICpjcHUsDQo+IMKgwqDCoMKgwqByZXR1cm4gcHRlX29m ZnNldDsNCj4gwqB9DQo+IMKgDQo+ICtzdGF0aWMgdW5zaWduZWQgaHB0ZV9wYWdlX3NoaWZ0 KGNvbnN0IHN0cnVjdCBwcGNfb25lX3NlZ19wYWdlX3NpemUNCj4gKnNwcywNCj4gK8KgwqDC oMKgdWludDY0X3QgcHRlMCwgdWludDY0X3QgcHRlMSkNCj4gK3sNCj4gK8KgwqDCoMKgaW50 IGk7DQo+ICsNCj4gK8KgwqDCoMKgaWYgKCEocHRlMCAmIEhQVEU2NF9WX0xBUkdFKSkgew0K PiArwqDCoMKgwqDCoMKgwqDCoGlmIChzcHMtPnBhZ2Vfc2hpZnQgIT0gMTIpIHsNCj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoC8qIDRraUIgcGFnZSBpbiBhIG5vbiA0a2lCIHNlZ21l bnQgKi8NCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAwOw0KPiArwqDCoMKg wqDCoMKgwqDCoH0NCj4gK8KgwqDCoMKgwqDCoMKgwqAvKiBOb3JtYWwgNGtpQiBwYWdlICov DQo+ICvCoMKgwqDCoMKgwqDCoMKgcmV0dXJuIDEyOw0KPiArwqDCoMKgwqB9DQo+ICsNCj4g K8KgwqDCoMKgZm9yIChpID0gMDsgaSA8IFBQQ19QQUdFX1NJWkVTX01BWF9TWjsgaSsrKSB7 DQo+ICvCoMKgwqDCoMKgwqDCoMKgY29uc3Qgc3RydWN0IHBwY19vbmVfcGFnZV9zaXplICpw cyA9ICZzcHMtPmVuY1tpXTsNCj4gK8KgwqDCoMKgwqDCoMKgwqB1aW50NjRfdCBtYXNrOw0K PiArDQo+ICvCoMKgwqDCoMKgwqDCoMKgaWYgKCFwcy0+cGFnZV9zaGlmdCkgew0KPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgYnJlYWs7DQo+ICvCoMKgwqDCoMKgwqDCoMKgfQ0KPiAr DQo+ICvCoMKgwqDCoMKgwqDCoMKgaWYgKHBzLT5wYWdlX3NoaWZ0ID09IDEyKSB7DQo+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAvKiBMIGJpdCBpcyBzZXQgc28gdGhpcyBjYW4ndCBi ZSBhIDRraUIgcGFnZSAqLw0KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgY29udGludWU7 DQo+ICvCoMKgwqDCoMKgwqDCoMKgfQ0KPiArDQo+ICvCoMKgwqDCoMKgwqDCoMKgbWFzayA9 ICgoMVVMTCA8PCBwcy0+cGFnZV9zaGlmdCkgLSAxKSAmIEhQVEU2NF9SX1JQTjsNCj4gKw0K PiArwqDCoMKgwqDCoMKgwqDCoGlmICgocHRlMSAmIG1hc2spID09IChwcy0+cHRlX2VuYyA8 PCBIUFRFNjRfUl9SUE5fU0hJRlQpKSB7DQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBy ZXR1cm4gcHMtPnBhZ2Vfc2hpZnQ7DQo+ICvCoMKgwqDCoMKgwqDCoMKgfQ0KPiArwqDCoMKg wqB9DQo+ICsNCj4gK8KgwqDCoMKgcmV0dXJuIDA7IC8qIEJhZCBwYWdlIHNpemUgZW5jb2Rp bmcgKi8NCj4gK30NCj4gKw0KPiDCoGludCBwcGNfaGFzaDY0X2hhbmRsZV9tbXVfZmF1bHQo UG93ZXJQQ0NQVSAqY3B1LCB0YXJnZXRfdWxvbmcgZWFkZHIsDQo+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGlu dCByd3gsIGludCBtbXVfaWR4KQ0KPiDCoHsNCj4gwqDCoMKgwqDCoENQVVN0YXRlICpjcyA9 IENQVShjcHUpOw0KPiDCoMKgwqDCoMKgQ1BVUFBDU3RhdGUgKmVudiA9ICZjcHUtPmVudjsN Cj4gwqDCoMKgwqDCoHBwY19zbGJfdCAqc2xiOw0KPiArwqDCoMKgwqB1bnNpZ25lZCBhcHNo aWZ0Ow0KPiDCoMKgwqDCoMKgaHdhZGRyIHB0ZV9vZmZzZXQ7DQo+IMKgwqDCoMKgwqBwcGNf aGFzaF9wdGU2NF90IHB0ZTsNCj4gwqDCoMKgwqDCoGludCBwcF9wcm90LCBhbXJfcHJvdCwg cHJvdDsNCj4gQEAgLTU0Myw2ICs1ODIsMTggQEAgaW50IHBwY19oYXNoNjRfaGFuZGxlX21t dV9mYXVsdChQb3dlclBDQ1BVICpjcHUsDQo+IHRhcmdldF91bG9uZyBlYWRkciwNCj4gwqDC oMKgwqDCoHFlbXVfbG9nX21hc2soQ1BVX0xPR19NTVUsDQo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAiZm91bmQgUFRFIGF0IG9mZnNldCAlMDgiIEhXQUREUl9QUkl4 ICJcbiIsDQo+IHB0ZV9vZmZzZXQpOw0KPiDCoA0KPiArwqDCoMKgwqAvKiBWYWxpZGF0ZSBw YWdlIHNpemUgZW5jb2RpbmcgKi8NCj4gK8KgwqDCoMKgYXBzaGlmdCA9IGhwdGVfcGFnZV9z aGlmdChzbGItPnNwcywgcHRlLnB0ZTAsIHB0ZS5wdGUxKTsNCj4gK8KgwqDCoMKgaWYgKCFh cHNoaWZ0KSB7DQo+ICvCoMKgwqDCoMKgwqDCoMKgZXJyb3JfcmVwb3J0KCJCYWQgcGFnZSBz aXplIGVuY29kaW5nIGluIEhQVEUgMHglIlBSSXg2NCIgLQ0KPiAweCUiUFJJeDY0DQo+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAiIEAgMHglIkhXQURE Ul9QUkl4LCBwdGUucHRlMCwgcHRlLnB0ZTEsDQo+IHB0ZV9vZmZzZXQpOw0KPiArwqDCoMKg wqDCoMKgwqDCoC8qIE5vdCBlbnRpcmVseSBzdXJlIHdoYXQgdGhlIHJpZ2h0IGFjdGlvbiBo ZXJlLCBidXQgbWFjaGluZQ0KPiArwqDCoMKgwqDCoMKgwqDCoMKgKiBjaGVjayBzZWVtcyBy ZWFzb25hYmxlICovDQo+ICvCoMKgwqDCoMKgwqDCoMKgY3MtPmV4Y2VwdGlvbl9pbmRleCA9 IFBPV0VSUENfRVhDUF9NQ0hFQ0s7DQo+ICvCoMKgwqDCoMKgwqDCoMKgZW52LT5lcnJvcl9j b2RlID0gMDsNCj4gK8KgwqDCoMKgwqDCoMKgwqByZXR1cm4gMTsNCj4gK8KgwqDCoMKgfQ0K PiArDQo+IMKgwqDCoMKgwqAvKiA1LiBDaGVjayBhY2Nlc3MgcGVybWlzc2lvbnMgKi8NCj4g wqANCj4gwqDCoMKgwqDCoHBwX3Byb3QgPSBwcGNfaGFzaDY0X3B0ZV9wcm90KGNwdSwgc2xi LCBwdGUpOw0KPiBAQCAtNTk1LDEwICs2NDYsMTAgQEAgaW50IHBwY19oYXNoNjRfaGFuZGxl X21tdV9mYXVsdChQb3dlclBDQ1BVDQo+ICpjcHUsIHRhcmdldF91bG9uZyBlYWRkciwNCj4g wqANCj4gwqDCoMKgwqDCoC8qIDcuIERldGVybWluZSB0aGUgcmVhbCBhZGRyZXNzIGZyb20g dGhlIFBURSAqLw0KPiDCoA0KPiAtwqDCoMKgwqByYWRkciA9IGRlcG9zaXQ2NChwdGUucHRl MSAmIEhQVEU2NF9SX1JQTiwgMCwgc2xiLT5zcHMtDQo+ID5wYWdlX3NoaWZ0LCBlYWRkcik7 DQo+ICvCoMKgwqDCoHJhZGRyID0gZGVwb3NpdDY0KHB0ZS5wdGUxICYgSFBURTY0X1JfUlBO LCAwLCBhcHNoaWZ0LCBlYWRkcik7DQo+IMKgDQo+IMKgwqDCoMKgwqB0bGJfc2V0X3BhZ2Uo Y3MsIGVhZGRyICYgVEFSR0VUX1BBR0VfTUFTSywgcmFkZHIgJg0KPiBUQVJHRVRfUEFHRV9N QVNLLA0KPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHByb3QsIG1tdV9p ZHgsIFRBUkdFVF9QQUdFX1NJWkUpOw0KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoHByb3QsIG1tdV9pZHgsIDFVTEwgPDwgYXBzaGlmdCk7DQo+IMKgDQo+IMKgwqDC oMKgwqByZXR1cm4gMDsNCj4gwqB9DQo+IEBAIC02MDksNiArNjYwLDcgQEAgaHdhZGRyIHBw Y19oYXNoNjRfZ2V0X3BoeXNfcGFnZV9kZWJ1ZyhQb3dlclBDQ1BVDQo+ICpjcHUsIHRhcmdl dF91bG9uZyBhZGRyKQ0KPiDCoMKgwqDCoMKgcHBjX3NsYl90ICpzbGI7DQo+IMKgwqDCoMKg wqBod2FkZHIgcHRlX29mZnNldDsNCj4gwqDCoMKgwqDCoHBwY19oYXNoX3B0ZTY0X3QgcHRl Ow0KPiArwqDCoMKgwqB1bnNpZ25lZCBhcHNoaWZ0Ow0KPiDCoA0KPiDCoMKgwqDCoMKgaWYg KG1zcl9kciA9PSAwKSB7DQo+IMKgwqDCoMKgwqDCoMKgwqDCoC8qIEluIHJlYWwgbW9kZSB0 aGUgdG9wIDQgZWZmZWN0aXZlIGFkZHJlc3MgYml0cyBhcmUgaWdub3JlZA0KPiAqLw0KPiBA QCAtNjI1LDcgKzY3NywxMiBAQCBod2FkZHIgcHBjX2hhc2g2NF9nZXRfcGh5c19wYWdlX2Rl YnVnKFBvd2VyUENDUFUNCj4gKmNwdSwgdGFyZ2V0X3Vsb25nIGFkZHIpDQo+IMKgwqDCoMKg wqDCoMKgwqDCoHJldHVybiAtMTsNCj4gwqDCoMKgwqDCoH0NCj4gwqANCj4gLcKgwqDCoMKg cmV0dXJuIGRlcG9zaXQ2NChwdGUucHRlMSAmIEhQVEU2NF9SX1JQTiwgMCwgc2xiLT5zcHMt DQo+ID5wYWdlX3NoaWZ0LCBhZGRyKQ0KPiArwqDCoMKgwqBhcHNoaWZ0ID0gaHB0ZV9wYWdl X3NoaWZ0KHNsYi0+c3BzLCBwdGUucHRlMCwgcHRlLnB0ZTEpOw0KPiArwqDCoMKgwqBpZiAo IWFwc2hpZnQpIHsNCj4gK8KgwqDCoMKgwqDCoMKgwqByZXR1cm4gLTE7DQo+ICvCoMKgwqDC oH0NCj4gKw0KPiArwqDCoMKgwqByZXR1cm4gZGVwb3NpdDY0KHB0ZS5wdGUxICYgSFBURTY0 X1JfUlBOLCAwLCBhcHNoaWZ0LCBhZGRyKQ0KPiDCoMKgwqDCoMKgwqDCoMKgwqAmIFRBUkdF VF9QQUdFX01BU0s7DQo+IMKgfQ0KPiDCoA0K