From: David Howells <dhowells@redhat.com>
To: paulmck@linux.vnet.ibm.com
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
akpm@linux-foundation.org, niv@us.ibm.com, dvhltc@us.ibm.com,
lethal@linux-sh.org, kernel@wantstofly.org, matthew@wil.cx
Subject: Re: [PATCH] v3 RCU: the bloatwatch edition
Date: Tue, 28 Apr 2009 22:39:59 +0100 [thread overview]
Message-ID: <1454.1240954799@redhat.com> (raw)
In-Reply-To: <20090428194537.GN6730@linux.vnet.ibm.com>
Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> Your thought is that some of the functions could be moved to tinyrcu.h?
> Indeed, some of them would be smaller if inlined than even the call
> sequence. For example, rcu_needs_cpu() should remove code from the
> dynticks implementation given that it always returns zero.
tinyrcu.h is probably not a bad idea. Some of the functions are trivial, and
the code to do a function call is bigger than the body of the function itself.
rcu_exit_nohz(), rcu_nmi_enter/exit(), rcu_batches_completed[_bh](), for
example. Even call_rcu() and call_rcu_bh() might perhaps benefit from
inlining.
David
next prev parent reply other threads:[~2009-04-28 21:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 18:34 [PATCH] v2 RCU: the bloatwatch edition Paul E. McKenney
2009-03-29 20:31 ` [PATCH] v3 " Paul E. McKenney
2009-04-02 22:36 ` Ingo Molnar
2009-04-02 22:44 ` Andrew Morton
2009-04-03 0:02 ` Paul E. McKenney
2009-04-03 6:52 ` Andi Kleen
2009-04-03 10:45 ` Lennert Buytenhek
2009-04-02 22:44 ` Paul Mundt
2009-04-08 16:38 ` Ingo Molnar
2009-04-08 16:55 ` Paul Mundt
2009-04-08 18:44 ` Paul E. McKenney
2009-04-28 14:24 ` David Howells
2009-04-28 19:45 ` Paul E. McKenney
2009-04-28 21:39 ` David Howells [this message]
2009-04-29 0:57 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454.1240954799@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dvhltc@us.ibm.com \
--cc=kernel@wantstofly.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.