From: Gerd Hoffmann <kraxel@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: Zuozhi Fzz <zuozhi.fzz@alibaba-inc.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH] usb: ehci: add capability mmio write function
Date: Fri, 29 Jan 2016 14:45:14 +0100 [thread overview]
Message-ID: <1454075114.14284.2.camel@redhat.com> (raw)
In-Reply-To: <1454072434-16045-1-git-send-email-ppandit@redhat.com>
On Fr, 2016-01-29 at 18:30 +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> USB Ehci emulation supports host controller capability registers.
> But its mmio '.write' function was missing, which lead to a null
> pointer dereference issue. Add a do nothing 'ehci_caps_write'
> definition to avoid it; Do nothing because capability registers
> are Read Only(RO).
Surely makes sense, xhci does the same, I'll pick it up.
Maybe we should have a generic nop_write function somewhere. Not that
there can much go wrong by cut&pasting here, but still ...
cheers,
Gerd
next prev parent reply other threads:[~2016-01-29 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 13:00 [Qemu-devel] [PATCH] usb: ehci: add capability mmio write function P J P
2016-01-29 13:45 ` Gerd Hoffmann [this message]
2016-01-29 16:48 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454075114.14284.2.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zuozhi.fzz@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.