From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hetzner.pbcl.net (mail.pbcl.net [88.198.119.4]) by mail.openembedded.org (Postfix) with ESMTP id A2E2D77250 for ; Sat, 30 Jan 2016 11:43:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=[IPv6:2001:67c:1810:f051:fa2f:a8ff:feb0:ae33]) by hetzner.pbcl.net with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1aPTwQ-0007BE-Tu; Sat, 30 Jan 2016 12:43:47 +0100 Message-ID: <1454154224.7421.7.camel@pbcl.net> From: Phil Blundell To: Hongxu Jia Date: Sat, 30 Jan 2016 11:43:44 +0000 In-Reply-To: References: X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 2/5] gcc-5.3.inc/base.bbclass: add gcc option to not record -fdebug-prefix-map to debugging info X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2016 11:43:51 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2016-01-29 at 12:35 -0500, Hongxu Jia wrote: > +If option gno-record-debug-prefix-map used, it does not > +record -fdebug-prefix-map to gcc command line switches > +in DWARF DW_AT_producer. > + > +Upstream-Status: Inappropriate [oe specific] If you consider this to be oe-specific and inappropriate for upstream, wouldn't it be better to make the new behaviour default to on and not have to add an extra option to the CFLAGS? (You could still provide a switch to restore the old behaviour for those who want it.) Alternatively, if the new behaviour defaults to off, there doesn't seem any reason that this patch couldn't and shouldn't be sent upstream. p.