From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Matthew Hall <mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>,
Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 3/5] i40e: support selecting hash functions
Date: Thu, 24 Jul 2014 10:07:37 +0200 [thread overview]
Message-ID: <1454201.eyrodsIZYi@xps13> (raw)
In-Reply-To: <20140724080113.GB21277-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-24 01:01, Matthew Hall:
> On Thu, Jul 24, 2014 at 09:59:23AM +0200, Thomas Monjalon wrote:
> > Is it really a good idea to configure this kind of thing at build time?
> > Maybe yes, I'm not sure.
>
> Whether it's safe to set at runtime probably depends what happens to the card
> if it gets changed. Do you have to reset the card or the port? Or is it OK if
> it's more dynamic?
No, we can change configuration with rte_eth_dev_configure() before
initializing port. So it is truly configurable.
Requiring recompilation means it's not really configurable between 2 runs.
And it breaks binary packaging for Linux distributions.
Many things in DPDK are configured at build time. But we should wonder if
it's really a good design.
--
Thomas
next prev parent reply other threads:[~2014-07-24 8:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 6:42 [PATCH 0/5] Support configuring hash functions Helin Zhang
[not found] ` <1406184149-11531-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-07-24 6:42 ` [PATCH 1/5] ethdev: Rename macros of packet classification type Helin Zhang
[not found] ` <1406184149-11531-2-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-07-24 7:48 ` Thomas Monjalon
2014-07-24 8:14 ` Zhang, Helin
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627BF-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-24 8:19 ` Thomas Monjalon
2014-07-24 8:23 ` Zhang, Helin
2014-07-24 6:42 ` [PATCH 2/5] ethdev: add new ops of 'check_command_supported' and 'rx_classification_filter_ctl' Helin Zhang
[not found] ` <1406184149-11531-3-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-07-24 7:56 ` Thomas Monjalon
2014-07-24 8:49 ` Zhang, Helin
2014-07-24 6:42 ` [PATCH 3/5] i40e: support selecting hash functions Helin Zhang
[not found] ` <1406184149-11531-4-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-07-24 7:59 ` Thomas Monjalon
2014-07-24 8:01 ` Matthew Hall
[not found] ` <20140724080113.GB21277-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-24 8:07 ` Thomas Monjalon [this message]
2014-07-24 8:14 ` Matthew Hall
[not found] ` <0344b116-248f-4f64-9ef7-31be52ba8632-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2014-07-24 8:54 ` Zhang, Helin
2014-07-24 6:42 ` [PATCH 4/5] i40e: support configuring symmetric hash function Helin Zhang
2014-07-24 6:42 ` [PATCH 5/5] app/testpmd: new commands for configuring hash functions Helin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454201.eyrodsIZYi@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.