From: Johannes Berg <johannes@sipsolutions.net>
To: Sven Eckelmann <sven@open-mesh.com>
Cc: linux-wireless@vger.kernel.org, thomas@net.t-labs.tu-berlin.de,
antonio@open-mesh.com, nbd@nbd.name
Subject: Re: [PATCH] mac80211: minstrel: Scale expected_throughput by 10
Date: Mon, 01 Feb 2016 13:57:53 +0100 [thread overview]
Message-ID: <1454331473.3211.3.camel@sipsolutions.net> (raw)
In-Reply-To: <7460390.ua0GvOE4DE@bentobox> (sfid-20160201_135611_528149_53AC3A85)
On Mon, 2016-02-01 at 13:56 +0100, Sven Eckelmann wrote:
> On Monday 01 February 2016 13:30:37 Johannes Berg wrote:
> > On Mon, 2016-02-01 at 13:24 +0100, Sven Eckelmann wrote:
> > > The change from cur_tp to the function
> > > minstrel_get_tp_avg/minstrel_ht_get_tp_avg changed the unit used
> > > for
> > > the
> > > current throughtput. For example in minstrel_ht the correct
> > > conversion between them would be:
> > >
> > > mrs->cur_tp / 10 == minstrel_ht_get_tp_avg(..).
> > >
> > > This factor 10 must also be included in the calculation of
> > > minstrel_get_expected_throughput and
> > > minstrel_ht_get_expected_throughput to
> > > get similar results as before the change.
> > >
> >
> > 10 is a pretty expensive factor, perhaps that should use 16
> > instead?
>
> Not really funny but I will change the title.
Huh? Not sure what you mean. I really meant to change 10 to 16 overall
as far as the factor is concerned, since division by/multiplication
with 16 is far easier in base 2 than by/with 10.
johannes
next prev parent reply other threads:[~2016-02-01 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 12:24 [PATCH] mac80211: minstrel: Scale expected_throughput by 10 Sven Eckelmann
2016-02-01 12:30 ` Johannes Berg
2016-02-01 12:56 ` Sven Eckelmann
2016-02-01 12:57 ` Johannes Berg [this message]
2016-02-01 12:58 ` Antonio Quartulli
2016-02-01 13:01 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454331473.3211.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=antonio@open-mesh.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sven@open-mesh.com \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.