From: Joe Perches <joe@perches.com>
To: Rakhi Sharma <rakhish1994@gmail.com>,
Jes.Sorensen@redhat.com, gregkh@linuxfoundation.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] Staging: rtl8723au: core: rtw_ieee80211: Fixed a coding style Warning.
Date: Mon, 01 Feb 2016 06:51:05 -0800 [thread overview]
Message-ID: <1454338265.7329.67.camel@perches.com> (raw)
In-Reply-To: <1454331104-16835-1-git-send-email-rakhish1994@gmail.com>
On Mon, 2016-02-01 at 18:21 +0530, Rakhi Sharma wrote:
> Fixed a braces style warning.
> Warning: braces {} are not necessary for single statement blocks.
[]
> diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
[]
> @@ -176,11 +176,9 @@ u8 *rtw_get_ie23a(u8 *pbuf, int index, int *len, int limit)
> int tmp, i;
> u8 *p;
>
> - if (limit < 1) {
> + if (limit < 1)
>
> return NULL;
> - }
> -
> p = pbuf;
> i = 0;
> *len = 0;
This ends up as:
if (limit < 1)
return NULL;
p = pbuf;
And isn't particularly more readable.
It would be better as:
if (limit < 1)
return NULL;
p = pbuf;
etc...
prev parent reply other threads:[~2016-02-01 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 12:51 [PATCH 4/4] Staging: rtl8723au: core: rtw_ieee80211: Fixed a coding style Warning Rakhi Sharma
2016-02-01 14:51 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454338265.7329.67.camel@perches.com \
--to=joe@perches.com \
--cc=Jes.Sorensen@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rakhish1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.