From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] xen: recalculate per-cpupool credits when
 updating timeslice
Date: Tue, 2 Feb 2016 12:33:00 +0100
Message-ID: <1454412780.9227.87.camel@citrix.com>
References: <1454062908-32013-1-git-send-email-jgross@suse.com>
	<56AB511402000078000CC59C@suse.com> <56AB45FE.5010500@suse.com>
	<1454406782.9227.27.camel@citrix.com> <56B08679.3060807@suse.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4099500858936052796=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56B08679.3060807@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Juergen Gross <jgross@suse.com>, Jan Beulich <JBeulich@suse.com>
Cc: george.dunlap@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============4099500858936052796==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-0vUtUegm7HplpFrVBB1R"

--=-0vUtUegm7HplpFrVBB1R
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2016-02-02 at 11:35 +0100, Juergen Gross wrote:
> On 02/02/16 10:53, Dario Faggioli wrote:
> >=C2=A0
> > In any case, since the lack of locking and lack of recalculation
> > look
> > like two pretty independent existing bugs to me, can we have
> > either:
> > =C2=A0a. two patches;
> > =C2=A0b. one patch but with both the issues described in the changelog.
> >=20
> > My preference going to a.
>=20
> Without setting prv->credit the lock isn't necessary. In case of a
> race domain weights wouldn't be honored correctly for just one
> timeslice and I doubt this would be noticeable at all.
>=20
Ah, yes, I see what you mean now!!

> OTOH I don't mind splitting the patch into two, I have to respin
> anyway.
>=20
Well, no, given you explanation above, to which I agree (sory for not
seeing this before), keeping it being just one patch would actually be
better IMO...

But then, please, explain in the changelog that the recalculation would
introduce a race, and hence you also need to lock.

Thanks and regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-0vUtUegm7HplpFrVBB1R
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlawk+0ACgkQk4XaBE3IOsQk3ACgjzfuJHdk2TbXDkjqJBvLQ3w7
f68AnRIvNiR4/uLj74YCTQHStdeOuo+u
=qP/k
-----END PGP SIGNATURE-----

--=-0vUtUegm7HplpFrVBB1R--


--===============4099500858936052796==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4099500858936052796==--