All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Colin Vidal <colin@cvidal.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: fix coding style in rtl8188eu/core
Date: Tue, 02 Feb 2016 14:51:55 -0800	[thread overview]
Message-ID: <1454453515.7291.44.camel@perches.com> (raw)
In-Reply-To: <1454448513.3898.3.camel@cvidal.org>

On Tue, 2016-02-02 at 22:28 +0100, Colin Vidal wrote:
> On Tue, 2016-02-02 at 13:14 -0800, Joe Perches wrote:
> > On Tue, 2016-02-02 at 21:57 +0100, Colin Vidal wrote:
> > > Set constant on the left of the test, and jump a new line to avoid to
> > > exceed the 80 char length limit.
> > []
> > > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
[]
> > bool rtw_IOL_applied(struct adapter *adapter)
> > {
> > 	return adapter->registrypriv.fw_iol == 1 ||
> > 	       (adapter->registrypriv.fw_iol == 2 &&
> > 		!adapter_to_dvobj(adapter)->ishighspeed);
> > }
> > 
> 
> Oh, yeah, the second one is obviously finer. If I'm right, I should
> resend a new patch with a subject which looks something like "[PATCH
> v2] ... " ? 

correct.

  reply	other threads:[~2016-02-02 22:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 20:57 [PATCH] Staging: fix coding style in rtl8188eu/core Colin Vidal
2016-02-02 21:14 ` Joe Perches
2016-02-02 21:28   ` Colin Vidal
2016-02-02 22:51     ` Joe Perches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-02-02 22:54 Colin Vidal
2016-02-02 23:04 ` Colin Vidal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454453515.7291.44.camel@perches.com \
    --to=joe@perches.com \
    --cc=colin@cvidal.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.