All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-architecture
	<openembedded-architecture@lists.openembedded.org>,
	bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [Openembedded-architecture] [PATCH] data_smart: Drop default expand=False to getVarFlag [API change]
Date: Wed, 03 Feb 2016 08:00:25 +0000	[thread overview]
Message-ID: <1454486425.27087.149.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAMKF1spSfcfM-AAC4fPNUiRykQaZ0_zUpzQNFfb8nOOeS7t8-g@mail.gmail.com>

On Tue, 2016-02-02 at 21:36 -0800, Khem Raj wrote:
> On Tue, Feb 2, 2016 at 3:55 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > At some point in the future, getVarFlag should expand by default.
> > To
> > get there from the current position, we need a period of time where
> > the
> > expand parameter is mandatory.
> > 
> 
> what are advantages of this.

Most users expect the data to be expanded by default. Most call sites
also use getVar(xxx, True), its uncommon to see expand=False, outside
the core of bitbake.

So the ultimate advantage is a more sensible default which is what the
user expects and leads to neater/smaller code.

We have had several bugs requesting this and it does confuse people.

I have heard regrets from some of the original developers that the
default wasn't True as well.

Cheers,

Richard



  reply	other threads:[~2016-02-03  8:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 23:55 [PATCH] data_smart: Drop default expand=False to getVarFlag [API change] Richard Purdie
2016-02-03  5:36 ` [Openembedded-architecture] " Khem Raj
2016-02-03  8:00   ` Richard Purdie [this message]
2016-02-03 14:42     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454486425.27087.149.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=openembedded-architecture@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.