From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 3/3] tools/libxl: run_helper - add #define for arguments. Date: Wed, 3 Feb 2016 11:48:57 +0000 Message-ID: <1454500137.25207.89.camel@citrix.com> References: <1453756017-8747-1-git-send-email-konrad.wilk@oracle.com> <1453756017-8747-4-git-send-email-konrad.wilk@oracle.com> <1453825413.25257.33.camel@citrix.com> <22183.40435.478055.57571@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aQvvh-0002nn-16 for xen-devel@lists.xenproject.org; Wed, 03 Feb 2016 11:49:01 +0000 In-Reply-To: <22183.40435.478055.57571@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2016-01-26 at 16:25 +0000, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 3/3] tools/libxl: run_helper - add > #define for arguments."): > > On Mon, 2016-01-25 at 16:06 -0500, Konrad Rzeszutek Wilk wrote: > > > Describe what the four (or more in the future) arguments > > > are for. > > > > I'd say that a code comment on the definition would be sufficient here, > > but > > I'll defer to Ian J as author of this code. > > Acked-by: Ian Jackson Applied.