From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, pgynther@google.com, opendmb@gmail.com,
jaedon.shin@gmail.com, Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net 1/4] net: phy: bcm7xxx: Fix shadow mode 2 disabling
Date: Wed, 3 Feb 2016 13:13:46 -0800 [thread overview]
Message-ID: <1454534029-585-2-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1454534029-585-1-git-send-email-f.fainelli@gmail.com>
The clear and set masks in the call to phy_set_clr_bits() called from
bcm7xxx_config_init() are inverted. We need to fix this by swapping the two
arguments, that is, set 0 bits, but clear the shade mode 2 enable bit.
Fixes: b560a58c45c66 ("net: phy: add Broadcom BCM7xxx internal PHY driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/bcm7xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c
index bf241a3ec5e5..234a28502793 100644
--- a/drivers/net/phy/bcm7xxx.c
+++ b/drivers/net/phy/bcm7xxx.c
@@ -270,7 +270,7 @@ static int bcm7xxx_config_init(struct phy_device *phydev)
phy_write(phydev, MII_BCM7XXX_100TX_FALSE_CAR, 0x7555);
/* reset shadow mode 2 */
- ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, MII_BCM7XXX_SHD_MODE_2, 0);
+ ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, 0, MII_BCM7XXX_SHD_MODE_2);
if (ret < 0)
return ret;
--
2.1.0
next prev parent reply other threads:[~2016-02-03 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 21:13 [PATCH net 0/4] net: phy: bcm7xxx 40nm PHY fixes Florian Fainelli
2016-02-03 21:13 ` Florian Fainelli [this message]
2016-02-03 21:13 ` [PATCH net 2/4] net: phy: bcm7xxx: Fix 40nm EPHY features Florian Fainelli
2016-02-03 21:13 ` [PATCH net 3/4] net: phy: bcm7xxx: Fix bcm7xxx_config_init() check Florian Fainelli
2016-02-03 21:13 ` [PATCH net 4/4] net: phy: bcm7xxx: Make MII_BCM7XX_64CLK_MDIO naming consistent Florian Fainelli
2016-02-06 1:25 ` [PATCH net 0/4] net: phy: bcm7xxx 40nm PHY fixes Florian Fainelli
2016-02-06 7:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454534029-585-2-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jaedon.shin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.