From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lubomir Rintel Subject: Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Date: Thu, 04 Feb 2016 08:18:13 +0100 Message-ID: <1454570293.25750.23.camel@v3.sk> References: <1454511759-24827-1-git-send-email-lkundrak@v3.sk> <1454511759-24827-3-git-send-email-lkundrak@v3.sk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Chen , Olivier Blin Cc: "linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Peter Chen List-Id: devicetree@vger.kernel.org On Thu, 2016-02-04 at 06:28 +0000, Peter Chen wrote: > =C2=A0 > > Lubomir Rintel writes: > >=20 > > > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > index ef54050..32bbd2a 100644 > > > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > >=20 > > Hi, > >=20 > > Shouldn't this be common to all RPi1 B and RPi2 models, instead of > > being > > specific to just RPi B+? > >=20 > > > +&usb { > > > + usb1@01 { > > > + compatible =3D "usb1d6b,0002"; > > > + reg =3D <01>; > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + ethernet: usbether@01 { > > > + compatible =3D "usb0424,9514"; > > > + reg =3D <01>; > > > + }; > > > + }; > > > +}; > >=20 > > For reference, on RPi2: >=20 > Using "lsusb -t" you may get bus topology. >=20 > > Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. > > SMSC9512/9514 Fast Ethernet Adapter >=20 > It is the ethernet device, you may need to change vid/pid in dts.=C2=A0 >=20 > > Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. > > SMC9514 Hub >=20 > It is the hub device, you may need to change vid/pid in dts. >=20 > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > >=20 > =C2=A0 > It is root hub, it doesn't need to be described at dts. Thank you; neither of the vid/pid pairs in the original submission is okay. I'll follow up with an updated version. I've also checked this on RPi B rev2; and I'll be including that one, and the RPI2 too. I can't find my rev1 RPi B; but maybe I can just do the same for the same board. It would likely work, but I may get the vid/pid wrong if it's different from rev2.=C2=A0 > Best regards, > Peter Thanks Lubo -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933019AbcBDHSa (ORCPT ); Thu, 4 Feb 2016 02:18:30 -0500 Received: from shell.v3.sk ([92.60.52.57]:40826 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755458AbcBDHS2 convert rfc822-to-8bit (ORCPT ); Thu, 4 Feb 2016 02:18:28 -0500 Message-ID: <1454570293.25750.23.camel@v3.sk> Subject: Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree From: Lubomir Rintel To: Peter Chen , Olivier Blin Cc: "linux-rpi-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Peter Chen Date: Thu, 04 Feb 2016 08:18:13 +0100 In-Reply-To: References: <1454511759-24827-1-git-send-email-lkundrak@v3.sk> <1454511759-24827-3-git-send-email-lkundrak@v3.sk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-02-04 at 06:28 +0000, Peter Chen wrote: >   > > Lubomir Rintel writes: > > > > > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > index ef54050..32bbd2a 100644 > > > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > > Hi, > > > > Shouldn't this be common to all RPi1 B and RPi2 models, instead of > > being > > specific to just RPi B+? > > > > > +&usb { > > > + usb1@01 { > > > + compatible = "usb1d6b,0002"; > > > + reg = <01>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + ethernet: usbether@01 { > > > + compatible = "usb0424,9514"; > > > + reg = <01>; > > > + }; > > > + }; > > > +}; > > > > For reference, on RPi2: > > Using "lsusb -t" you may get bus topology. > > > Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. > > SMSC9512/9514 Fast Ethernet Adapter > > It is the ethernet device, you may need to change vid/pid in dts.  > > > Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. > > SMC9514 Hub > > It is the hub device, you may need to change vid/pid in dts. > > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > >   > It is root hub, it doesn't need to be described at dts. Thank you; neither of the vid/pid pairs in the original submission is okay. I'll follow up with an updated version. I've also checked this on RPi B rev2; and I'll be including that one, and the RPI2 too. I can't find my rev1 RPi B; but maybe I can just do the same for the same board. It would likely work, but I may get the vid/pid wrong if it's different from rev2.  > Best regards, > Peter Thanks Lubo