From: Joe Perches <joe@perches.com>
To: Glen Lee <glen.lee@atmel.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
tony.cho@atmel.com, leo.kim@atmel.com, austin.shin@atmel.com,
Chris.Park@atmel.com, adham.abozaeid@atmel.com,
Nicolas.FERRE@atmel.com
Subject: Re: [PATCH RESEND 70/70] staging: wilc1000: remove warnings line over 80 characters
Date: Thu, 04 Feb 2016 09:38:11 -0800 [thread overview]
Message-ID: <1454607491.14997.13.camel@perches.com> (raw)
In-Reply-To: <1454577871-667-31-git-send-email-glen.lee@atmel.com>
On Thu, 2016-02-04 at 18:24 +0900, Glen Lee wrote:
> From: Leo Kim <leo.kim@atmel.com>
>
> This patch removes the warnings reported by checkpatch.pl
> for line over 80 characters.
>
> Signed-off-by: Leo Kim <leo.kim@atmel.com>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
[]
> @@ -4,7 +4,7 @@
> #include
> #include
> #define TAG_PARAM_OFFSET (MAC_HDR_LEN + TIME_STAMP_LEN + \
> - BEACON_INTERVAL_LEN + CAP_INFO_LEN)
> + BEACON_INTERVAL_LEN + CAP_INFO_LEN)
Another style is to use the continuation on the first line
#define TAG_PARAM_OFFSET \
(MAC_HDR_LEN + TIME_STAMP_LEN + BEACON_INTERVAL_LEN + CAP_INFO_LEN)
>
> enum basic_frame_type {
> FRAME_TYPE_CONTROL = 0x04,
> @@ -337,8 +337,10 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
> tim_elm = get_tim_elm(msa, rx_len + FCS_LEN, index);
> if (tim_elm)
> network_info->dtim_period = tim_elm[3];
> - ies = &msa[MAC_HDR_LEN + TIME_STAMP_LEN + BEACON_INTERVAL_LEN + CAP_INFO_LEN];
> - ies_len = rx_len - (MAC_HDR_LEN + TIME_STAMP_LEN + BEACON_INTERVAL_LEN + CAP_INFO_LEN);
> + ies = &msa[MAC_HDR_LEN + TIME_STAMP_LEN + BEACON_INTERVAL_LEN +
> + CAP_INFO_LEN];
> + ies_len = rx_len - (MAC_HDR_LEN + TIME_STAMP_LEN +
> + BEACON_INTERVAL_LEN + CAP_INFO_LEN);
Pretty funny that a TAG_PARAM_OFFSET change is in the same patch
It'd be simpler to use that define here.
ies = &msa[TAG_PARAM_OFFSET];
ies_len = rx_len - TAG_PARAM_OFFSET;
> if (!connect_resp_info->ies)
next prev parent reply other threads:[~2016-02-04 17:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 9:24 [PATCH RESEND 40/70] staging: wilc1000: wilc_wlan.c: replaces PRINT_ER with netdev_err Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 41/70] staging: wilc1000: linux_mon.c: " Glen Lee
2016-02-07 21:44 ` Greg KH
2016-02-04 9:24 ` [PATCH RESEND 42/70] staging: wilc1000: remove unused log message using the CORECONFIG_DBG tag Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 43/70] staging: wilc1000: remove unused log message using the HOSTINF_DBG tag Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 44/70] staging: wilc1000: remove unused log message using the TX_DBG tag Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 45/70] staging: wilc1000: removes function 'wilc_dealloc_network_info()' Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 46/70] staging: wilc1000: removes function 'wilc_dealloc_assoc_resp_info()' Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 47/70] staging: wilc1000: remove typedef from tstrConnectRespInfo Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 48/70] staging: wilc1000: renames struct connect_resp_info variables Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 49/70] staging: wilc1000: remove typedef from pstrNetworkInfo Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 50/70] staging: wilc1000: renames s8rssi of connect_resp_info structure Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 51/70] staging: wilc1000: renames u16CapInfo " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 52/70] staging: wilc1000: renames au8ssid " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 53/70] staging: wilc1000: renames u8SsidLen " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 54/70] staging: wilc1000: renames au8bssid " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 55/70] staging: wilc1000: renames u16BeaconPeriod " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 56/70] staging: wilc1000: renames u8DtimPeriod " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 57/70] staging: wilc1000: renames u8channel " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 58/70] staging: wilc1000: renames struct connect_resp_info variables Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 59/70] staging: wilc1000: renames bNewNetwork of connect_resp_info structure Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 60/70] staging: wilc1000: renames u8Found " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 61/70] staging: wilc1000: renames u32Tsf " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 62/70] staging: wilc1000: renames struct connect_resp_info variables Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 63/70] staging: wilc1000: renames pJoinParams of connect_resp_info structure Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 64/70] staging: wilc1000: renames strRssi " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 65/70] staging: wilc1000: renames u64Tsf " Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 66/70] staging: wilc1000: remove unnecessary wilc_rx_complete function Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 67/70] staging: wilc1000: remove unused log message using the RX_DBG tag Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 68/70] staging: wilc1000: remove unused debug tag Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 69/70] staging: wilc1000: remove unnecessary log message using GENERIC_DBG tag Glen Lee
2016-02-04 9:24 ` [PATCH RESEND 70/70] staging: wilc1000: remove warnings line over 80 characters Glen Lee
2016-02-04 17:38 ` Joe Perches [this message]
2016-02-07 21:43 ` [PATCH RESEND 40/70] staging: wilc1000: wilc_wlan.c: replaces PRINT_ER with netdev_err Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454607491.14997.13.camel@perches.com \
--to=joe@perches.com \
--cc=Chris.Park@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.