From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "davem@davemloft.net" <davem@davemloft.net>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"Nelson, Shannon" <shannon.nelson@intel.com>,
"aduyck@mirantis.com" <aduyck@mirantis.com>,
"thomas.petazzoni@free-electrons.com"
<thomas.petazzoni@free-electrons.com>,
"mcarlson@broadcom.com" <mcarlson@broadcom.com>,
"yuvalmin@broadcom.com" <yuvalmin@broadcom.com>,
"amirv@mellanox.com" <amirv@mellanox.com>,
"Williams, Mitch A" <mitch.a.williams@intel.com>,
"_govind@gmx.com" <_govind@gmx.com>,
"Lendacky@vger.kernel.org" <Lendacky@vger.kernel.org>,
"Tantilov, Emil S" <emil.s.tantilov@intel.com>,
"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
"mirq-linux@rere.qmqm.pl" <mirq-linux@rere.qmqm.pl>,
"hariprasad@chelsio.com" <hariprasad@chelsio.com>,
"kalesh.purayil@emulex.com" <kalesh.purayil@emulex.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"mchan@broadcom.com" <mchan@broadcom.com>,
"Wyborny, Carolyn" <carolyn.wyb
Subject: Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands
Date: Fri, 5 Feb 2016 16:42:40 +0000 [thread overview]
Message-ID: <1454690560.3349.1.camel@intel.com> (raw)
In-Reply-To: <20160204.193055.2172651314284452037.davem@davemloft.net>
On Thu, 2016-02-04 at 19:30 -0500, David Miller wrote:
> From: "Keller, Jacob E" <jacob.e.keller@intel.com>
> Date: Thu, 4 Feb 2016 23:09:56 +0000
>
> > So you're suggesting instead, to error when the second operation
> > (change number of queues) would fail the current settings?
>
> Yes.
>
> This is absolutely required.
I will investigate this route. I think there needs to some way for the
{GS}RXFH to pass enough information in a way the driver can clearly see
as "reset to default", but otherwise I think this is pretty straight
forward to implement.
Thanks,
Jake
next prev parent reply other threads:[~2016-02-05 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 23:22 [PATCH] ethtool: add dynamic flag to {SG}RXFH Jacob Keller
2016-02-02 23:22 ` [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands Jacob Keller
2016-02-04 22:53 ` David Miller
2016-02-04 23:09 ` Keller, Jacob E
2016-02-05 0:30 ` David Miller
2016-02-05 16:42 ` Keller, Jacob E [this message]
2016-02-02 23:22 ` [PATCH 2/2] fm10k: support dynamic mode for RSS table control Jacob Keller
2016-02-02 23:22 ` [PATCH] ethtool: add support for dynamic mode in {SG}RXFH commands Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454690560.3349.1.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=Lendacky@vger.kernel.org \
--cc=_govind@gmx.com \
--cc=aduyck@mirantis.com \
--cc=amirv@mellanox.com \
--cc=andrew@lunn.ch \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=hariprasad@chelsio.com \
--cc=kalesh.purayil@emulex.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@intel.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.